From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id AF3C847CD for ; Thu, 21 Jul 2016 15:37:16 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id i5so25681269wmg.0 for ; Thu, 21 Jul 2016 06:37:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=FmmoY56ZHU+TMOKPv5uaTCXyDJch/NW2q918mD/8OzI=; b=IsJDwlIBKF9qEx64T675qth0SreDx0RIH1gOcX/0py8SvmERMaCSEC/ozpxWIL6ROl HKC2eYN3CobQcDJRBSOxD+CLyZVrQRKJN6n3xvjE6HTr6W5cx7k9F2uUxSpOpEssgJKh jlOrRmP1nbJBZwS4cAd6VHlQW+uxpggSr8ILxRE2OjxMIItNYGqhTCaowSG4ObssIpqS q8CCjUgnPNLUsGJbgLUgX3BSZw/a2n+qzI6RWg7IsEUlvuI+Q9VVlrsnUXfw0QmL84Gq WAKjT4nyA+hmL/1FYK085rqQPQbrzv3SCk2gz8v+V1NzBbbJv19YRoNo9gM137gSUpht QF7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=FmmoY56ZHU+TMOKPv5uaTCXyDJch/NW2q918mD/8OzI=; b=ZMDLt+Lxzb2cxeuDkJPVFjZBx0h4Q2sUx0o1s/5L33uyNVkIenFiNSuqIcp1/WuilJ 7LHVVXEeL9ORBGkx8gezKNjYxClvL+n3jD0BUQGD6hkQ3CyOBvyUZDP/Vm3JCE78O5Qz vch+DEv6jhwUsgQ3EOgD07HmLr3RN+1PUbObUopZTmurqumGOPhXm5kHwK7zrqebRv1m /FtUutdfM8zJd5ac1e3H9JL6Iwiym99qBY+MUl9RN8OIQ9IHWHSLwOkcEuSbgdKlxkNv bMebrChHvjWB7btgNMVr7x/pLc2dZoBT6irmZGf3FK2xwdSWSU4LhnUgtb9qKxEjJqkZ yeAg== X-Gm-Message-State: ALyK8tJUdlu8DzbThqBZMHmSdEgk8N5zV35Yfgt3LKrK390qySesiG9MOSF7wealwn9qXW9L X-Received: by 10.28.35.193 with SMTP id j184mr17381199wmj.33.1469108236482; Thu, 21 Jul 2016 06:37:16 -0700 (PDT) Received: from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id 17sm4177539wmf.6.2016.07.21.06.37.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Jul 2016 06:37:15 -0700 (PDT) Date: Thu, 21 Jul 2016 15:37:09 +0200 From: Adrien Mazarguil To: "Chandran, Sugesh" Cc: "dev@dpdk.org" , Thomas Monjalon , "Zhang, Helin" , "Wu, Jingjing" , Rasesh Mody , Ajit Khaparde , Rahul Lakkireddy , "Lu, Wenzhuo" , Jan Medala , John Daley , "Chen, Jing D" , "Ananyev, Konstantin" , Matej Vido , Alejandro Lucero , Sony Chacko , Jerin Jacob , "De Lara Guarch, Pablo" , Olga Shern , "Chilikin, Andrey" Message-ID: <20160721133709.GS7621@6wind.com> Mail-Followup-To: "Chandran, Sugesh" , "dev@dpdk.org" , Thomas Monjalon , "Zhang, Helin" , "Wu, Jingjing" , Rasesh Mody , Ajit Khaparde , Rahul Lakkireddy , "Lu, Wenzhuo" , Jan Medala , John Daley , "Chen, Jing D" , "Ananyev, Konstantin" , Matej Vido , Alejandro Lucero , Sony Chacko , Jerin Jacob , "De Lara Guarch, Pablo" , Olga Shern , "Chilikin, Andrey" References: <20160708130310.GD7621@6wind.com> <2EF2F5C0CC56984AA024D0B180335FCB13DEB236@IRSMSX102.ger.corp.intel.com> <20160713200327.GC7621@6wind.com> <2EF2F5C0CC56984AA024D0B180335FCB13DEE55F@IRSMSX102.ger.corp.intel.com> <20160715150402.GE7621@6wind.com> <2EF2F5C0CC56984AA024D0B180335FCB13E02938@IRSMSX102.ger.corp.intel.com> <20160718150029.GJ7621@6wind.com> <2EF2F5C0CC56984AA024D0B180335FCB13E05C5C@IRSMSX102.ger.corp.intel.com> <20160720171033.GQ7621@6wind.com> <2EF2F5C0CC56984AA024D0B180335FCB13E062E8@IRSMSX102.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2EF2F5C0CC56984AA024D0B180335FCB13E062E8@IRSMSX102.ger.corp.intel.com> Subject: Re: [dpdk-dev] [RFC] Generic flow director/filtering/classification API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2016 13:37:16 -0000 Hi Sugesh, I do not have much to add, please see below. On Thu, Jul 21, 2016 at 11:06:52AM +0000, Chandran, Sugesh wrote: [...] > > > RSS hashing support :- Just to confirm, the RSS flow action allows > > > application to decide the header fields to produce the hash. This > > > gives programmability on load sharing across different queues. The > > > application can program the NIC to calculate the RSS hash only using > > > mac or mac+ ip or ip only using this. > > > > I'd say yes but from your summary, I'm not sure we share the same idea of > > what the RSS action is supposed to do, so here is mine. > > > > Like all flow rules, the pattern part of the RSS action only filters the packets > > on which the action will be performed. > > > > The rss_conf parameter (struct rte_eth_rss_conf) only provides a key and a > > RSS hash function to use (ETH_RSS_IPV4, ETH_RSS_NONFRAG_IPV6_UDP, > > etc). > > > > Nothing prevents the RSS hash function from being applied to protocol > > headers which are not necessarily present in the flow rule pattern. These are > > two independent things, e.g. you could have a pattern matching IPv4 packets > > yet perform RSS hashing only on UDP headers. > > > > Finally, the RSS action configuration only affects packets coming from this > > flow rule. It is not performed on the device globally so packets which are not > > matched are not affected by RSS processing. As a result it might not be > > possible to configure two flow rules specifying incompatible RSS actions > > simultaneously if the underlying device supports only a single global RSS > > context. > > > [Sugesh] thank you for the explanation. This means I can have a rule that matches on > Every incoming packets(all field wild card rule) and does RSS hash on selected fields, > MAC only, IP only or IP & MAC? Yes, I guess it could even replace the current method for configuring RSS on a device in a more versatile fashion, but this is a topic for another debate. Let's implement this API first! > This can be useful to do a packet lookup in software by just using > Only hash. Not sure to fully understand your idea, but I'm positive it could be done somehow :) -- Adrien Mazarguil 6WIND