From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org, Christian Ehrhardt <christian.ehrhardt@canonical.com>
Subject: Re: [dpdk-dev] [PATCH] unify tools naming
Date: Fri, 22 Jul 2016 18:36:34 +0800 [thread overview]
Message-ID: <20160722103634.GO28708@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <2761669.Unk5LuuApo@xps13>
On Fri, Jul 22, 2016 at 10:04:13AM +0200, Thomas Monjalon wrote:
> 2016-07-22 09:46, Yuanhan Liu:
> > On Wed, Jul 20, 2016 at 04:24:30PM +0200, Thomas Monjalon wrote:
> > > The following tools may be installed system-wise.
> >
> > Yes, indeed. Following is an example from dpdk package shipped in
> > ubutun 16.04:
> >
> > dpdk: /etc/dpdk/dpdk.conf
> > dpdk: /etc/dpdk/interfaces
> > dpdk: /etc/init.d/dpdk
> > dpdk: /lib/dpdk/dpdk-init
> > dpdk: /lib/systemd/system/dpdk.service
> > dpdk: /sbin/dpdk_nic_bind
> > dpdk: /usr/bin/dpdk_proc_info
> > dpdk: /usr/bin/testpmd
> > dpdk: /usr/share/doc/dpdk/changelog.Debian.gz
> > dpdk: /usr/share/doc/dpdk/copyright
> > dpdk: /usr/share/dpdk/tools/cpu_layout.py
> > dpdk: /usr/share/dpdk/tools/dpdk_nic_bind.py
> > dpdk: /usr/share/dpdk/tools/setup.sh
> >
> > > It may be cleaner and more convenient to find them with the same
> > > dpdk- prefix (especially for autocompletion).
> >
> > Agreed.
> >
> > > Moreover, the script dpdk_nic_bind.py deserves a new name because it is
> > > not restricted to NICs and can be used for e.g. crypto.
> >
> > Second that. But we might need doc the name change to let user aware of
> > that.
>
> There is a note in API changes section.
> And every references in the doc are renamed.
>
> > > These files are renamed:
> > > pmdinfogen -> dpdk-pmdinfogen
> > > pmdinfo.py -> dpdk-pmdinfo.py
> > > dpdk_pdump -> dpdk-pdump
> > > dpdk_proc_info -> dpdk-procinfo
> > > dpdk_nic_bind.py -> dpdk-devbind.py
> > > setup.sh -> dpdk-setup.sh
> > >
> > > The tools pmdinfogen, pmdinfo.py and dpdk_pdump are new in 16.07.
> > >
> > > The scripts dpdk_nic_bind.py and setup.sh may have been used with
> > > previous releases by end users. That's why a symbolic link still
> > > provide the old name in the installed tools directory.
> >
> > I was about suggesting the same thing: yes, we should keep the
> > backward compatibility.
>
> Does it mean you ack this patch?
Yes, here is an explict one:
Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
--yliu
next prev parent reply other threads:[~2016-07-22 10:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 14:24 Thomas Monjalon
2016-07-22 1:46 ` Yuanhan Liu
2016-07-22 8:04 ` Thomas Monjalon
2016-07-22 10:36 ` Yuanhan Liu [this message]
2016-07-22 20:31 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160722103634.GO28708@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).