From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0081.outbound.protection.outlook.com [104.47.38.81]) by dpdk.org (Postfix) with ESMTP id 73482559C for ; Sat, 23 Jul 2016 08:05:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=3y2CUsbGk0DNXRyaLKaHN9CaWb+mhW9Y4tyivbANMu8=; b=LrOFE/cI84RRN3iWoffpY1jdAniY6cMo2xDe+2F5Oa5HwkgAqBs0aS0lwTiszGK0nHVXcf1qKPzpVdWezTTeHbva06HxD5lkE9SxUxitlo3vxNG9YecU+yQRppgOQ6VZKxsF7j1rW28c0U92VwwWEagguibYcAYhaX+/0YrTo+E= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (171.48.19.161) by BY1PR0701MB1721.namprd07.prod.outlook.com (10.162.111.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.544.10; Sat, 23 Jul 2016 06:05:36 +0000 Date: Sat, 23 Jul 2016 11:35:16 +0530 From: Jerin Jacob To: Thomas Monjalon CC: Juhamatti Kuusisaari , , "Ananyev, Konstantin" Message-ID: <20160723060515.GA13747@localhost.localdomain> References: <20160715043951.32040-1-juhamatti.kuusisaari@coriant.com> <2601191342CEEE43887BDE71AB97725836B7E32F@irsmsx105.ger.corp.intel.com> <14017551.U6D1dIIx0P@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <14017551.U6D1dIIx0P@xps13> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [171.48.19.161] X-ClientProxiedBy: PN1PR01CA0007.INDPRD01.PROD.OUTLOOK.COM (10.164.137.14) To BY1PR0701MB1721.namprd07.prod.outlook.com (10.162.111.140) X-MS-Office365-Filtering-Correlation-Id: 060ee1fc-1dd3-44f0-47b1-08d3b2bf5e6a X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1721; 2:WMvm8pTbIbhmgrrs+vNMZxj6CXq9Ig35Oce0Da9RjVFLe/oH1T5/cYFhdx0hPNlfgyVHBmN/7XarUF86XuK/5+MWIjDLptE2IraVpy23g6lcPESegW9+jraytzmDo0747xO+vsTxu+WviI+mI5VXNkoxdRSwyDhfW7OXnkoEkiZe7oy/fErWcPVwInHj4r7/; 3:+Oied//eZ5rNnyNmm3sa14zz9YZuxr/pMczsUEgTK+HVO+TCvIfSXN+NPU38CEEvwYGQUaAsJXl9aJ55gKwiCaMdR7xdRteHfqPLqp89D2a5vsFez7lArPS9l9ttjdax X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0701MB1721; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1721; 25:+MqhH02ycUu02cZrLqyHoZk+7L28UQkSpmAqh1KUa2HossQgFVxB+V6f5OH99VwyL3XJTT5YO8m3ylMQ7rJ2UyVAv1D5qAsrSkj0m8Q1txmKvFYeMM92sxU51Gwsfg+yiJTRJTN44LvA1ghNfUSo+pdsUXF8nXzi9fUdzNuZowF5xRh2Dj2OuZOklpaE55k7nEhvF1OrPxAoOfbnOUxIFqBwuy6rfZDcUG+TY1LeK3Tt5/xhBKqJFgZLuoH7nRRnNJqJX2AuSbrXjFElBnPUviSFH0sQkXgctIwg5fBlY9q7hNFYTLJirKmPPRCaE+olLI30+wAsOl4EgDn65a3tJaqwiEbs55WEBcYeH5bouNjNBYBMr+DXoLnYECGZR3TW5mhIvDNdPVFjD9qWb14lnM34UdliucckmMDST9DW5qvjN1bKy8SpDv7mvi4S1llZZVPcBTLmw/EFU0n7psu6R0bYYkDE3YbI8xZJvcNMY2/qJOJ5tLaTZe8PT1kJ3HvrajXDA/+THddlrr/FELCJIsHcUs5IAlUIFsh8eHpZ3py1WMKwZjNt/DZOUdqVlBM1CqFMtCvilti+Pa8M5DMuTMg1CeN19L9U/Eq+DwgzWF/kGzUYACIohnwmBRw+jZ7Xnb/4jkEtAGjBxzDSn5xIFbbRFBfNWcb47nn95rK8lTNU31B0xw68IVGQuxwd0hQ1nVczoQAaF6XC7T80UV2h7v2tkYzmtz4nejvbMft/Z5oFqMtgpUQs83Iboix4Mh1XW4r8f3OqrHxLml2vPllgeVPEHjy1pspbWUmJPMFNbU6lw+SejZ1S1z5g5yiCWdBu X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1721; 31:E1+/R7dC6ry1DNOjvNrWELhSQdXqsIsL2eee88hWyA97aA3PtLdNIloPHiZje0m8oPEDcV5x3XFNGdXW0RnwegYsS46q5p6Jyxlo4fuKa8sUjRXwRpZLiTwvFK/DwHO+Felqu8v8uf0htqCW1O1YZku60+9w13Ai4PzCR8+hfV2TAdDWiKkwRzABQQ5YP1LltkxKcevZAAZM3RuFxdsKgA==; 20:Awrj1CcfY0zh5rh6B2vBkFncivW6/VctDAjaxTkU69RIyFrr1z//oDDz20FjVDo2t+xW1DK/NT5gDtEFp0iZ1udcNTuDKx1BBZvQ2pzi/rDWMsl4cLqq3Hia4hpjJa0I8mVLNbtxCIU7flk25195QunadZu8gwnE+Cx1rTIGoT3Pv5XOIPxTzK5BAIHW/ySyql5pssXxaX+Ao8cU8Ly0pNWxpFuaYEWd3oUCLcmZy0tp/DLZ5L/uMvyBeRzjAL9e1C6mEtY1wY3bd6o8WXVgcJnGCU2GnYeXpiKPgx6kFFxF1uvaQ02YtN4gi6S4O8UabcqgKrXiB6ufTpzVVCDCa4iy6KbuiRIf9g32tVd1VFxIG+K1wiH+pE7T8x3sn7TPovi7VsnUEZzZHjyo1uyBIxtSCoALqs8PDN2oM+vL9bh9A9AK5YoepbZrBk96J1fx1v60AvrwrpHbpzFnevgGjw6skAYmORJwIhvJjk6jShPbxRUnIzgcDmK3UvFv2GIllVq4KqOAQdbrWPR3CZmZ5pxR7sGbUN3cLjEEV3RVI0b/khqKZgkZEyMd0+bb4l7wJr5tgYHxKYMeuEe0A6xzwsXx6hZzO1Y4kuwt4zGY1DQ= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(51653755401839)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046); SRVR:BY1PR0701MB1721; BCL:0; PCL:0; RULEID:; SRVR:BY1PR0701MB1721; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1721; 4:pvqPFczvQKd1iSUJSaMrIkBGzKhjUoTC3TTBz3ndqdVZflmUhcVFhZ44sDUFhxhfKXlvouqUoC4UwBo8b+ztbNPfTrAQf4ScPpwmp6KSWBM3gK3qntV+0PB84HMpboHD3YUG6uZJy1Wu+S+/NWuco+zTEJUD2Uk8bVj2M9cpVM6m78neuuatYYaclsAW/3Ykw2eU630W+DnXTvpkOVwnSsgxI5gfrBekT2Dc02I2JcC8LRWlijYf/gWNjp5AeTvfhUz8I3cOTdm0LsB7KDkHL6qvvfbG1ItkGqruJhbE/mTcPsxMAIYSLUXBvuR4MMg9G1NHvmkE1cxAMB/aiG2UphxZ85cNuYe4afJi9FX43CmH875us0NiBMNeCulHhyZBBnOPu22Qu5NLU+5S7mM3mQHBTD5S0XSOl9V6wuXTl3tDh21de/XYMzlgHT+uzvwY X-Forefront-PRVS: 0012E6D357 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6069001)(6009001)(7916002)(199003)(189002)(24454002)(4001350100001)(15975445007)(101416001)(33656002)(97736004)(23726003)(77096005)(7110500001)(189998001)(586003)(6116002)(3846002)(81156014)(61506002)(97756001)(47776003)(15395725005)(76176999)(54356999)(110136002)(66066001)(1076002)(2950100001)(50986999)(2420400007)(92566002)(46406003)(2906002)(4326007)(50466002)(10710500007)(19580395003)(15650500001)(19580405001)(8666005)(105586002)(106356001)(9686002)(42186005)(68736007)(83506001)(305945005)(7736002)(81166006)(7846002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BY1PR0701MB1721; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY1PR0701MB1721; 23:VfHBFi/zrjK44zX9Qfn3qGPfmFvgjaqt8ofLBTg?= =?us-ascii?Q?nurVVLoukfWQYl69eCL52udnUbCJECdNMudP+aaPwrQAWxtUuXX2uYbiHPH3?= =?us-ascii?Q?iKbY7LxBGcs2XQ0ZVfopR+eBD+XHaACa0BRRYJ+AzFQcyB1qPPRr01W4lOwa?= =?us-ascii?Q?Vf4s4YyRsdcHeBg7IWRVhkjqpORJysuueuHsE59jganQwHTyXGWSfAwtOoj6?= =?us-ascii?Q?j6DpXill5AW9Bf7Km77sfZpAW4TkCzJvn4JjADgCyh0qWUYXPX0HOBVCa/ap?= =?us-ascii?Q?97/mmd3VJyQHD3Eqc/72osy9HAyYP7BwjxErRWcVxEvrGklHwh75SLg/NaIx?= =?us-ascii?Q?mYbOXXDanzMRDdjEw/Gpwu04xZYRH4eYgqXgks5HeSo71kfpubk52T52pTJs?= =?us-ascii?Q?gc5mHpQBd2QAJdCcu4mZA6gM6CA+gAkRtEAgsBK/nQt0dEcNpROliav2DDFy?= =?us-ascii?Q?hXif5SRcT8965itIOpeIWdMdqLwpX7G4K4y6yKNFR4ZINbfyqDGN4WV6Il9C?= =?us-ascii?Q?6hs+KXkSfRZdzAsGzgTCLe9CE4ft6dnR+1nngH2zf3abufKoC65ZWHS6Qhwa?= =?us-ascii?Q?Fy/q2HP4OiZlxq6IkNnWiFvWdc0HQni3Dg7/Eom6kdrT8yIZQhJmUEUcIwSG?= =?us-ascii?Q?ePh50JT8gX/QT5XHP5wQiOOGOI1Ow3j9vi6MB5DBiqd1NnSFM8sE1ioxlXW3?= =?us-ascii?Q?n/ntBay0qyf/oHG29kGmIfdHnfW+jTPRg/q6ItjFo8YXwDptqNXoBA3/9NfY?= =?us-ascii?Q?nJPzPUvRLhj0lT6C8Xw7eFFWd3RXdW/Xri8hDGdihQDTk7KCcezcP1zbCOFG?= =?us-ascii?Q?BpwPulJFauB+//jYDiqaDG89Hb2gtEgJR+YFzoeyVbDBGWs6lcLt9WzKO8GJ?= =?us-ascii?Q?IiiYLosjd7zVBX68x3KqXDeFqMIEfkqXvSmhSbIAHZgQQqAY5QPsYRPOt9n8?= =?us-ascii?Q?Iz39+KzuaAB9jVMZb56/5mvR2jcZJI9gUbXwt9ztJuFbhqNXQ08fq/bDOgpK?= =?us-ascii?Q?IL6u2ide83mj9dBvAB18cp37aohJ47QHhNjcBMS6pFj//LKkW72UDQTzR98x?= =?us-ascii?Q?kLfIUT4bIiJBrpXvgiIB8w63X4hIBN86HCs5bUdFVxwAQG9VD4GxxggFdc3F?= =?us-ascii?Q?3stvPsMn80GuUyfrVqrlAkdfGGBJRzw5O3TkQ+6q4B7EpAgCSZR5kZSXGx58?= =?us-ascii?Q?kq1aHEB7iEzVQNcZh0R6QxCRqyHQUjJ1ksUVSUqHESgLBADHvI2fm0ZBDqqu?= =?us-ascii?Q?rsjVAtjzya5fOkJduqlDEJRCbPAxqhI2RqPhW1LG6yz8nRceaN+dneSSswBx?= =?us-ascii?Q?uULsk4Q0bOKoUiwiQqyZXBLPS6m4Iy4IuX0auSh/BilNc?= X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1721; 6:YIfN0j8aMl2UNbCO50ZPWZrHevyUsgmGvStObGOrMDVKVgf+vAViBACyJrAdI46o+CnvYSXke0aGc/ovuO430i7h32Wdi6q32UiZpM2nBDnW1T/wv8UFK8coUMsGVgvZAOlGJlkIxiQS+WnWhxbJrdqqLUlvpB+Vf4NSFZ9a9esOaEb/zDa/SaEMW+axrdFvEcI9jzuojybEKbfcc2vUDuZPdtmhAoF3NySOBeLKDRULGwv61Ko23T4mTR+g5/o4UMWP08qfRWxyhowXHnxFcilAKq1s1uK7v0ZMWBfbJcM=; 5:vtC0+EWgpTSwaaAnWcGrXDg5x8g/QfzIqOMP60dqc7fJFM906VFEze7ngwS2sj2W/4phsMugAiB5EBGzebMMSg/cmQss0fa2ZJ/4U6JMsxmmB6HnJFgKGIPIURQ8bU3f3JhZhJ8hwVUmP+NmAkKpAw==; 24:bgpsJvtu4nQRX+m5orkGg8FBq5zN4tCdcD+TeBAvNTqrBF8bhDNHK/C8OqHNQBamjhoM4eJZ/aQG4a0hHnm1u0P1JcxjXNZHSWqrspGs5AI=; 7:2jKp9hFGNTVxMQJLN273myC6KCNZbKvt8fnsRQKY3jek7+lmOgE61IJ5dbcBTaHR+s61JZRVGCH/5OAEZ1osq3Ht76A17+TLeHuhiOiYMo815k4pI5BRpAuhHe75s9xO4Km7DPPTMlv8ErUjDHVYO/iQFfJF9i2+9DkqouvIkE10S2hGmTLY9aEJbw9YCZCemriHyAr6MkGGCAlEkXlCyC13bitG7gkMoOC6+13n/u5oE9J1VRhBXl/Elqsl5S6T SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2016 06:05:36.3397 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0701MB1721 Subject: Re: [dpdk-dev] [PATCH] lib: change rte_ring dequeue to guarantee ordering before tail update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jul 2016 06:05:43 -0000 On Thu, Jul 21, 2016 at 11:26:50PM +0200, Thomas Monjalon wrote: > > > Consumer queue dequeuing must be guaranteed to be done fully before the tail is updated. This is not guaranteed with a read barrier, > > > changed to a write barrier just before tail update which in practice guarantees correct order of reads and writes. > > > > > > Signed-off-by: Juhamatti Kuusisaari > > > > Acked-by: Konstantin Ananyev > > Applied, thanks There was ongoing discussion on this http://dpdk.org/ml/archives/dev/2016-July/044168.html This change may not be required as it has the performance impact.