From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0054.outbound.protection.outlook.com [104.47.38.54]) by dpdk.org (Postfix) with ESMTP id 6F0055594 for ; Wed, 27 Jul 2016 19:11:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=KIcC+hZVqqaw5KcPviw88wUBkN0tcVeMTKP0mGJitKw=; b=LpG/KahFf+n61eM+MN64PrFmtdhFRQRqH6OeP/350MHMynmoCzHLqb6xpODCeFH0r4hFcxnbKJnekied5ddLlYxwklqmXbZ4ZJxwaw6GyfVgl79j2nhGYpKCMfl9AMwzLTH4BdNpB1zHgGJGyqOe8vOnH7h56OWHA8tFDvBRVj0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (171.48.22.252) by BLUPR0701MB1716.namprd07.prod.outlook.com (10.163.85.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.549.15; Wed, 27 Jul 2016 17:11:02 +0000 Date: Wed, 27 Jul 2016 22:40:45 +0530 From: Jerin Jacob To: Thomas Monjalon CC: "Kulasek, TomaszX" , , "Ananyev, Konstantin" Message-ID: <20160727171043.GA22116@localhost.localdomain> References: <1469024691-58750-1-git-send-email-tomaszx.kulasek@intel.com> <1469114659-66063-1-git-send-email-tomaszx.kulasek@intel.com> <2601191342CEEE43887BDE71AB97725836B80AD8@irsmsx105.ger.corp.intel.com> <2146153.nVzdynOqdk@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <2146153.nVzdynOqdk@xps13> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [171.48.22.252] X-ClientProxiedBy: MAXPR01CA0019.INDPRD01.PROD.OUTLOOK.COM (10.164.147.26) To BLUPR0701MB1716.namprd07.prod.outlook.com (10.163.85.142) X-MS-Office365-Filtering-Correlation-Id: e77c09f0-b878-447c-cd1b-08d3b640fdb3 X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 2:8P2FQLST4Gk4noQDrPk8Ddn9iZqB/qhlaU/xkwAX7cIZdufCrg5tGPaHJw4esiZp3t6VB2mu5wWOloUozyGrAgzRpUVJdgdQ62xMpqHp0PJXn7LL6lIVP6xGcVZLzGv7UoM1M+SCtNREd9y+4My3/jj9rgCxCpHvc9NdCbmqNbGYldSuBZb2P5V5AazJWhJF; 3:daUBpvyntoQXMSx/j01TXicn96ofqGivibgWTSZ64YEnBmVSyfFdoixaeWw6y3E8lgnppBaGU8mwb4nhILGssejkdrkqk2+rnqFsiebalzHaCAOmyAh6/bKgkLS1rnre X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1716; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 25:vMCNuK5OQ3goh3WsWGrSusJXW4Ro6kBIPRWz/e0uQWXT2er/MxGxr9sxOcS+8Z6RfqFDyL/C0vVKyPEjWydmm0xz4QsNAz5DhzJ2GHyqiGenaTOeWC+fpo3B8/9tScG4W7GNKqPAC5xpWGW+kWbdrqkhHZUG2ZGZi2q4ZUPT5B7gNt6APPjmOcxfWywUK0+lrqnpvjzdllIUHmeeVaaaVV2pizYxZFKXu1xkW/AIqFBS72ENheld1IKJdmyPjTElQnYQn20gf5bu8y7nE1pSoJoTSIL+AO8hiW2DRoGbt6iIml366kKe8QW1BkPdeZQ3O5POg8QcwhhRojPk8bmAcqRMbbm+islPbf1LqEmkLm6Oc32Jsg5BCMkQDBqhQVfyFBu1BBo+jSk220l2g1iPsRwtfErfgRmxVpEay04XBuynrhkY9ZHSMB0LM7aMgtxLLmEOuGupI16QKDjeNaeo8aeYXjNqDCQOKqzlffSJFbtFuaj2Xa/x7M/OT472oNR9Kf6/8BJGlTA8Z0rHDgdhNJho6mxCdqfsLuXJCmxfb4DDPZY/+XB8XUFlUXbzSRf8rpXHFZmoOArmoVV8eZUv6vmGhatGysoXULz+6S0BsR+vXqv/OkWD65aAZDi3CkSgFS6r2T6Fkcsdbm8JV3INId7QTD/8Q2u2M0TRDMFkMGpZb4Wxnvzh4Dol/luNBtai1f4I56w2QAM7TjLJsyX+T9Vc1e7PI2DsBgVFc1/QjVNpbCeR/ZeSfExnjK1NHkdQ X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 31:iRxyhb8sCek6Maj4PnLqw3U5rtxX2OomISSVIW0nqXA5KncywQjCw4Uf/lHehUMNJ4JepfjtuEZrEzon7tCzIAq3R5HW9vIKHdvKt7s8xlSSZlSpFJ6shchXWODfSRc4YG2VK4etWNkAe8+YieoC2G7qaiuWeh1QAb6smB20J3CeEPC8rJu/+NhtOZW6wuLRpQypurVdRdus7hHYGJ3OSg==; 20:7NEQkWUIKg0+ZOz/POMuzu6EnYVH01fVdulAI7f7j2EuCjznW9DEwbn11qAQWhJsmFcyXBrzskajNXgM00uVfsm4d8BvY5XdkkjcMu/8DpdCu5rxOGKEkoxBoMo3BZpYkHzgF8QQkY1k4n4qLhTUIZNo0zihSd3ylnmAKkWVol16lpSECNM56BJ1HJ4EIuOTuXdXJCLD5JUmK95rGGkKLUY6XXr2NYAvDHro/Xim/rj7Mf8kDc0cDql8nFpy6Y9iw/bXRTeCGgcFGgc3FdUKZi/UldYpCMFzIGk6C6txbQ8S4yYsXVhuURxk33cb3nKcVJ7JPPTjCzYZaC9KaBongx3n8e6ER8vR1HRoh5YlKSvETmyuUoklFTy3X8z4KiI+muVCLloCZK7xIah838At6Dm+vWQrGuL7ddIsgoyF/X9D0Iote9rj3jaICSCT9eZKcq75TCmuLS1MPseYXoSGncvR9/Uc2TwNLPAJCvHHecHfCloR+iBaJ3VuTWKu8m2iu8nJluvZJXGhU/Whik3f4MZkQm129aFtrvy3Ige10KDrlK0l2osVuQ8fNus1Fk2y0mx5IEXRtDfk888BKUdVA0YR3smgA2WedMXc9eldcX8= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(278428928389397)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046); SRVR:BLUPR0701MB1716; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1716; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 4:j0Q/fjtDSBnEeAb9esktwaC/POKIKmg59jA/nI99zSZU405su8F/FMJ+SA0bfnY7T5oBk83Yd/NwzS28qmioh4ga+rkzShsiwDGBbIcn7LpFufqchVxCoNGXeVHbBtd4YrGOl5LdC+2GwWvZ+gqmJsSNgj93g4um4uXxQMIOkbK7vIDkuATAHsImz3qidCmQcErkR6aXTVa8JjlY+pgGJY2fJ7cchcXp5q5Qk8QsieQtyzaJLDDJoiG4Ea/DNd9Ztxr5jyEP5GyLVodXtowcf1WDheg7zF4qfBf8fO9sXnjqyOg5KFcY9vGas43cIVd+3wmUpfCwlOLzO2Rb6sO84MwiHFvv2yYeBorCvBn0ifmefI3eVfPxX41dtMqVmsSjwMWW8Artf1uMPjOX0Wlu+U2TePzMzGn2a0wE3TNKB1pyo2Usr7imeFb7hn9QhRhX X-Forefront-PRVS: 0016DEFF96 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6069001)(7916002)(24454002)(189002)(199003)(4326007)(50466002)(6116002)(93886004)(305945005)(1076002)(23726003)(92566002)(81166006)(7736002)(9686002)(7846002)(2906002)(81156014)(68736007)(3846002)(586003)(97756001)(4001350100001)(106356001)(19580395003)(66066001)(189998001)(54356999)(83506001)(47776003)(50986999)(76176999)(97736004)(46406003)(105586002)(101416001)(77096005)(110136002)(33656002)(61506002)(42186005)(19580405001)(2950100001)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1716; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1716; 23:uR8SAbdbFaDe4DSwgWRV0twcU5nALPYCLr+9RjH?= =?us-ascii?Q?g7Mjpe57brFjr1Bhenrtxw2jTrKUxI1XJeQDltxIWCWvK91U0crzoi9YQk9h?= =?us-ascii?Q?MPgBUqMNzfQn+bNPnufU6Toc1daBBVPmpkDxmWAXgAnADuxvmRUlWrZpAOS0?= =?us-ascii?Q?w+NRcXyBkBWxsK8azyzBmKvK9K15XaGKQJltjVCDc0TaSOTmMhmi5h3uSy7y?= =?us-ascii?Q?81KD3lokV7Z3c8OdWlDskA39WKQcZUiGnZX9M7R/wsgEZo6cpO8JTka3sqmk?= =?us-ascii?Q?rRA9yFzjYOL4E3TpRpoaZ9NFoNC+tg5bd6aL4YUI74tzUnV254ltMYZxqHkn?= =?us-ascii?Q?+jGw6k7YT/UtAATfPW/eAeBric7MKdK34oDuC+A8f23lWUN0+pqanBY9wljr?= =?us-ascii?Q?QXHXIzSdq4OnLRRuW+EQ0Cap6HA0WcCU6Kk37FWm+qK6LPCtaLZ4E/yifhbP?= =?us-ascii?Q?a7/1sCDQT/m6HANW7v+gL2PbtR1l9qqEi1RLs8BzmLKPUKl+MoxbgfbVIwsV?= =?us-ascii?Q?8vZUk4SbBcHDvPD9mVYrEAVPjBpqwHECAiy8MovGAgewdQiYCw9wJHUCSuwt?= =?us-ascii?Q?L+B2wKrjMQzL09gQwJqfwXom7H2vvlbz9vBQPDy5/NYEFOQaZI/HLcNgmp8H?= =?us-ascii?Q?vP4MZOFUhdk7S99J6ojmM2kUzSJG4RK/5N7l/MlfkxqhR1jxNfWEvgVjRi99?= =?us-ascii?Q?fXhy2IbUZhipnky1yWv49z/fjC4eotbN+5KYI1n07zTEgNhuKYC8dF4fWiJh?= =?us-ascii?Q?D1DYyFhHko969m34XpNNttsq5GF8IB4iVjMlTuvm/WGIf2r9t5yEU12HTfdI?= =?us-ascii?Q?3SBa+QwUDt1nrROEfxyJReB0PMGtfh0jENgQtIcWkDb3K1Gzz4NHArGeOflF?= =?us-ascii?Q?dL4s8ZGcd/rhpwRB3FyzvNP2acnURvhsgX59G1LJhR0QPlGBhTydvbPWkQWp?= =?us-ascii?Q?S0sfLD2Ua4d5wg1nkaaiSMv8rw1OXnXaR7F+z5ra+nbQ0Tyt/J//ta4GB6ak?= =?us-ascii?Q?c9tL294KxSzz1kL38wGCPZWQC5uHD+xlp/+/BPSgY3NbHdTIHpeMExih3VPH?= =?us-ascii?Q?A1r9YINvRDyqgxnUd2uZA8Jb3XKa+/vwQpn1r2R/9c/9uO5KBhRIus5R/oaI?= =?us-ascii?Q?Coblf03oLnY4K8+gHo/bKE98T4crI9I0JvPDYke/hs0WyfEy63sGHb/WQpRO?= =?us-ascii?Q?DJG22ZKQy03Qs0oc=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1716; 6:DMndeMJvHdpYgrWX/VK5cUw/E7YISd52nkFcQR293QlnILCm84EQRkfkL/eEsIu5jC2nZA7MvlI0W/zEYv9lfcMTFlWmcvIkJpq6sFfqv+J6yVYuNLapfG1XR3xhiwF3mVbF/28sILPdCXPOIhprctkWO4VK0KSHn5krqLiXfbxxIYCJB4QBmUmRCMBHgIUxxY+/0HCSyHMpJh/2+IRlxEYSb5KV/pMV3XKYaIuJglU9EgDmeInCmynY34K5ub9CHr9Nsb4+x3lR885B/xTsfS6FXMU4pPECE6dwPJ4cFt4=; 5:g1ixoH46kyqUeT9mS4niWhA17p4dOmKTJNwcYiYIlCr3/6U4IGtinTI8YBOYbb1iwcqz/sbWWZUlf3mp92rvHFJVVYdL8QxNkoyd9moEcyWqr7rs7yP8uvvuT4OxhOxXhA3xQtfhf3Eut0PRmOFALA==; 24:U/if0iB+1kpG4Q9yjcXb7c/ScL2f1G8Nl4J9GlWPYoQfxzkFqalOHk7bzK8S1EUk0ay++sxB7lT1ngtNSbeqQfRoj2ICZNULtiwLymVsQNU=; 7:a9V7MPIcGBpW1nMDhrvTKPZ1btZZfD7lMOrhAWvpB27YEQra8LaTapJKo2xsFyCZPlGKMYK9ljuncb8coFmEZd6AS1T4KSGascY96UI328A1/Mr16K3Q0779JCwdcpU36vtVeLUvNXD5YK4fBBC1wm0FVxzT9iEzwK4Ffz84U4SiL+2nzvYvgy94BJZKB+qJV/CMHf+SyG+uwXpgpoFKtpz4+u0lBNY1PKhli4SFdUEPeLRC96rPV7XTLPDEMgpR SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2016 17:11:02.2006 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1716 Subject: Re: [dpdk-dev] [PATCH v2] doc: announce ABI change for rte_eth_dev structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jul 2016 17:11:06 -0000 On Wed, Jul 27, 2016 at 01:59:01AM -0700, Thomas Monjalon wrote: > > > Signed-off-by: Tomasz Kulasek > > > --- > > > +* In 16.11 ABI changes are plained: the ``rte_eth_dev`` structure will be > > > + extended with new function pointer ``tx_pkt_prep`` allowing verification > > > + and processing of packet burst to meet HW specific requirements before > > > + transmit. Also new fields will be added to the ``rte_eth_desc_lim`` structure: > > > + ``nb_seg_max`` and ``nb_mtu_seg_max`` provideing information about number of > > > + segments limit to be transmitted by device for TSO/non-TSO packets. > > > > Acked-by: Konstantin Ananyev > > I think I understand you want to split the TX processing: > 1/ modify/write in mbufs > 2/ write in HW > and let application decide: > - where the TX prep is done (which core) In what basics applications knows when and where to call tx_pkt_prep in fast path. if all the time it needs to call before tx_burst then the PMD won't have/don't need this callback waste cycles in fast path.Is this the expected behavior ? Anything think it as compile time to make other PMDs wont suffer because of this change. > - what to do if the TX prep fail > So adding some processing in this first part becomes "not too expensive" or > "manageable" from the application point of view. > > If I well understand the intent, > > Acked-by: Thomas Monjalon > (except typos ;)