* [dpdk-dev] [PATCH] doc: announce ivshmem support removal @ 2016-07-20 16:35 Thomas Monjalon 2016-07-22 0:36 ` Hiroshi Shimamoto ` (3 more replies) 0 siblings, 4 replies; 9+ messages in thread From: Thomas Monjalon @ 2016-07-20 16:35 UTC (permalink / raw) To: anatoly.burakov; +Cc: dev There was a prior call with an explanation of what needs to be done: http://dpdk.org/ml/archives/dev/2016-June/040844.html - Qemu patch upstreamed - IVSHMEM PCI device managed by a PCI driver - No DPDK objects (ring/mempool) allocated by EAL As nobody seems interested, it is time to remove this code which makes EAL improvements harder. Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com> --- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 9cadf6a..1ef8460 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -42,6 +42,9 @@ Deprecation Notices will be removed in 16.11. It is replaced by rte_mempool_generic_get/put functions. +* The ``rte_ivshmem`` feature (including library and EAL code) will be removed + in 16.11 because it has some design issues which are not planned to be fixed. + * The ethtool support will be removed from KNI in 16.11. It is implemented only for igb and ixgbe. It is really hard to maintain because it requires some out-of-tree kernel -- 2.7.0 ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce ivshmem support removal 2016-07-20 16:35 [dpdk-dev] [PATCH] doc: announce ivshmem support removal Thomas Monjalon @ 2016-07-22 0:36 ` Hiroshi Shimamoto 2016-07-22 7:52 ` Thomas Monjalon 2016-07-27 8:38 ` David Marchand ` (2 subsequent siblings) 3 siblings, 1 reply; 9+ messages in thread From: Hiroshi Shimamoto @ 2016-07-22 0:36 UTC (permalink / raw) To: Thomas Monjalon, anatoly.burakov; +Cc: dev Hi, > Subject: [dpdk-dev] [PATCH] doc: announce ivshmem support removal > > There was a prior call with an explanation of what needs to be done: > http://dpdk.org/ml/archives/dev/2016-June/040844.html > - Qemu patch upstreamed > - IVSHMEM PCI device managed by a PCI driver > - No DPDK objects (ring/mempool) allocated by EAL > > As nobody seems interested, it is time to remove this code which > makes EAL improvements harder. I'd like to confirm about the issue. I know there are real users who rely on ivshmem mechanism. e.g. spp user. Unfortunately they don't prefer to expose their opinion to the community. Furthermore they may not have noticed this situation. Anyway, it is the issue that the current ivshmem implementation breaks EAL framework and is much complicated, right? IIUC, for DPDK, ivshmem support module should be separated from a middle of EAL code and make it as a PCI driver. That means the current rte_ivshmem removal should happen. To keep the functionality to share DPDK objects between host and guest in shared memory like ivshmem, it should be implemented cleanly. Is my understanding correct? thanks, Hiroshi > > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com> > --- > doc/guides/rel_notes/deprecation.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index 9cadf6a..1ef8460 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -42,6 +42,9 @@ Deprecation Notices > will be removed in 16.11. > It is replaced by rte_mempool_generic_get/put functions. > > +* The ``rte_ivshmem`` feature (including library and EAL code) will be removed > + in 16.11 because it has some design issues which are not planned to be fixed. > + > * The ethtool support will be removed from KNI in 16.11. > It is implemented only for igb and ixgbe. > It is really hard to maintain because it requires some out-of-tree kernel > -- > 2.7.0 ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce ivshmem support removal 2016-07-22 0:36 ` Hiroshi Shimamoto @ 2016-07-22 7:52 ` Thomas Monjalon 0 siblings, 0 replies; 9+ messages in thread From: Thomas Monjalon @ 2016-07-22 7:52 UTC (permalink / raw) To: Hiroshi Shimamoto; +Cc: anatoly.burakov, dev 2016-07-22 00:36, Hiroshi Shimamoto: > Hi, > > > Subject: [dpdk-dev] [PATCH] doc: announce ivshmem support removal > > > > There was a prior call with an explanation of what needs to be done: > > http://dpdk.org/ml/archives/dev/2016-June/040844.html > > - Qemu patch upstreamed > > - IVSHMEM PCI device managed by a PCI driver > > - No DPDK objects (ring/mempool) allocated by EAL > > > > As nobody seems interested, it is time to remove this code which > > makes EAL improvements harder. > > I'd like to confirm about the issue. > I know there are real users who rely on ivshmem mechanism. e.g. spp user. > Unfortunately they don't prefer to expose their opinion to the community. > Furthermore they may not have noticed this situation. These secret users can use the version 16.07. > Anyway, it is the issue that the current ivshmem implementation breaks > EAL framework and is much complicated, right? > IIUC, for DPDK, ivshmem support module should be separated from a middle of > EAL code and make it as a PCI driver. That means the current rte_ivshmem > removal should happen. To keep the functionality to share DPDK objects > between host and guest in shared memory like ivshmem, it should be > implemented cleanly. > Is my understanding correct? Yes You just forgot the need for a patch on Qemu. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce ivshmem support removal 2016-07-20 16:35 [dpdk-dev] [PATCH] doc: announce ivshmem support removal Thomas Monjalon 2016-07-22 0:36 ` Hiroshi Shimamoto @ 2016-07-27 8:38 ` David Marchand 2016-07-28 18:09 ` Thomas Monjalon 2016-07-27 16:12 ` [dpdk-dev] " Maxime Coquelin 2016-07-27 19:08 ` Jan Viktorin 3 siblings, 1 reply; 9+ messages in thread From: David Marchand @ 2016-07-27 8:38 UTC (permalink / raw) To: Thomas Monjalon; +Cc: Burakov, Anatoly, dev On Wed, Jul 20, 2016 at 6:35 PM, Thomas Monjalon <thomas.monjalon@6wind.com> wrote: > There was a prior call with an explanation of what needs to be done: > http://dpdk.org/ml/archives/dev/2016-June/040844.html > - Qemu patch upstreamed > - IVSHMEM PCI device managed by a PCI driver > - No DPDK objects (ring/mempool) allocated by EAL > > As nobody seems interested, it is time to remove this code which > makes EAL improvements harder. > > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com> Acked-by: David Marchand <david.marchand@6wind.com> -- David Marchand ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce ivshmem support removal 2016-07-27 8:38 ` David Marchand @ 2016-07-28 18:09 ` Thomas Monjalon 0 siblings, 0 replies; 9+ messages in thread From: Thomas Monjalon @ 2016-07-28 18:09 UTC (permalink / raw) To: dev; +Cc: David Marchand, Burakov, Anatoly > > There was a prior call with an explanation of what needs to be done: > > http://dpdk.org/ml/archives/dev/2016-June/040844.html > > - Qemu patch upstreamed > > - IVSHMEM PCI device managed by a PCI driver > > - No DPDK objects (ring/mempool) allocated by EAL > > > > As nobody seems interested, it is time to remove this code which > > makes EAL improvements harder. > > > > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com> > > Acked-by: David Marchand <david.marchand@6wind.com> Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com> Acked-by: Jan Viktorin <viktorin@rehivetech.com> Acked-by: Christian Ehrhardt <christian.ehrhardt@canonical.com> Applied ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] doc: announce ivshmem support removal 2016-07-20 16:35 [dpdk-dev] [PATCH] doc: announce ivshmem support removal Thomas Monjalon 2016-07-22 0:36 ` Hiroshi Shimamoto 2016-07-27 8:38 ` David Marchand @ 2016-07-27 16:12 ` Maxime Coquelin 2016-07-27 19:08 ` Jan Viktorin 3 siblings, 0 replies; 9+ messages in thread From: Maxime Coquelin @ 2016-07-27 16:12 UTC (permalink / raw) To: Thomas Monjalon, anatoly.burakov; +Cc: dev On 07/20/2016 06:35 PM, Thomas Monjalon wrote: > There was a prior call with an explanation of what needs to be done: > http://dpdk.org/ml/archives/dev/2016-June/040844.html > - Qemu patch upstreamed > - IVSHMEM PCI device managed by a PCI driver > - No DPDK objects (ring/mempool) allocated by EAL > > As nobody seems interested, it is time to remove this code which > makes EAL improvements harder. > > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com> > Acked-by: David Marchand <david.marchand@6wind.com> > > --- > doc/guides/rel_notes/deprecation.rst | 3 +++ > 1 file changed, 3 insertions(+) Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com> Thanks! Maxime ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] doc: announce ivshmem support removal 2016-07-20 16:35 [dpdk-dev] [PATCH] doc: announce ivshmem support removal Thomas Monjalon ` (2 preceding siblings ...) 2016-07-27 16:12 ` [dpdk-dev] " Maxime Coquelin @ 2016-07-27 19:08 ` Jan Viktorin 2016-07-28 9:20 ` Christian Ehrhardt 3 siblings, 1 reply; 9+ messages in thread From: Jan Viktorin @ 2016-07-27 19:08 UTC (permalink / raw) To: Thomas Monjalon; +Cc: anatoly.burakov, dev On Wed, 20 Jul 2016 18:35:46 +0200 Thomas Monjalon <thomas.monjalon@6wind.com> wrote: > There was a prior call with an explanation of what needs to be done: > http://dpdk.org/ml/archives/dev/2016-June/040844.html > - Qemu patch upstreamed > - IVSHMEM PCI device managed by a PCI driver > - No DPDK objects (ring/mempool) allocated by EAL > > As nobody seems interested, it is time to remove this code which > makes EAL improvements harder. > > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com> > Acked-by: David Marchand <david.marchand@6wind.com> > Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com> Acked-by: Jan Viktorin <viktorin@rehivetech.com ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] doc: announce ivshmem support removal 2016-07-27 19:08 ` Jan Viktorin @ 2016-07-28 9:20 ` Christian Ehrhardt 2016-07-28 15:23 ` Mauricio Vasquez 0 siblings, 1 reply; 9+ messages in thread From: Christian Ehrhardt @ 2016-07-28 9:20 UTC (permalink / raw) To: Jan Viktorin; +Cc: Thomas Monjalon, anatoly.burakov, dev Hi Thomas, just my two cents as Ubuntu DPDK maintainer (and part of the Debian Team that does the same). (It seems I can reuse that line for all posts about the deprecation notices :-) ) While IVSHMEM was enabled (as it was the default) I never heard of any users of what we provided so far. But that is expected considering that not all qemu bits are landed either. Since it will follow the process of "deprecation notice -> grace period -> ABI bump" on removal, I think packaging and consuming applications should be fine. I'd agree to Hiroshi that, if really needed a clean re-implementation more properly separated from EAL likely is the best way to go. I think it is a good change to drop rather complex code in favor of stabilizing the main paths: Acked-by: Christian Ehrhardt <christian.ehrhardt@canonical.com> Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Wed, Jul 27, 2016 at 9:08 PM, Jan Viktorin <viktorin@rehivetech.com> wrote: > On Wed, 20 Jul 2016 18:35:46 +0200 > Thomas Monjalon <thomas.monjalon@6wind.com> wrote: > > > There was a prior call with an explanation of what needs to be done: > > http://dpdk.org/ml/archives/dev/2016-June/040844.html > > - Qemu patch upstreamed > > - IVSHMEM PCI device managed by a PCI driver > > - No DPDK objects (ring/mempool) allocated by EAL > > > > As nobody seems interested, it is time to remove this code which > > makes EAL improvements harder. > > > > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com> > > Acked-by: David Marchand <david.marchand@6wind.com> > > Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com> > > Acked-by: Jan Viktorin <viktorin@rehivetech.com > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] doc: announce ivshmem support removal 2016-07-28 9:20 ` Christian Ehrhardt @ 2016-07-28 15:23 ` Mauricio Vasquez 0 siblings, 0 replies; 9+ messages in thread From: Mauricio Vasquez @ 2016-07-28 15:23 UTC (permalink / raw) To: Christian Ehrhardt, Jan Viktorin; +Cc: Thomas Monjalon, anatoly.burakov, dev Hello All, Here in Politecnico di Torino we use the ivshmem technology from a research point of view. Our research efforts focus in optimizing the inter-Virtual Network Function communication, currently we have implemented two versions of our prototype, they are described in [1] and [2]. Unfortunately, we do not have the human resources to implement the improvements that are necessary for ivshmem in DPDK, however we could provide some feedback and testing for possible patches. Best Regards, Mauricio Vasquez. [1] https://www.researchgate.net/publication/305699120_Transparent_Optimization_of_Inter-Virtual_Network_Function_Communication_in_Open_vSwitch [2] https://www.researchgate.net/publication/305699122_A_Transparent_Highway_for_inter-Virtual_Network_Function_Communication_with_Open_vSwitch On 07/28/2016 11:20 AM, Christian Ehrhardt wrote: > Hi Thomas, > just my two cents as Ubuntu DPDK maintainer (and part of the Debian Team > that does the same). > (It seems I can reuse that line for all posts about the deprecation notices > :-) ) > > While IVSHMEM was enabled (as it was the default) I never heard of any > users of what we provided so far. > But that is expected considering that not all qemu bits are landed either. > Since it will follow the process of "deprecation notice -> grace period -> > ABI bump" on removal, I think packaging and consuming applications should > be fine. > > I'd agree to Hiroshi that, if really needed a clean re-implementation more > properly separated from EAL likely is the best way to go. > > I think it is a good change to drop rather complex code in favor of > stabilizing the main paths: > Acked-by: Christian Ehrhardt <christian.ehrhardt@canonical.com> > > > Christian Ehrhardt > Software Engineer, Ubuntu Server > Canonical Ltd > > On Wed, Jul 27, 2016 at 9:08 PM, Jan Viktorin <viktorin@rehivetech.com> > wrote: > >> On Wed, 20 Jul 2016 18:35:46 +0200 >> Thomas Monjalon <thomas.monjalon@6wind.com> wrote: >> >>> There was a prior call with an explanation of what needs to be done: >>> http://dpdk.org/ml/archives/dev/2016-June/040844.html >>> - Qemu patch upstreamed >>> - IVSHMEM PCI device managed by a PCI driver >>> - No DPDK objects (ring/mempool) allocated by EAL >>> >>> As nobody seems interested, it is time to remove this code which >>> makes EAL improvements harder. >>> >>> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com> >>> Acked-by: David Marchand <david.marchand@6wind.com> >>> Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com> >> Acked-by: Jan Viktorin <viktorin@rehivetech.com >> ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-07-28 18:09 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-07-20 16:35 [dpdk-dev] [PATCH] doc: announce ivshmem support removal Thomas Monjalon 2016-07-22 0:36 ` Hiroshi Shimamoto 2016-07-22 7:52 ` Thomas Monjalon 2016-07-27 8:38 ` David Marchand 2016-07-28 18:09 ` Thomas Monjalon 2016-07-27 16:12 ` [dpdk-dev] " Maxime Coquelin 2016-07-27 19:08 ` Jan Viktorin 2016-07-28 9:20 ` Christian Ehrhardt 2016-07-28 15:23 ` Mauricio Vasquez
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).