From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f182.google.com (mail-pf0-f182.google.com [209.85.192.182]) by dpdk.org (Postfix) with ESMTP id 4B85458D6 for ; Wed, 24 Aug 2016 21:17:12 +0200 (CEST) Received: by mail-pf0-f182.google.com with SMTP id y134so9601831pfg.0 for ; Wed, 24 Aug 2016 12:17:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZUVK5PRQ4QS349BoyjE6xWw0TY/IkGuCGr0mNlBVaLo=; b=wA2uV1PiQrZHfFhhWBRftnTh8UJVoRj6yWUozP0f7ncBoNxEh56vFH2sDsE9kLAElU VBNmK1dQrGgBuwxwS46IVb77PaWafyMhXeHC/ROXe6V4WVf9w5RNktYuHdyxw9VJaRqU sGNKBeYi6UQm/lRn+gqcpf8E1J9Sf2vdi1ajcHc4/POEYdfOc88+cmB/tF7secmr4I9w giXLseC8wKecMHWvyQZv4TVtbR6PDjOTSDrqcxGouF82PoCrqjLMqQTD7TU3DV/pXBiG bR70LC1tvJYbUsjtgpT48jHfP0CH4OGl+9KkrVBsmPjdJCbGCOtFd7mS/zMcg2k6g1jl tutQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZUVK5PRQ4QS349BoyjE6xWw0TY/IkGuCGr0mNlBVaLo=; b=J3FVHOzCZLRHpQTptKm2ZeQ7ssXuuWmuR1T7A4Zsqb5QWUBFX3NGdDNpZHiw9K848i Ki+EeRAoSVdPFD9/TITJ9j4cUdewMWGNxmVod4Ch0oPg3ic6NT3QzJeeCslrwa8sR3nq zjw8LUEimnGje09g1Hychx8TAMEjzhbbQX/44NCAcCpAdXrwkn9jGGKlh9qFEssIFF9p 2eFOEol7rfZ8WE++2qoohywcqlB24WYcv0cTEN+xYMxxfpUVoOxNANBs/wjWZKZxt5sy 3dExfxEGMuaWLo9CJNPzOqHeDAn8dWcAlARhh/2SOYkTlOwIjXcAZO63eb9twePDwbPG 5cbw== X-Gm-Message-State: AE9vXwNEKg9bc8NgNpg6X0j4g9tj2XpXpq4iiZYxKb9lIiHvYw2VxH9WlVTU3+LXCBGcVQ== X-Received: by 10.98.200.29 with SMTP id z29mr8581023pff.143.1472066231583; Wed, 24 Aug 2016 12:17:11 -0700 (PDT) Received: from xeon-e3 (static-50-53-69-251.bvtn.or.frontiernet.net. [50.53.69.251]) by smtp.gmail.com with ESMTPSA id r10sm15493093pfk.84.2016.08.24.12.17.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Aug 2016 12:17:11 -0700 (PDT) Date: Wed, 24 Aug 2016 12:17:24 -0700 From: Stephen Hemminger To: Yong Wang Cc: , , , Message-ID: <20160824121724.6806219f@xeon-e3> In-Reply-To: <1471997140-46527-1-git-send-email-yongwang@vmware.com> References: <1471049909-18117-5-git-send-email-yongwang@vmware.com> <1471997140-46527-1-git-send-email-yongwang@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 0/6] various vmxnet3 fixes and enhancement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Aug 2016 19:17:12 -0000 On Tue, 23 Aug 2016 17:05:34 -0700 Yong Wang wrote: > v2: > * updated vmxnet3 feature doc. > * updated vmxnet3 guide to remove stale information. > > v1: This patchset includes a few bug fixes and some enhancement. > > * Fixed a bug with dev_configure memzone size; > * Enhanced error checks during device start. > * the driver will now report error if the rx queue number is > not a power of two, instead of waiting for the activation > to fail. > * Instead of returning -1 (which is interpreted as -EPERM) on > device activation failure, -EINVAL is returned now. > * Enabled LRO if requested. > > Yong Wang (6): > net/vmxnet3: improve error checks and return values > net/vmxnet3: coding style changes > net/vmxnet3: reallocate shared memzone on re-config > net/vmxnet3: update feature doc > net/vmxnet3: update nic doc > net/vmxnet3: enable lro > > doc/guides/nics/features/vmxnet3.ini | 22 ++++++ > doc/guides/nics/vmxnet3.rst | 12 +--- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 125 +++++++++++++++++++++-------------- > drivers/net/vmxnet3/vmxnet3_ethdev.h | 32 +++++---- > drivers/net/vmxnet3/vmxnet3_ring.h | 22 +++--- > drivers/net/vmxnet3/vmxnet3_rxtx.c | 59 +++++++++-------- > 6 files changed, 158 insertions(+), 114 deletions(-) > These all look good to me. Acked-by: Stephen Hemminger