From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 16177592F for ; Thu, 25 Aug 2016 04:53:18 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP; 24 Aug 2016 19:53:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,573,1464678000"; d="scan'208";a="1046847437" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga002.fm.intel.com with ESMTP; 24 Aug 2016 19:53:16 -0700 Date: Thu, 25 Aug 2016 11:03:19 +0800 From: Yuanhan Liu To: Maxime Coquelin Cc: dev@dpdk.org Message-ID: <20160825030319.GV30752@yliu-dev.sh.intel.com> References: <1471510123-4984-1-git-send-email-yuanhan.liu@linux.intel.com> <1471510123-4984-8-git-send-email-yuanhan.liu@linux.intel.com> <33936312-b630-1a4e-e478-b028dc264962@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <33936312-b630-1a4e-e478-b028dc264962@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 7/7] vhost: simplify features set/get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Aug 2016 02:53:19 -0000 On Wed, Aug 24, 2016 at 10:11:57AM +0200, Maxime Coquelin wrote: > > > On 08/18/2016 10:48 AM, Yuanhan Liu wrote: > >No need to use a pointer to store/retrieve features. > > > >Signed-off-by: Yuanhan Liu > >--- > > lib/librte_vhost/vhost_user.c | 20 ++++++++------------ > > 1 file changed, 8 insertions(+), 12 deletions(-) > > > >diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c > >index ef4a0c1..eee99e9 100644 > >--- a/lib/librte_vhost/vhost_user.c > >+++ b/lib/librte_vhost/vhost_user.c > >@@ -155,23 +155,22 @@ vhost_user_reset_owner(struct virtio_net *dev) > > /* > > * The features that we support are requested. > > */ > >-static int > >-vhost_user_get_features(uint64_t *pu) > >+static uint64_t > >+vhost_user_get_features(void) > > { > >- *pu = VHOST_FEATURES; > >- return 0; > >+ return VHOST_FEATURES; > > } > > This is not the topic of this series, but I wonder if it > could make sense to be able to override supported features > at device init time. Not quite sure I understood it correctly: is rte_vhost_feature_disable() the answer you are looking for? > It may not match with the orignal purpose of supported features, > but could be useful at least for testing without recompilation. > > For this patch: > Reviewed-by: Maxime Coquelin Again, appreicate your time on review! --yliu