From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <sodey@sonusnet.com>
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
(mail-sn1nam02on0083.outbound.protection.outlook.com [104.47.36.83])
by dpdk.org (Postfix) with ESMTP id E049258C8
for <dev@dpdk.org>; Fri, 26 Aug 2016 06:00:23 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=SonusNetworks.onmicrosoft.com; s=selector1-sonusnet-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
bh=/8aaKQ0BL0EL788kRACuUXC54K+Ez1KWdqS0bxY2Mt8=;
b=AnsPsMnVaGwM9yLaAuE6muR3kMsVnzs2w/IIfyaNElEGgTfydPAz8S+z+LvUBUBHH0iAC2xm3r7ajpMZkZ5kbfqi9BlaSnIPKIO/TR/4YKWqRjQGa8+okuJ5ITwkfxJP9i3P1Yn7itkio3pAIrXjOMQn8bKNi9pySrqIrtErCzk=
Authentication-Results: spf=none (sender IP is )
smtp.mailfrom=sodey@sonusnet.com;
Received: from SODEY-LMA.sonusnet.com (73.114.35.9) by
CY4PR03MB2742.namprd03.prod.outlook.com (10.173.38.8) with Microsoft SMTP
Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id
15.1.599.9; Fri, 26 Aug 2016 04:00:12 +0000
From: souvikdey33 <sodey@sonusnet.com>
To: <nhorman@tuxdriver.com>, <dev@dpdk.org>
CC: souvikdey33 <sodey@sonusnet.com>
Date: Thu, 25 Aug 2016 23:59:56 -0400
Message-ID: <20160826035956.17580-1-sodey@sonusnet.com>
X-Mailer: git-send-email 2.9.3.windows.1
In-Reply-To: <20160825022546.96468-1-sodey@sonusnet.com>
References: <20160825022546.96468-1-sodey@sonusnet.com>
MIME-Version: 1.0
Content-Type: text/plain
X-Originating-IP: [73.114.35.9]
X-ClientProxiedBy: DM2PR0801CA0013.namprd08.prod.outlook.com (10.162.18.23) To
CY4PR03MB2742.namprd03.prod.outlook.com (10.173.38.8)
X-MS-Office365-Filtering-Correlation-Id: f0fc8b0e-ef63-455a-99f6-08d3cd657b46
X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2742;
2:1nbPRhBC6J9uMvYrKgQb6nRzJ4z+FY4b0ztO7VyvxX3XPH8rBHwuU7Di/RxO7HeTYRAuY1nb5bVGDvGW5/9pB6YqYXIs2r43/5smh3hJlnP3cqM4BBVpRswhJxKqiddK3/HMEkaC7JVgBA3oOUhV4IQ9R2Fy8vjhU3+xvXbDNG3k9rdQE9hEgfyo6wiB4NCv;
3:9cfW+p/9r4aVuzv5aA7PcmurFWm21LK7YMYLeNQJ6Zl5+YfG0bF8dwa721lejedcaZ83IGgu8Cs7qpb9rvJWIUVIutA0WcmHzoBJjXrJVj8FcevC8ZLCiXYh+cFalvkj
X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY4PR03MB2742;
X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2742;
25:7q2zA/7o/fRZcs9dqCr8gU9THH5ScFzPhmlGHjpRgt1rozXQmUDHep5qXs9R3aRujy37NrnIOOLjhsQJfSNq19QlQ+Pp2ubWxBfZshqDbHheyULibJN166vhM2UPO4VGLi3VscqAfyPRz8u6euNdcQVTP0vklJ31snxDH/H8UNHSPt1ApzaSwwNdwLT85mm5Lk6koJN8ngjlHNYmcf0LVtdA+MezFrjQ+He8ZGM5ej7AMnnS4gGOdaZg8WDMhC5M2/n0vpVTdHRPMxOO6vIwt+mCyYByKFKh78cwTmOq80Nj1MO9Jz1nBEMcEorkcHsieO3d+d22k8i/4CdF17FlsPASHhAaMcjLe0dI2n4YTKBN/Tv5Un2jJrLc1oLSJr3DDMPGc/+CkkNo+3uAGeZi7h9P4FINwAjzmLr+DPSZQG3HoJOPijO63ovS9UFedtNB86EYVALQ5S2H613+x6flSB01AxfmJN7KSQG7fYxtpoXRFSYkwooRwmtacxs6uHhY4zv5TG5+QgYDALlOFGPoDWl2iCrfANc4QtNp8Ot2vbexwbdksRz7qR3CUn0df1vxzY40aNneVWCwjrOkF3M8HdXAfeinIXkUHi2qX+FvNMmN6kfkswSDdpNTWZ0/3CelhsZfwx8uL1a17ZEM0pleBaosKDuuK5EadZD52aBFPGV+QZHqZfwuv2koStts3PMJ2jqeYsSOkhuHgmqpwBey/w==;
31:KZe1bCz20OtHrC70N+ctVrQ+vpTXGI3/QWFMdwGoEvl862WHw85B/Bqi9LGzccvwgs8ExH+zKx/erHQLIsytpwIB4oGFMwR3BP2TusRJm2/u8C/p0jFTGWrxyKYlaQrH+vDXqtObY7ypObHhJA3yw8O8FEvxIz7Lja6PS8g0QkSDaTiQ3mKD8vR6k/8e7pq08PgwarWmphnEk2pLkd83IXfpwobZsFlBTZCkP46WDig=
X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2742;
20:2nKBV5pv1J4Nc6cqLi7VQB3dFRIAzKH3jV8CCyz13yhs0Ee0f6mOHjCPNL3sWFRyMqTDGQVcbB3Nn52godZFmblwcreOrFHImhQKEm8qqTdAX2KljPas1bbnejRoltVMmb/LbPn1OAKLmhUcfKfKTDioT9sAS4rwb8QVLexa2em4MbjGhVq2tghXUe8HBmFXL9q+IWgBt5VERgQ1kDwwHBbkw+4UvCEBNT8Y4f8yDLZBlvAbe22z2ESV9ATElQtHKXrvGVNen6URKbSyKbHUWeTLUPUkZGhcLzuf2qQ7gY1x4D062L96WMq+EwvwR8cErcJ2024uedX4ibJgWBORrIqXyfZ3ipLXtkslY3xU2DO4ptHwlpuYJ9iKICV17VE4QNekRSEno5nJozq93om6NSbtLfmxuUfszjK1ksJwTqwkmsR5FJmQfuZoGKv8GPIYwqDMBCWlDmc4MdNK19bjSbwg4/qv7K8RAuwUaFPXnWgEfzhlDQ+HcKhl/YrtK2bi;
4:ATlbBILWrGRucPR44N1WjDtte3UGfH1OnI8bPvD2RH3T/p4lyPjLFKXdEwKTIWNXQe5QYNFyFwexTXBxEjEZ8cx/9tAUQqQA24y+f1pOJBAxrnd8yfa4W4lG92gFvKpPkXjM2/4ZcuaR1J1NwoJrAcEuDr4ohD4f5KRhSb6eYUSCX9977aaXZL8t5l4ooE43WbdSlkT91K+DF6AXkuF8tpEddfX64f6pE73HSpreXwJh95gMS5KXndv2VDMKuW0NfJKOdx0hlBeMIh4zqe0fOsIKSoxslkHQxi3MCpDL2jPy8ug9STYK5fiI9GPncdjFCh/iOr5HR7uSo2Ywsmw+XVol8T/xBMn5ynNCbE5GdjFoqgU2/NHiMC2sKdYk/9ifaA4qXdOlNF912sEs8AM9Fw==
X-Microsoft-Antispam-PRVS: <CY4PR03MB27427124A5BB1349B2606EAADAEC0@CY4PR03MB2742.namprd03.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:;
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);
SRVR:CY4PR03MB2742; BCL:0; PCL:0; RULEID:; SRVR:CY4PR03MB2742;
X-Forefront-PRVS: 00462943DE
X-Forefront-Antispam-Report: SFV:NSPM;
SFS:(10009020)(4630300001)(6009001)(7916002)(189002)(199003)(7736002)(305945005)(42186005)(7846002)(8676002)(2950100001)(36756003)(1076002)(81166006)(81156014)(66066001)(47776003)(50226002)(2906002)(19580405001)(19580395003)(575784001)(86362001)(105586002)(4326007)(86152002)(48376002)(50466002)(53416004)(97736004)(4001430100002)(229853001)(189998001)(107886002)(92566002)(5001770100001)(5003940100001)(50986999)(76176999)(33646002)(101416001)(106356001)(77096005)(6116002)(586003)(3846002)(68736007)(69596002)(5660300001)(43062003);
DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR03MB2742; H:SODEY-LMA.sonusnet.com; FPR:;
SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en;
Received-SPF: None (protection.outlook.com: sonusnet.com does not designate
permitted sender hosts)
X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR03MB2742;
23:gmTHGTphqiLOvdwsn9YDnRsKpna7CufLeOgi10ndM?=
=?us-ascii?Q?ia7fmjG8Cba+S+Py0SLWpG2GPu3ZdLY43U5UZDE4Zw+nCTu/uW8JUy2Am5vB?=
=?us-ascii?Q?E21HyNYd7JNBpoS/RlixDZYntNPa/NKMHmRUH/y9ukTEqc3xUZx2z0QeK25R?=
=?us-ascii?Q?/FoIOQaxqMeodhdMJam9gPWZW94pguU2gOjmDm8As6WNaROdz6tLeqCaZOr1?=
=?us-ascii?Q?aB/ipL5dp2SHbuuDNhQ7sn1jIsCyx+oiq/DvlQM5YU6M1sQEUh2RrpJtKNUG?=
=?us-ascii?Q?Euna6gjjguCrLYizm+ob7/wJ3BNiwKB1eiuNu5Nt1svnaexRqxFlCck8/NG2?=
=?us-ascii?Q?wleRTrs+nXzpa/hQL8vQltiQKjibXAfb880uHffetBpveWTXIXVslsiDXa57?=
=?us-ascii?Q?CHwmEn5kUq1dzUVEBwT8J/N1agFlt3st/DQoIvHCxrV7WaKZVTSSf1s6RWH0?=
=?us-ascii?Q?Golde1M4I83P9XU2fizo/lafz3XgakTkVtjqYK14lToA7W2HfL6wpfzwAWua?=
=?us-ascii?Q?ffiFwKjbx24/Ntpsm6EKyz+FHtBMsfG0qCk+GqUCJhs0o++rl93BTlRaR/s3?=
=?us-ascii?Q?x9BNFh+wor9eSMq9VCjzxBnTudPfrj5v1DOzAxkUEMWWEsYjCAFUqvy2Gkj6?=
=?us-ascii?Q?uQE+l21RMjW6blUuAlFQrsHyJWxPTXGE9wLroRHMOpkHXFWhGQw63nno+hQb?=
=?us-ascii?Q?qGcstM+CdTB6O0LRp5UIBCkJGPFb5o5DLH46cpF/iUJVGjAMN309W3aD/KEZ?=
=?us-ascii?Q?mPASPGHPyoFeaJHuUcTfn/aNIOvusAtpvXqOiHYRTkbPfJdwgNJtu1T5RKZ9?=
=?us-ascii?Q?b/4XHiPZJM0PuX7Xa8qkY4sYHcInWQPTfTZmAh6kqVN+uCeHg6BkPkuWWbtr?=
=?us-ascii?Q?zqsNh+IRfWzlbQNJ1X9nLaIN0a7rNgJLntYncK7beCxdfWK0WG48qEHUjoxc?=
=?us-ascii?Q?mUc+6ZVxoaUy85Z1dx2EWusBP697Kp0LD1RF1/tYRj6ues7XC5WAgjeG2tJf?=
=?us-ascii?Q?/+rdvNAtYpAPjHufRBwNBfItsXG4qismKizUQVpG9blHQzVTdmlOqBXUPjdL?=
=?us-ascii?Q?hw6SLzCRsBf1ygs/s0OD4L9VM9cG/Mhvnip7Oe5ulu+0M/SHvpTGGpmlyf3F?=
=?us-ascii?Q?/3mQsHH3VJyMwKI5REP7N3yKeJ///xFJnN8mh0dY44BnwTyHMk5BXOuqS6th?=
=?us-ascii?Q?9iOcLYknKwFoR/Gf2UCw2rMOvmvimQ/bs+YPLWEQYpk7Opl8K1eZzkwGw=3D?=
=?us-ascii?Q?=3D?=
X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2742;
6:F68g+R14Sxv+HuBI4QShb+MHPSpgfhS7RhEvbf/+C+z4Y9u4zg4TMkBdChMqZ0o6dpjavUSyoBOo0o7CSNsbOrR1jhii2QfJJjR9Lw3sgBXZQ56KlVvk/xcKJQFaI5i/14mtsTSV8EzYSNU+vCVNaGrAwxOYx4J/OgqbsPhGpEJvIuj8b/IV/KdFaOIDthpQeFcgk04D4ldU2qwlbMR3nKIVs/8gkeW8vvPqFWiGOvsLgyEU8eDNCYNRZKqSy/MMyvtorUtDgk5koCql7hmMVOz7v3JpIP+8AaAJyuZY1HI=;
5:xBtFmM5YuiSuoR4CpZaJ8Bxt+zCy8JpbvbqcCtSm+swFrzvt9HlTT9XZHXX7nalHC92YcQnkMTEPMWi3Vj/749uz4wEdP7HGO/uu7ZCGfuGMZVxJzrcFizWLB9POKW5BE5hghSN05wnJWmxckD0XEQ==;
24:tsBDcVX/trLb5V1LtCUrT0UTjwl1HSkUDHskuR4BAvbM860fYiR4P5paM58zo2TSZLDx7HNqse9oBCHqXge7v6vCbY5kvZ6I6iJWPVH7fgM=;
7:KvjYpHMAoQqJv8175MgLwRJMSHAeps1Fp/10WCMKCr282KlYf+kUtMQJKy3ePoSmu8HIN70MCHEcXbTUnaUPvArQpeJVSlSh1vSkw0GIpai9ilrBto7zaAGJmTNpD6/9isA1+cXWDfPhLQOpd966v9RfMGx+eqrfHV+jvpZ/bF6pOaWmGRqccm6QRRHpoCEJJQRXaFbcbloBI4gL/waHigbhYLdPYXWdaEscnxreMwkd3Tj6FR2nvVtg/x0J4RgU
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-OriginatorOrg: sonusnet.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2016 04:00:12.9484 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2742
Subject: [dpdk-dev] [PATCH v2] tools: fix issue with virtio interfaces
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Aug 2016 04:00:24 -0000
This change is required to have the interface name for virtio interfaces.
When we execute the status command the for virtio inerfaces we get
Sample output without the change:
0000:00:04.0 'Virtio network device' if= drv=virtio-pci unused=virtio_pci,igb_uio
Though for other drivers this works.
Sample output with the change:
0000:00:04.0 'Virtio network device' if=eth0 drv=virtio-pci unused=virtio_pci,igb_uio
souvikdey33 (1):
Signed-off-by: Souvik Dey <sodey@sonusnet.com>
Fixes: 3da038604009 ("Signed-off-by: Souvik Dey <sodey@sonusnet.com>")
tools/dpdk-devbind.py | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
--
>>From 3da0386040092fcd54ee333ceff8c427a36c6b45 Mon Sep 17 00:00:00 2001
From: souvikdey33 <sodey@sonusnet.com>
Date: Thu, 25 Aug 2016 23:31:28 -0400
Subject: [PATCH v2] Signed-off-by: Souvik Dey <sodey@sonusnet.com>
When we execute the status command the for virtio inerfaces the interface name is not shown.
Sample output without the change.
0000:00:04.0 'Virtio network device' if= drv=virtio-pci unused=virtio_pci,igb_uio
Though for other this works.
---
tools/dpdk-devbind.py | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/tools/dpdk-devbind.py b/tools/dpdk-devbind.py
index 9829e25..c0b46ee 100755
--- a/tools/dpdk-devbind.py
+++ b/tools/dpdk-devbind.py
@@ -36,7 +36,6 @@ import sys
import os
import getopt
import subprocess
-import commands
from os.path import exists, abspath, dirname, basename
@@ -224,14 +223,18 @@ def get_pci_device_details(dev_id):
device[name] = value
# check for a unix interface name
sys_path = "/sys/bus/pci/devices/%s/net/" % dev_id
- #The path for virtio devices are different. Get the correct path.
- virtio = "/sys/bus/pci/devices/%s/" % dev_id
- cmd = " ls %s | grep 'virt' " %virtio
- virtio = commands.getoutput(cmd)
- virtio_sys_path = "/sys/bus/pci/devices/%s/%s/net/" % (dev_id,virtio)
+ # the path for virtio devices are different, so get the correct path
+ virtio = "/sys/bus/pci/devices/%s/" % dev_id
+ ls = subprocess.Popen(['ls', virtio], stdout=subprocess.PIPE)
+ grep = subprocess.Popen('grep virt'.split(), stdin=ls.stdout,
+ stdout=subprocess.PIPE)
+ ls.stdout.close()
+ virtio = grep.communicate()[0].rstrip()
+ ls.wait()
+ virtio_sys_path = "/sys/bus/pci/devices/%s/%s/net/" % (dev_id, virtio)
if exists(sys_path):
device["Interface"] = ",".join(os.listdir(sys_path))
- elif exists(virt_path):
+ elif exists(virtio_sys_path):
device["Interface"] = ",".join(os.listdir(virtio_sys_path))
else:
device["Interface"] = ""
--
2.9.3.windows.1