From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f179.google.com (mail-pf0-f179.google.com [209.85.192.179]) by dpdk.org (Postfix) with ESMTP id EA2712C55 for ; Fri, 26 Aug 2016 19:38:42 +0200 (CEST) Received: by mail-pf0-f179.google.com with SMTP id y134so30605458pfg.0 for ; Fri, 26 Aug 2016 10:38:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MlYroXLQWwXmfShZPQqr+iK7xmaELGGl8znaF8kk250=; b=yq9tOOB/rVZM7d24bjr63G4eSW0+6YxdZS39omq40T8uJnRL/t0blA/b5jKch8DJop FgsOfYPJ7bSZ36caa1l2gfjZQqQq1ZmlfbUg4Wg+sP+CCYB4htInyCVFma5Qfp+oLNVP +9Lf0mPOk2kfbaBzIW3jma7ENRFbEX56WzfYbAGnXaTHRHTmW0WhZaA4+IuWG4Q2VguY BPJYla7SZ1KWTBAdUN8rsTdbP9jw4khw90NUAJEWuAratsdPwo5uT4qARh8OzthMRDAp fvzcFv+QKxqlezRqWDickCHfXiRwwmkY7BZXIFdIirSkVbng3IYZWyegvyBg9yfAfg0Q yjUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MlYroXLQWwXmfShZPQqr+iK7xmaELGGl8znaF8kk250=; b=Cy5whtmLXQpsCL6Y7E9msVQzwjBP1DB8j9okCKLzEGeCewHDCsizsurHXVBEO9hd8e 0K46H9uYA6qO87wlhZhmSAlN+eIECf4ArL9FnVgsihaTX9Z1XYxVfc/Ea7eTSbMRCCbm 6TUR5PWpquZeHfzmux2Q1PVQB7LQTfg8ak6jsRqb2CzR3rNX81FmjFuxkWSUB/2kULQN 9hGGqvQYo0qwbMgJF3Zx9i0+kXH90Cv/0IF5dMhlxO4sq0ryH1cNppZFdF/fMWib+fQw 5j+q7tme/SiaLclhNeMmD0/0Bcdteu562wMENXeSFrLtSyuOQUHkN38t1+bJpYWz/kKs c8NA== X-Gm-Message-State: AE9vXwOAjWgEE7eAfwtTOhO4Yi6CRIHG40aAr+Ls/qpa7Srdv4iQI0aO8cQMDgC+lFW3YA== X-Received: by 10.98.89.23 with SMTP id n23mr8098996pfb.34.1472233122256; Fri, 26 Aug 2016 10:38:42 -0700 (PDT) Received: from xeon-e3 (static-50-53-69-251.bvtn.or.frontiernet.net. [50.53.69.251]) by smtp.gmail.com with ESMTPSA id vz9sm14110966pab.20.2016.08.26.10.38.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Aug 2016 10:38:42 -0700 (PDT) Date: Fri, 26 Aug 2016 10:38:55 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: dev@dpdk.org Message-ID: <20160826103855.1b15f716@xeon-e3> In-Reply-To: <1472210279-8286-1-git-send-email-ferruh.yigit@intel.com> References: <1472210279-8286-1-git-send-email-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 00/22] pcap pmd improvements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Aug 2016 17:38:43 -0000 On Fri, 26 Aug 2016 12:17:37 +0100 Ferruh Yigit wrote: > No new feature added, code refactored. > > Ferruh Yigit (22): > net/pcap: convert config option to a macro > net/pcap: use macros for param string > net/pcap: reorganize private structs > net/pcap: add checks for max queue number > net/pcap: update function to reuse it > net/pcap: don't carry numa_node argument > net/pcap: don't carry kvlist argument > net/pcap: move comment to correct place > net/pcap: remove duplicated max queue number check > net/pcap: use single_iface variable instead of hardcoded > net/pcap: group stats related fields into a struct > net/pcap: make const array static > net/pcap: reorder header files > net/pcap: reorder functions > net/pcap: update how single iface handled > net/pcap: remove unnecessary check > net/pcap: remove redundant assignment > net/pcap: simplify function > net/pcap: fix missing Tx iface assignment > net/pcap: coding convention updates > net/pcap: remove rte prefix from static functions > net/pcap: fix checkpatch warnings > > drivers/net/pcap/rte_eth_pcap.c | 644 +++++++++++++++++++--------------------- > 1 file changed, 309 insertions(+), 335 deletions(-) > These all look like good ideas. Haven't tested this but they all are simple changes. Acked-by: Stephen Hemminger