From: Matthias Gatto <matthias.gatto@outscale.com>
To: dev@dpdk.org
Cc: Matthias Gatto <matthias.gatto@outscale.com>,
huawei.xie@intel.com, yuanhan.liu@linux.intel.com
Subject: [dpdk-dev] [PATCH] virtio: remove obsolete comment
Date: Fri, 2 Sep 2016 17:05:21 +0200 [thread overview]
Message-ID: <20160902150521.680-1-matthias.gatto@outscale.com> (raw)
As new_device and destroy_device use an int instead of a "struct virtio_net *",
The comment about setting VIRTIO_DEV_RUNNING doesn't make sense anymore, plus
If I've correctly understand the code, the drivers take care of
setting the flag before calling the callbacks, so I guess that this comment
is obsolet and I've remove it.
Signed-off-by: Matthias Gatto <matthias.gatto@outscale.com>
---
lib/librte_vhost/rte_virtio_net.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/lib/librte_vhost/rte_virtio_net.h b/lib/librte_vhost/rte_virtio_net.h
index 9caa622..a88aecd 100644
--- a/lib/librte_vhost/rte_virtio_net.h
+++ b/lib/librte_vhost/rte_virtio_net.h
@@ -59,10 +59,6 @@ enum {VIRTIO_RXQ, VIRTIO_TXQ, VIRTIO_QNUM};
/**
* Device and vring operations.
- *
- * Make sure to set VIRTIO_DEV_RUNNING to the device flags in new_device and
- * remove it in destroy_device.
- *
*/
struct virtio_net_device_ops {
int (*new_device)(int vid); /**< Add device. */
--
2.9.3
next reply other threads:[~2016-09-02 15:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 15:05 Matthias Gatto [this message]
2016-09-05 2:25 ` Yuanhan Liu
2016-09-05 9:18 ` Matthias Gatto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160902150521.680-1-matthias.gatto@outscale.com \
--to=matthias.gatto@outscale.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).