From: Jason Wang <jasowang@redhat.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: <dev@dpdk.org>, "Xie, Huawei" <huawei.xie@intel.com>,
<yuanhan.liu@linux.intel.com>, <mst@redhat.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/virtio: support modern device id
Date: Mon, 5 Sep 2016 00:36:46 -0600 [thread overview]
Message-ID: <46db62d6-4f24-3f86-c22e-089442e182d2@redhat.com> (raw)
Message-ID: <20160905063646.ET0QejoRxnBaTUjgIvxBQ6a1l4Uy1ORSRqOidzUdo8Y@z> (raw)
In-Reply-To: <2323448.KHrCRZ2JeF@xps13>
On 2016年09月02日 20:57, Thomas Monjalon wrote:
> 2016-09-02 14:36, Jason Wang:
>> Spec said "The PCI Device ID is calculated by adding 0x1040 to the
>> Virtio Device ID". So this patch makes pmd can recognize modern virtio
>> net id.
> Please could you describe what is a modern virtio-net?
I think it means the device that only support virtio 1.0.
>
>> #define VIRTIO_PCI_DEVICEID_MIN 0x1000
>> #define VIRTIO_PCI_DEVICEID_MAX 0x103F
>> +#define VIRTIO_PCI_MODERN_DEVICEID_NET 0x1041
> It doesn't match the sentence above: 1000 + 1040 = 2040
According to the spec (5.1.1), Virtio Device id (not pci device id) is 1.
>
> By the way, VIRTIO_PCI_DEVICEID_MAX is not used in the code.
>
Yes, we can remove this.
Thanks
next prev parent reply other threads:[~2016-09-08 3:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 6:36 Jason Wang
2016-09-02 6:37 ` [dpdk-dev] [PATCH 2/2] virtio: support IOMMU platform Jason Wang
2016-09-02 13:04 ` Thomas Monjalon
2016-09-02 17:26 ` Michael S. Tsirkin
2016-09-04 8:08 ` Alejandro Lucero
2016-09-05 6:31 ` Jason Wang
2016-09-05 6:31 ` Jason Wang
2016-09-05 6:31 ` Jason Wang
2016-09-05 5:15 ` Jason Wang
2016-09-05 6:25 ` Jason Wang
2016-09-05 6:25 ` Jason Wang
2016-09-05 6:25 ` Jason Wang
[not found] ` <20160905071626.GM30752@yliu-dev.sh.intel.com>
2016-09-06 7:46 ` Yuanhan Liu
2016-09-07 4:53 ` Jason Wang
2016-09-02 12:57 ` [dpdk-dev] [PATCH 1/2] net/virtio: support modern device id Thomas Monjalon
2016-09-05 6:36 ` Jason Wang [this message]
2016-09-05 6:36 ` Jason Wang
2016-09-05 6:36 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46db62d6-4f24-3f86-c22e-089442e182d2@redhat.com \
--to=jasowang@redhat.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=mst@redhat.com \
--cc=thomas.monjalon@6wind.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).