From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id BCDD36CD4
 for <dev@dpdk.org>; Wed,  7 Sep 2016 05:53:31 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga101.jf.intel.com with ESMTP; 06 Sep 2016 20:53:30 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.30,295,1470726000"; d="scan'208";a="1026097420"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162])
 by orsmga001.jf.intel.com with ESMTP; 06 Sep 2016 20:53:29 -0700
Date: Wed, 7 Sep 2016 11:53:59 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: "Dey, Souvik" <sodey@sonusnet.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 "stephen@networkplumber.org" <stephen@networkplumber.org>
Message-ID: <20160907035359.GJ23158@yliu-dev.sh.intel.com>
References: <20160907032156.34492-1-sodey@sonusnet.com>
 <20160907034252.GI23158@yliu-dev.sh.intel.com>
 <BN3PR03MB1494AB38DC5AC42ACDCCDC0CDAF80@BN3PR03MB1494.namprd03.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BN3PR03MB1494AB38DC5AC42ACDCCDC0CDAF80@BN3PR03MB1494.namprd03.prod.outlook.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v3]virtio:add mtu set in virtio
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Sep 2016 03:53:32 -0000

On Wed, Sep 07, 2016 at 03:47:27AM +0000, Dey, Souvik wrote:
> Ok will change it. Do I need to submit a new v4 for that ?

Yes.

> can I put your name also in the reviewed by list?

Nope, you should not add that. I just offered some comments. And yes, I
reviewed your patch, but that doesn't mean you could add my Reviewed-by.

You can only add the Reviewed-by tag only when the reviewer gave it to
you, explicitly, like following:

    Reviewed-by: Some One <some@one.com>

	--yliu

> 
> -----Original Message-----
> From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] 
> Sent: Tuesday, September 6, 2016 11:43 PM
> To: Dey, Souvik <sodey@sonusnet.com>
> Cc: dev@dpdk.org; stephen@networkplumber.org
> Subject: Re: [dpdk-dev] [PATCH v3]virtio:add mtu set in virtio
> 
> On Tue, Sep 06, 2016 at 11:21:56PM -0400, souvikdey33 wrote:
> > +static int
> > +virtio_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) {
> > +	struct virtio_hw *hw = dev->data->dev_private;
> > +	if (mtu < VIRTIO_MIN_RX_BUFSIZE || mtu > VIRTIO_MAX_RX_PKTLEN) {
> > +		PMD_INIT_LOG(ERR, "Mtu should be between 64 and 9728\n");
> 
> I forgot to mention in last email, that you should not use the number (64 and 9728) directly, use the MACRO instead.
> 
> 	--yliu