From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f171.google.com (mail-pf0-f171.google.com [209.85.192.171]) by dpdk.org (Postfix) with ESMTP id 71E1D558B for ; Thu, 8 Sep 2016 18:44:33 +0200 (CEST) Received: by mail-pf0-f171.google.com with SMTP id g202so19926488pfb.0 for ; Thu, 08 Sep 2016 09:44:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pcgfZFvjEt8++emlm7G8tchMN6HCrCnYqWN9cqNyVvc=; b=zhrM4ql2ykiqf0cnv01Lac9HU4iaSp61UWQJt3VTe09i2DG6ANts9yECWc14xAawO8 gKVI9Y4zfxwcjh+UUP2t8LRDAttJYq//YmZJXxGkYSIIPQ/3aEsQjlI0jhhIgSw6/qpr Op5UoAxlY4DFciR3uP717k5Bbxa/kLZEmqGCeFY+7S4F5WjnRCLEi+vu/mGx1D1YZEQO 5JO60hRIQQ6DckPxtfOeSGw54TEODLSoIo5YUGDJffw34n7lGMaCuwWMUA4uJv37RSke sie5Uwgp5HmyJ5x9dH4Bh4AhivreSQD7/LabzCLXB/+Q544eXVjcioDkGfSlCPumzKZ0 9xlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pcgfZFvjEt8++emlm7G8tchMN6HCrCnYqWN9cqNyVvc=; b=Fb84U+OszjmUC8AXqqWiTHw7gFo8auaQZmuLuZ3mnzE+7MlN0KcaTdWYd7W39AN0A4 8rduT/CxEAjlepJpiIdU0xIJ8rR6boCETa3F6hAwiIRaq+LFrumdVtNS+h3E3mNAWmy1 7RR188oIIPAzQiJP/7ahUxq+p5wKK6d+xBayWKBCPGGNhrC3lxzdFJ+f64EqN6/FnDLj cAcmINDsVp51MFYnC5A7YxjDfHQbLli272/7MEbUBnwwFQbgBnHsM9+u8xnYuXu/7RIZ zQP7Xpnzv65NmHg3WXP38w9v9HdPovZjAXfy7JLMQix/riNaWOE8JNNogpYK7fmbCbTR U2zg== X-Gm-Message-State: AE9vXwNlxI8gL5MZvwi8oaZYUMuSTdAYiEh8WOI48typ6lYiK9o+bXQB7RfSLaGd6wajZg== X-Received: by 10.98.90.133 with SMTP id o127mr964309pfb.61.1473353072724; Thu, 08 Sep 2016 09:44:32 -0700 (PDT) Received: from xeon-e3 (static-50-53-69-251.bvtn.or.frontiernet.net. [50.53.69.251]) by smtp.gmail.com with ESMTPSA id f84sm57460671pfd.87.2016.09.08.09.44.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Sep 2016 09:44:32 -0700 (PDT) Date: Thu, 8 Sep 2016 09:44:42 -0700 From: Stephen Hemminger To: zhouyangchao Cc: ferruh.yigit@intel.com, dev@dpdk.org Message-ID: <20160908094442.4dfa5b01@xeon-e3> In-Reply-To: <1473389167-2758-1-git-send-email-zhouyates@gmail.com> References: <1473389167-2758-1-git-send-email-zhouyates@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] kni: unregister an unregisterd net_device could cause a kernel crash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Sep 2016 16:44:33 -0000 On Fri, 9 Sep 2016 10:46:07 +0800 zhouyangchao wrote: > Signed-off-by: zhouyangchao > --- > lib/librte_eal/linuxapp/kni/kni_misc.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c b/lib/librte_eal/linuxapp/kni/kni_misc.c > index 67e9b7d..ad4e603 100644 > --- a/lib/librte_eal/linuxapp/kni/kni_misc.c > +++ b/lib/librte_eal/linuxapp/kni/kni_misc.c > @@ -361,7 +361,9 @@ kni_dev_remove(struct kni_dev *dev) > igb_kni_remove(dev->pci_dev); > > if (dev->net_dev) { > - unregister_netdev(dev->net_dev); > + if (dev->netdev->reg_state == NETREG_REGISTERED){ ----------------------------------------------------------------^ Incorrect whitespace. But then again the whole KNI driver fails completely when running kernel style check.