From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com [209.85.220.41]) by dpdk.org (Postfix) with ESMTP id 9250F68F8 for ; Thu, 8 Sep 2016 20:00:31 +0200 (CEST) Received: by mail-pa0-f41.google.com with SMTP id id6so19545200pad.3 for ; Thu, 08 Sep 2016 11:00:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IsVtO0vVU09SNCdaFNRbi1UkAUYZZTnu5MaMDmNJR8U=; b=ircmX5P3w2M2rnb3+4k8oGJgOOWdY0RfO+hv8bb2aWJaNn9l6YCMtzMoyOlbVxw2aM W5XMYSGQRNYeZAnRg+dc5l9iY48yOFtQUpTUcLoLCOcIILGBNjCRqRRKxW1h5aPEvv+j oAz6syyy0TMYUyHiuNTNZMrpnBOEKcMvoT2l6kEfJ6FJUI++kP3HI1M8XoYRwHBKFQIV aRPTPpFslWfXJXygvwg2F8ZkS89P5eIknWFosH8vABESR5buFVtUtGZTsbI9ojD7fop2 g2G+Ujyd2gexeueii9iBm357EDJ3rvMjvfs6TfdB39nokS2YOU8C3MCZroIoYIzJDcuN q8Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IsVtO0vVU09SNCdaFNRbi1UkAUYZZTnu5MaMDmNJR8U=; b=k3worHB1iWK498tHugrkftOpILRsQt8wFZSRMTai2RIIuh7eaupAx1/BYVQzdKbiGA 6L3/7EFsbmMFXp1PcayQg0nomnY4tRNzAbHLQtw8FzM0asNaPbkSAzf4oWyEwS0EiozS 4nT8OtdNLI3RyQxVxm1TZXDvcmO8GanAq1nxqvvfOvG61wY82DXPcVTL5Dv2nl8gZQY8 YrW4CtEaFmjd5s7La2Rw4RaAbuqfcZlcSseigHdR0tTs8veTI6i+3Hm5PfierkEGvKUv gForgPP9R3rIJWiKla7jmhnPXEKrDhQxiS8/1d6dMxrLPx5AcvrlUMZZvyT3ocKAOYrY rR4w== X-Gm-Message-State: AE9vXwOMIxC7z4NcEJNZym/lBLtYCpg6k5zHlVkxZqOLHQSFMFS3YEAmAbQGPkDT3vxwwA== X-Received: by 10.66.25.228 with SMTP id f4mr1535060pag.157.1473357630899; Thu, 08 Sep 2016 11:00:30 -0700 (PDT) Received: from xeon-e3 (static-50-53-69-251.bvtn.or.frontiernet.net. [50.53.69.251]) by smtp.gmail.com with ESMTPSA id n3sm57997136paf.13.2016.09.08.11.00.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Sep 2016 11:00:30 -0700 (PDT) Date: Thu, 8 Sep 2016 11:00:40 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: dev@dpdk.org Message-ID: <20160908110040.32ec79f5@xeon-e3> In-Reply-To: <1473357296-10375-1-git-send-email-ferruh.yigit@intel.com> References: <1473357296-10375-1-git-send-email-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] kni: fix build with kernel 4.8 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Sep 2016 18:00:32 -0000 On Thu, 8 Sep 2016 18:54:56 +0100 Ferruh Yigit wrote: > Linux kernel v4.8 removes macro DEFINE_PCI_DEVICE_TABLE > > Linux: 7e9321599011 ("treewide: remove references to the now unnecessary > DEFINE_PCI_DEVICE_TABLE") > > Added the macro to compatibility headers of the kni ethtool drivers. > > Signed-off-by: Ferruh Yigit > --- > lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h | 7 +++++++ > lib/librte_eal/linuxapp/kni/ethtool/ixgbe/kcompat.h | 6 ++++++ > 2 files changed, 13 insertions(+) > > diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h > index bdd0806..9560aae 100644 > --- a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h > +++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h > @@ -3915,4 +3915,11 @@ skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type) > /* ndo_bridge_getlink adds new filter_mask and vlan_fill parameters */ > #define HAVE_NDO_BRIDGE_GETLINK_FILTER_MASK_VLAN_FILL > #endif /* >= 4.2.0 */ > + > +#if ( LINUX_VERSION_CODE >= KERNEL_VERSION(4,8,0) ) > +#ifndef DEFINE_PCI_DEVICE_TABLE > +#define DEFINE_PCI_DEVICE_TABLE(_table) const struct pci_device_id _table[] > +#endif /* DEFINE_PCI_DEVICE_TABLE */ > +#endif /* >= 4.8.0 */ > + Good to see the KNI driver staying up to date with upstream. Please just remove use of DEFINE_PCI_DEVICE_TABLE rather than resurrecting it!