From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id A1E6F5687
 for <dev@dpdk.org>; Wed, 14 Sep 2016 06:32:29 +0200 (CEST)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga101.jf.intel.com with ESMTP; 13 Sep 2016 21:32:28 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.30,332,1470726000"; d="scan'208";a="167926752"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162])
 by fmsmga004.fm.intel.com with ESMTP; 13 Sep 2016 21:32:27 -0700
Date: Wed, 14 Sep 2016 12:32:56 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: "Dey, Souvik" <sodey@sonusnet.com>
Cc: "Kavanagh, Mark B" <mark.b.kavanagh@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>,
 "stephen@networkplumber.org" <stephen@networkplumber.org>
Message-ID: <20160914043256.GW23158@yliu-dev.sh.intel.com>
References: <BN3PR03MB1494B8B7E30A69B42E6A350CDAF80@BN3PR03MB1494.namprd03.prod.outlook.com>
 <20160909070009.GS23158@yliu-dev.sh.intel.com>
 <CY1PR03MB15038BC628CE60C1C3351DAEDAFA0@CY1PR03MB1503.namprd03.prod.outlook.com>
 <DC5AD7FA266D86499789B1BCAEC715F85C6FC36D@irsmsx105.ger.corp.intel.com>
 <CY1PR03MB1503EBBC768F105F702086B2DAFA0@CY1PR03MB1503.namprd03.prod.outlook.com>
 <DC5AD7FA266D86499789B1BCAEC715F85C6FC636@irsmsx105.ger.corp.intel.com>
 <BY1PR03MB1499011D33C91ADFA2517965DAFA0@BY1PR03MB1499.namprd03.prod.outlook.com>
 <DC5AD7FA266D86499789B1BCAEC715F85C6FDCA0@irsmsx105.ger.corp.intel.com>
 <BN3PR03MB14946BCFDECB870FF220A3B9DAFF0@BN3PR03MB1494.namprd03.prod.outlook.com>
 <BN3PR03MB14943859FE72613F68A9F7C7DAF10@BN3PR03MB1494.namprd03.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BN3PR03MB14943859FE72613F68A9F7C7DAF10@BN3PR03MB1494.namprd03.prod.outlook.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v4]net/virtio: add mtu set in virtio
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Sep 2016 04:32:30 -0000

On Wed, Sep 14, 2016 at 12:25:21AM +0000, Dey, Souvik wrote:
> Hi Mark/Liu,
> 	Is there any further comments to the below patch ? Should I submit it as v5 of the patch ? 

I think I'm okay with the patch now. But I got one more ask for you :)

In commit log, you stated:

    Virtio interfaces should also support setting of mtu, as in case of cloud
    it is expected to have the consistent mtu across the infrastructure that
    the dhcp server sends and not hardcoded to 1500(default).

What would go wrong if the expectation is not achieved? I think you should
have met some issue and you meant to fix it, right? If so, you should state
that here.

	--yliu