From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0059.outbound.protection.outlook.com [104.47.38.59]) by dpdk.org (Postfix) with ESMTP id 7A0C838EB for ; Fri, 16 Sep 2016 18:02:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SonusNetworks.onmicrosoft.com; s=selector1-sonusnet-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=c0mC6ICJkYWS63Qx7G2JQF/h1tMK4PEgWj5eB602zkA=; b=GNEb0mCkCqgENt+jiGGZYqqutVAwKa+hv/wuUwrLBhQBL28AYhK5iivu2Y3O7zW3H73wun7dFSPpz3XKj4HcYIUpMdxHRopnj0bJUFv3E3zHNINp8B3A0od8XPNRYHaBFOC5mPGSUkxuYrgY1YQU0imDYgB0KV+ZbqXfpY8KYeA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=skarmarkar@sonusnet.com; Received: from SKARMARKAR-LMA.sonusnet.com (208.45.178.4) by BLUPR03MB1425.namprd03.prod.outlook.com (10.163.81.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.619.10; Fri, 16 Sep 2016 16:02:39 +0000 From: Karmarkar Suyash To: CC: , , , Karmarkar Suyash Date: Fri, 16 Sep 2016 12:02:22 -0400 Message-ID: <20160916160222.12956-1-skarmarkar@sonusnet.com> X-Mailer: git-send-email 2.9.3.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [208.45.178.4] X-ClientProxiedBy: BN3PR0301CA0063.namprd03.prod.outlook.com (10.160.152.159) To BLUPR03MB1425.namprd03.prod.outlook.com (10.163.81.147) X-MS-Office365-Filtering-Correlation-Id: 51308d1c-66aa-430f-ceba-08d3de4ae2ae X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB1425; 2:AnhWaKDVrmhze5mDnT+K+7pBJ/SalES7maG29cEopC4mcAwEFn5/boKBiQ7nHNWQ5c8n97iv2ecMO0UOM4XQaiiYiyA4TWpUNbRfHG56/Sn/qiXfSH/1cRBaj/oa6DrTQavGQrFFJzt7IU9XpNqO5V0BIoqUwfGfyxfdQAF/b97iTy3mlJLiEJb/g93+B8cA; 3:0V5I1V4iwDUnf0pYXjpB534TPtuCx/eRcBA9OJJ3GV017iTAbJKwFZZj5Uojm/klxF4yGRzkG+Cils4ZqmCzssBD4LlplamQnLN1z/RXZ+MeaXJRQNCMNvAGvlBINfT7 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1425; X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB1425; 25:prmPDahdGTk5CGMC3Y6B95Xb9GgqSsdU3p7rLYYLusRZ+XVplRokvz5ojC9U/s08VSYpbFARHveYSEa3uYeTBANgwcuvoDyl40EzvGAT243PQDaLUQnBPkdpERtixG6NKzNyk7U40zES+Tu1jfqgS0X6H2yB+0WqrkEpJRa45OhJC+lf3B8ylSe357W/l0Umd7yHy/NV3bHQ0LVXyBtBX9E3ivkMqji9I9dKD/Ekxt4Kr8vuBdpL2zmQO0EZbmYlgABvLVN0FIpLZhGaVoNakpLQbZD2VZW+xAwy+fH9Ima2DgAw2zX0NbVc86+bhuxM6yNns6E3vG02+L83vkBHnDcQQ5cw4hSPhbvQ3R/YntfnLnSo0D3RSilkE/f/Jcckls1H+px7bjSFFgff65xbzPy+iP3BFFHb7gA4ULxwmv95HW6r4E+aTCu+Pngke0zGw1kgXSgQFRs0FyzkhOYYGDgY0A4xJah9wjoO59lTJ172kspXTkR206y5M8YDa6LBPUp8xD1uD0u4WKM2dz7PL93zODpPxOfKOFKaEm6wxzvSF9ouTXnQFSHluwwJPetZ1gKqi6g8Xt+eScligUxJuP4YTuld1ZAiJSVjAa1L694vWjPhoxe9NvWr6tJU0jaic5Pf5yJdJWWvAMzso5fLL/xD9EdyS3tNesOS4i/6EBbFMzSjHV2LiqWABaV9AwoA3EEJv1VGQs0As2Zjuu31xlyyk8mXWujxqC9bFtkS2VE= X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB1425; 31:nGlPo/8n8ZxE+dVhiW9zoXkFXfSMxrBRnztpB6bPDW3d0cZbxztnY1WC8CuQPFr89/TdIjDhxFRnO79fVaHidkXqH0HrIqSMNPcgPEfQHiq/AM92BrSIFsGC+Ek4w6UnZTp3PepgVuOToy1V8sJY8+7A2lO6yvtPdSqVwz6hMPCiuiNy3ObwhJfZmwVzqf5ai5PanxkpqGk0WvZNJWANjML0ONcFd+WJAT6cx7ICbik=; 20:MWikeq0/q+fp2dzQ7B9gGLN6S5fL4pUtiFHWy6P+0T/2vqb02qXkKkGP1qt4sLElzsiGkj6acZQJTUo6R/zr8fiq3ngmKPCvY1l+zUw4ecwMwJoj7+Lc3XQsrEMh6NjZnR2WV7ZnIhDoWLqVSqyfx8YvHitp9d5qsibKGRcpYxRvdqs0wEkZy/hgnYOCTG0XDKh6Rkc5dM//KHtozzdAPecmafU+OzJjdMKmKIBogo4uxFmAG2qlwDjYqgftg/CvEEG07C/AOrJSts+Y5do22leOQTfBLBpHvpKYD+4qqywzVcmeudimgv2rV3G/lMNxh+48LO7uykn4aPcbDaWH38k2sUo0RBPLKRm5bi+NSyrQSyMVdQ5giWbdftwszYXhFK9AFtNvuNl2zkJMmXmq3U9rr5+Xy9yZLqpqopaP6AvNrvY4uCRmZkLUJP0W28s0KeP6mXeOgt9L/+KSfb9TLymsK4SmeTmwPO92V3VXIgiU6BcrkmUMDb/b4jEsSJEf X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001); SRVR:BLUPR03MB1425; BCL:0; PCL:0; RULEID:; SRVR:BLUPR03MB1425; X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB1425; 4:ffnyd3WpyUTx0XKS7Hk0mENpXAUKVH6uxRMScA8Q8DfR9kyUEXLfoidr6PUHXgEgR2ZsxN+PsKgVt3uwhbE5/sxAZGey4Byju89EIeDnfzc/o0ECG59VkplenKBFyor/WjVM9IhBU/NpYec3VXnBU3Kh43lw2J+14ZTsrJETDP6YzX6Ubpnow8ZJ/F/Q7foCZo0gXHM0hhVmkPV9gChF6W3cedceO0gis2dlZHjpt0V2pNQzFwx7kvzbFkEL3bv6yW+rr1xKsgpFzqgoDat8dpjdpyWQKbiyea7m/684DXwj2W+4AaneEaUSp3AI0z1LZdoFilty/2VcxnbXnmD9LUsCiFS+xSlVsOSEc/fWzkZXPLW1QomgpGuS4pTlhUYLUWUx81H2bmup5EInFMAbnA== X-Forefront-PRVS: 0067A8BA2A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(7916002)(199003)(189002)(19580405001)(2906002)(19580395003)(105586002)(4326007)(2351001)(69596002)(48376002)(50226002)(305945005)(586003)(50466002)(229853001)(3846002)(1076002)(6116002)(42186005)(5003940100001)(7846002)(106356001)(47776003)(7736002)(66066001)(53416004)(110136003)(81166006)(107886002)(33646002)(8676002)(86362001)(77096005)(81156014)(92566002)(5660300001)(68736007)(36756003)(50986999)(97736004)(101416001)(4001430100002)(189998001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR03MB1425; H:SKARMARKAR-LMA.sonusnet.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: sonusnet.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR03MB1425; 23:PNPwd3phT0gCI0iSq1OOD0boDTpbQBpwzBObgZQlX?= =?us-ascii?Q?iPsoTNtLDtcFwcMfd+6NXpyHJNq6dGQI9YHCayGcF6GCGQVr/rlWyeAKTsdY?= =?us-ascii?Q?S3R1d4Comf4TWxFvlthD79W6BYSHwlwrrsiWgC7OLi/do0y1UIqlTAMrMfnb?= =?us-ascii?Q?CkKzTw2C8GBJ4IztDkP6Yh6MFFgH55VUKqLSKBgqOtziFd+8fMsLcXuVAgS5?= =?us-ascii?Q?5xEDnHtuqaronxE9zOQsqd9Sub8BMDHMaZ92YIswZeSmhdHIHmVuzpqjhehW?= =?us-ascii?Q?K9v2DgMaX+x2Un5GE8f1X3RCeR2P1JIQLbIHDE2TOJKHhkfur/UNiNwfZ0ke?= =?us-ascii?Q?QbqySZAmRfn7MBPOBq/yOurCQJv+T2o7IJMWq0EVJEgkUhkVd1AMQV65HzU1?= =?us-ascii?Q?RFxRa/jf8ehaEAvuWCNxBZpiXG6B2SMKQqpKF40Xdj/VAXP+fWN1M6fbuRed?= =?us-ascii?Q?Ju2yiM0zJ9Pmt4H47uTRsa6Qh+gpwkG3KRqIOMpqRAXhbl6ed20X2sK4QaZT?= =?us-ascii?Q?Hg59vn+SeqKKOg8+yrAuM/Zb0sG6/PoJPDKcYMRaAw3yI/rt9a9WXkhPR/m9?= =?us-ascii?Q?mXy7qPhif0sacN1owc1nkd2FbY8mkaur1kTvfDwc0o89AzEC4P7mlDZQrdxq?= =?us-ascii?Q?+ecc+2rbMgbjdi+fOwyY0SF+2XV2NPWKWj7wmuGWqRIoDEgN0CnfRYGZ5Tii?= =?us-ascii?Q?NPQ4Q1vD+bX1NdwEYO8/CktSdJ1C/Ro2R9/ktQvBPOG/ZTAnHmMFeKszavqW?= =?us-ascii?Q?rwP3gxVm0BWUspq75mEHhbIpOFKVYI9CYNeYNW/YofNS24y82TrVOLnLuR1A?= =?us-ascii?Q?WBTtk8ibyGWfOlCcZCVJf6Ka+IJXANjxNflZ501PYJA3ZiQMJcl3bKssFlet?= =?us-ascii?Q?DgiURVe/YMBU4JxstXGf85O0miudQMq+HCG0+PMC7T5/oYIJ1hJzHQAGpxBw?= =?us-ascii?Q?gt49MfJuK/6QCSIP6+MMAteemjj1tqdQuKHDkCCeYuluQEQPOeteI2HRb7Op?= =?us-ascii?Q?6mm0LIUzl7GXrqVWc73F3hlusAnARSvmFE3aS335lWgOHMZR/HN4hIjm1DXu?= =?us-ascii?Q?ii4JSdkAGLLB5pxw7o2VT8FT7sGiUSm2CGDnYDCUrPkmJPhPXof5bx7Itm8/?= =?us-ascii?Q?BnBj7apxrM=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB1425; 6:1LTnIPCt4C/o+1fFywkXgAjGKZakuK9BORhXOeS47iRswVzIxEWnrOr4Yy0DyEl0R2hzTBlWvNseZ1gz1pi31LaQun6a5CsB4D06DJ5JNXG+wRVEJOuvTdjHLFDZ6zD/v8/ee38TGtP8sUTkAqIX4MHmhFBaxf7Aaj1AhJuB8vtbHrr2ViTVdf7voP9I9FPCiTmCKYpvFVyDqFzcwkgiIlCsD/ZwjOjSvWQNkMBdZ63IsLdbQndohBB3vyLu5kgTj5oRJxMPX8lpN/acAhFOjY5ZLdEl90MEudbWwwAxBIA=; 5:ZlWEm0V7mRy9piEN6FSsCdDWXRR1LoK70ZTdzmXZzF1/vIUnxtsL/ZEiVG2aGJDLqRE8ykW7D3rhPAKvfhbRZK+BzbelycXfxQqG26sYxky0205YBnT3n6D80EqEWSkNcR+8OhOg7SVPd4PH1fQXmA==; 24:4ozXLqTwCv7CxNmwDu0o2lz2SVUWW6lkrgl5EbBsgrtGZk+u+klrS9bedvOTDhjfY+ZwV1H0lonwhIaFqYf2aAfylwpcVlSLtPO336c3KNc=; 7:6WsZph/kdOR1LmNJgYdJrEOx5+tCFIDl9sCNJaM8791vMUZGGCk7eZLts8p/ck/BvMFsWQMZ/OHhWtLZeWw0sPEPPnwy9ajUTFEuEHUO4MZ2aXe9m/V9mOBvisakUiO/dD7Vinl1+HJXlLpC0dBDWIil+hSVIYOlIPeJMeLtim2GRplYx0SuggQujCtsblPxhFQWBc7c4ikFtTZkg4W+vkrWatnAjAJKwnj/h2vFYplTeh98OU4dirgxbMJt7Rdg SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: sonusnet.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2016 16:02:39.9653 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1425 Subject: [dpdk-dev] [PATCH v2]:rte_timer:timer lag issue correction X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2016 16:02:42 -0000 For Periodic timers ,if the lag gets introduced, the current code added additional delay when the next peridoc timer was initialized by not taking into account the delay added, with this fix the code would start the next occurrence of timer keeping in account the lag added.Corrected the behavior. Fixes:ba885531ac26 ("rte_timer: timer lag issue") Karmarkar Suyash (1): Signed-off-by: Karmarkar Suyash lib/librte_timer/rte_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- lib/librte_timer/rte_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c index 43da836..18782fa 100644 --- a/lib/librte_timer/rte_timer.c +++ b/lib/librte_timer/rte_timer.c @@ -613,7 +613,7 @@ void rte_timer_manage(void) status.owner = (int16_t)lcore_id; rte_wmb(); tim->status.u32 = status.u32; - __rte_timer_reset(tim, cur_time + tim->period, + __rte_timer_reset(tim, tim->expire + tim->period, tim->period, lcore_id, tim->f, tim->arg, 1); rte_spinlock_unlock(&priv_timer[lcore_id].list_lock); } -- 2.9.3.windows.1