From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 714115581 for ; Tue, 20 Sep 2016 05:54:10 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP; 19 Sep 2016 20:54:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,365,1470726000"; d="scan'208";a="1059295168" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga002.fm.intel.com with ESMTP; 19 Sep 2016 20:54:08 -0700 Date: Tue, 20 Sep 2016 11:54:36 +0800 From: Yuanhan Liu To: "Wiles, Keith" Cc: "dev@dpdk.org" , "pmatilai@redhat.com" Message-ID: <20160920035436.GN23158@yliu-dev.sh.intel.com> References: <1473948649-14169-1-git-send-email-keith.wiles@intel.com> <1474042933-33625-1-git-send-email-keith.wiles@intel.com> <20160918132556.GH23158@yliu-dev.sh.intel.com> <73B08964-0730-4A1A-90DC-5C29D6A59419@intel.com> <20160919002919.GJ23158@yliu-dev.sh.intel.com> <841234E7-437D-4D82-8434-3468590E11D3@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <841234E7-437D-4D82-8434-3468590E11D3@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2] drivers/net:new PMD using tun/tap host interface X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Sep 2016 03:54:10 -0000 On Mon, Sep 19, 2016 at 03:56:03PM +0000, Wiles, Keith wrote: > All of the below errors are from Linux header files and not the Tap > driver. > > > Yes, but you are referencing them, so ... > > > Yes I am referencing them, but still they are not interacting with the tap > driver. Yes, they are not. But the tap driver code references them. I mean, you might have done that wrongly. e.g., the build passes if I removed few includes for linux header files: diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 4621c55..2a6bcd0 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -47,9 +47,7 @@ #include #include #ifdef __linux__ -#include #include -#include #else #include #endif > It would seem like you could delete all of the code in the tap driver > and still get these errors. Which you could try if you want, just ifdef the > code and see if it still happens. > > On my ubuntu 16.04 machine I do not get these errors. I need to know how to > reproduce the failure to fix it. Interesting! I really did no magic to reproduce it. As said, I can reproduce it pretty easily with ubuntu 16.04 and fedora 20, just with default build: $ make install T=$RTE_SDK Anyway, the error is straightforward after all: both files (net/if.h and linux/if.h) define same structures and macros. Including both of them would result errors like I reported. --yliu