From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 0A2A368F2 for ; Tue, 20 Sep 2016 13:49:48 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP; 20 Sep 2016 04:49:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,367,1470726000"; d="scan'208";a="170945939" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga004.fm.intel.com with ESMTP; 20 Sep 2016 04:49:46 -0700 Date: Tue, 20 Sep 2016 19:50:17 +0800 From: Yuanhan Liu To: Zhiyong Yang Cc: dev@dpdk.org, thomas.monjalon@6wind.com, pmatilai@redhat.com, harry.van.haaren@intel.com Message-ID: <20160920115017.GV23158@yliu-dev.sh.intel.com> References: <1474364205-111569-1-git-send-email-zhiyong.yang@intel.com> <1474364205-111569-3-git-send-email-zhiyong.yang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1474364205-111569-3-git-send-email-zhiyong.yang@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v3 2/2] net/vhost: add pmd xstats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Sep 2016 11:49:49 -0000 On Tue, Sep 20, 2016 at 05:36:45PM +0800, Zhiyong Yang wrote: > +enum vhost_xstats_pkts { > + VHOST_UNDERSIZE_PKT = 0, > + VHOST_64_PKT, > + VHOST_65_TO_127_PKT, > + VHOST_128_TO_255_PKT, > + VHOST_256_TO_511_PKT, > + VHOST_512_TO_1023_PKT, > + VHOST_1024_TO_1522_PKT, > + VHOST_1523_TO_MAX_PKT, > + VHOST_BROADCAST_PKT, > + VHOST_MULTICAST_PKT, Another thing I noted is that you dropped unitcast counting here. I think the comment I gave in last email was you don't have to update it every time we rx/tx packets, instead, you could calcuate it on query (at vhost_dev_xstats_get). I was not asking you to drop it. --yliu