DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: dev@dpdk.org
Cc: Olivier Matz <olivier.matz@6wind.com>
Subject: [dpdk-dev] [PATCH 2/2] mempool: fix comments for no contiguous flag
Date: Tue, 20 Sep 2016 17:17:08 +0100	[thread overview]
Message-ID: <20160920161708.9707-2-ferruh.yigit@intel.com> (raw)
In-Reply-To: <20160920161708.9707-1-ferruh.yigit@intel.com>

Fixes: ce94a51ff05c ("mempool: add flag for removing phys contiguous constraint")

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 lib/librte_mempool/rte_mempool.c | 4 +++-
 lib/librte_mempool/rte_mempool.h | 3 +++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c
index e96d14f..d767f39 100644
--- a/lib/librte_mempool/rte_mempool.c
+++ b/lib/librte_mempool/rte_mempool.c
@@ -340,7 +340,9 @@ rte_mempool_free_memchunks(struct rte_mempool *mp)
 }
 
 /* Add objects in the pool, using a physically contiguous memory
- * zone. Return the number of objects added, or a negative value
+ * zone if MEMPOOL_F_NO_PHYS_CONTIG flag is not set.
+ *
+ * Return the number of objects added, or a negative value
  * on error.
  */
 int
diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h
index 6fc331a..291c168 100644
--- a/lib/librte_mempool/rte_mempool.h
+++ b/lib/librte_mempool/rte_mempool.h
@@ -798,6 +798,9 @@ rte_mempool_free(struct rte_mempool *mp);
  * Add a virtually and physically contiguous memory chunk in the pool
  * where objects can be instanciated.
  *
+ * mempool flag MEMPOOL_F_NO_PHYS_CONTIG changes behavior of the function
+ * and removes physical contiguous constraint.
+ *
  * @param mp
  *   A pointer to the mempool structure.
  * @param vaddr
-- 
2.7.4

  reply	other threads:[~2016-09-20 16:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-20 16:17 [dpdk-dev] [PATCH 1/2] mempool: fix comments for mempool create functions Ferruh Yigit
2016-09-20 16:17 ` Ferruh Yigit [this message]
2016-09-21 15:12   ` [dpdk-dev] [PATCH 2/2] mempool: fix comments for no contiguous flag Olivier Matz
2016-09-21 16:15     ` Ferruh Yigit
2016-09-22  7:23       ` Olivier Matz
2016-09-21 15:04 ` [dpdk-dev] [PATCH 1/2] mempool: fix comments for mempool create functions Olivier Matz
2016-09-21 16:16   ` Ferruh Yigit
2016-09-28 13:59 ` [dpdk-dev] [PATCH v2 " Ferruh Yigit
2016-09-28 13:59   ` [dpdk-dev] [PATCH v2 2/2] mempool: fix comments for no contiguous flag Ferruh Yigit
2016-10-03 15:06   ` [dpdk-dev] [PATCH v2 1/2] mempool: fix comments for mempool create functions Olivier Matz
2016-10-04  9:18     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160920161708.9707-2-ferruh.yigit@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=olivier.matz@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).