* [dpdk-dev] [PATCH v2] nfp: unregister interrupt callback when closing
@ 2016-09-16 11:11 Alejandro Lucero
2016-09-21 10:07 ` Bruce Richardson
0 siblings, 1 reply; 2+ messages in thread
From: Alejandro Lucero @ 2016-09-16 11:11 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit
With an app using hotplug feature, when a device is unplugged without
unregistering makes the interrupt handling unstable.
Fixes: 6c53f87b3497 ("nfp: add link status interrupt")
Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
---
drivers/net/nfp/nfp_net.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index d79f0a1..f78eb82 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -733,6 +733,11 @@ nfp_net_close(struct rte_eth_dev *dev)
rte_intr_disable(&dev->pci_dev->intr_handle);
nn_cfg_writeb(hw, NFP_NET_CFG_LSC, 0xff);
+ /* unregister callback func from eal lib */
+ rte_intr_callback_unregister(&dev->pci_dev->intr_handle,
+ nfp_net_dev_interrupt_handler,
+ (void *)dev);
+
/*
* The ixgbe PMD driver disables the pcie master on the
* device. The i40e does not...
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH v2] nfp: unregister interrupt callback when closing
2016-09-16 11:11 [dpdk-dev] [PATCH v2] nfp: unregister interrupt callback when closing Alejandro Lucero
@ 2016-09-21 10:07 ` Bruce Richardson
0 siblings, 0 replies; 2+ messages in thread
From: Bruce Richardson @ 2016-09-21 10:07 UTC (permalink / raw)
To: Alejandro Lucero; +Cc: dev, ferruh.yigit
On Fri, Sep 16, 2016 at 12:11:14PM +0100, Alejandro Lucero wrote:
> With an app using hotplug feature, when a device is unplugged without
> unregistering makes the interrupt handling unstable.
>
> Fixes: 6c53f87b3497 ("nfp: add link status interrupt")
>
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
Applied to dpdk-next-net/rel_16_11
/Bruce
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-21 10:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-16 11:11 [dpdk-dev] [PATCH v2] nfp: unregister interrupt callback when closing Alejandro Lucero
2016-09-21 10:07 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).