From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f177.google.com (mail-pf0-f177.google.com [209.85.192.177]) by dpdk.org (Postfix) with ESMTP id 561ED5585 for ; Thu, 22 Sep 2016 17:57:51 +0200 (CEST) Received: by mail-pf0-f177.google.com with SMTP id q2so31870710pfj.3 for ; Thu, 22 Sep 2016 08:57:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=S7NgjIAM19yvFQjq4GeCiBStcwt/2GOhTVA7zRGe4Ps=; b=0kkGI93D19mUkVxV5o0yfcWD9li1cDmqVIv3foDybEi1/8l7TPjKO2XKDdwA/MIXUv 4E2iuGF4wln9X3UV802osrOepMIJtqSlIg9/X2ZbkSiVr7rPJk/XT+iB7P43LF6wMbCA ZtJcSEIq8ShVoBx/WissLWw7+ItuVphLIDifGw+8Rjrbk/r/EfmiK9Ko6jrzqJu8kzff QvvGNZgDC9Bj9lyNwpjK29QXNtZuVHNz5O6w0o4Rj87Bj3MsD0SARmTlIu6JfEFOth6Y Lpl5r8w/5Hx3bamKlrLaZFGviJjuG6Z3FmP50y1/Oj0z3itNqi6NEQ7CcpDyG5oodN6c 2jDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=S7NgjIAM19yvFQjq4GeCiBStcwt/2GOhTVA7zRGe4Ps=; b=e619+tvclEhk2sLfabLnSjWhOwmFkaqVjTzJVvnrTjGogFsZRU30jQwzTB7/bnIUTN q4I2y49hoFIfIQX0uc/qul/pUy4XaqSPTzpAjtc9EV12smIt1Sd6xynG0gUJjX5BX0BT cDGSMnfUZOocEuRBYMuWJeA+u38RDfbZqRUa6EpXuDRbP7txz69ZS9PVVhW3Ls8LMqjT fZxsVj5xBy3kZeUt3uK71yUmM7w75pH0c47HR6IVBMj7f4qo8GD5OhRrRwXUvlkBIih4 YeEZK10STSF8zsywniWv4Lus/LkvCB/hciTr1U+211nBpXoaaLu4pa3PvK0Pokf636Jp WvSg== X-Gm-Message-State: AE9vXwMhiQW+a+20Sx+nrVblwyiwSe5NDJBukEGVY7vt83LLI77eSFZg/uFXu06wuAJGQg== X-Received: by 10.98.193.193 with SMTP id i184mr4473057pfg.69.1474559870635; Thu, 22 Sep 2016 08:57:50 -0700 (PDT) Received: from xeon-e3 (static-50-53-69-251.bvtn.or.frontiernet.net. [50.53.69.251]) by smtp.gmail.com with ESMTPSA id q14sm5125581pfg.63.2016.09.22.08.57.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 22 Sep 2016 08:57:50 -0700 (PDT) Date: Thu, 22 Sep 2016 08:57:59 -0700 From: Stephen Hemminger To: "Dey, Souvik" Cc: "mark.b.kavanagh@intel.com" , "yuanhan.liu@linux.intel.com" , "dev@dpdk.org" Message-ID: <20160922085759.5f7dea04@xeon-e3> In-Reply-To: References: <20160921231147.26820-1-sodey@sonusnet.com> <20160921162213.4b79d1ce@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6] net/virtio: add set_mtu in virtio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Sep 2016 15:57:51 -0000 On Thu, 22 Sep 2016 00:08:38 +0000 "Dey, Souvik" wrote: > I am fine with the general idea of this patch but: > 1. Calling virtio_dev_info_get is needlessly wasteful when all you want > is to access the max packet length. Since max_rx_pktlen is always > VIRTIO_MAX_RX_PKTLEN, please just use that. > [Dey, Souvik] I am using the virtio_dev_info_get as in future can/may support the max_rx_pktlen as a variable to be set by the application. This will keep the changes future proof. As we need to support till 65535 instead of 9728 as the linux does. Future proof is a myth. Don't add code based on planned future functionality http://www.extremeprogramming.org/rules/early.html