From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id ED3A55939
 for <dev@dpdk.org>; Fri, 23 Sep 2016 08:35:36 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga104.fm.intel.com with ESMTP; 22 Sep 2016 23:35:36 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.30,380,1470726000"; d="scan'208";a="1035053313"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162])
 by orsmga001.jf.intel.com with ESMTP; 22 Sep 2016 23:35:36 -0700
Date: Fri, 23 Sep 2016 14:36:02 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Cc: dev@dpdk.org, fiona.trahe@intel.com, deepak.k.jain@intel.com,
 pablo.de.lara.guarch@intel.com, john.griffin@intel.com
Message-ID: <20160923063602.GU23158@yliu-dev.sh.intel.com>
References: <1474559697-8275-1-git-send-email-arkadiuszx.kusztal@intel.com>
 <20160923063257.GT23158@yliu-dev.sh.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160923063257.GT23158@yliu-dev.sh.intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH] app/test: add AES GCM performance test to
 cryptodev
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Sep 2016 06:35:37 -0000

On Fri, Sep 23, 2016 at 02:32:57PM +0800, Yuanhan Liu wrote:
> On Thu, Sep 22, 2016 at 04:54:57PM +0100, Arek Kusztal wrote:
> > This patch adds AES Galois Counter Mode test case for cryptodev
> > QAT tests. Test is performed with different buffer sizes, burst
> > size of 32 and 128b key. Test vectors are placed in
> > app/test/test_cryptodev_perf_vectors.h file.
> > 
> > This patch depends on the following patches/patchsets:
> > 
> > "app/test: fix linkage scope of gmac plaintext array"
> > (http://dpdk.org/dev/patchwork/patch/16023/)
> > 
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> 
> FYI,
> 
> My robot caught a build error when this patch applied.
> 
> 	--yliu
> 
> ---
> test_cryptodev.o:(.data+0x1be0): multiple definition of `gmac_plaintext'
> test_cryptodev_perf.o:(.data+0x4a0): first defined here
> collect2: error: ld returned 1 exit status

One more: it breaks 32 bit build.

---
/yeti/vm/ubuntu-initrd-16.04-i386-build/dpdk/app/test/test_cryptodev_perf.c: In function 'perf_AES_GCM':
/yeti/vm/ubuntu-initrd-16.04-i386-build/dpdk/app/test/test_cryptodev_perf.c:3187:10: error: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'uint64_t {aka long long unsigned int}' [-Werror=format=]
   printf("\n%u\t\t%6.2f\t%16.2f\t%8lu\t%10lu",
          ^
/yeti/vm/ubuntu-initrd-16.04-i386-build/dpdk/app/test/test_cryptodev_perf.c:3187:10: error: format '%lu' expects argument of type 'long unsigned int', but argument 6 has type 'uint64_t {aka long long unsigned int}' [-Werror=format=]
cc1: all warnings being treated as errors