From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 5136B569F
 for <dev@dpdk.org>; Fri, 23 Sep 2016 11:14:21 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga103.jf.intel.com with ESMTP; 23 Sep 2016 02:14:22 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.30,381,1470726000"; d="scan'208";a="1035103953"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162])
 by orsmga001.jf.intel.com with ESMTP; 23 Sep 2016 02:14:19 -0700
Date: Fri, 23 Sep 2016 17:14:48 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org, David Marchand <david.marchand@6wind.com>,
 "Tan, Jianfeng" <jianfeng.tan@intel.com>
Message-ID: <20160923091448.GB23158@yliu-dev.sh.intel.com>
References: <1474614646-23648-1-git-send-email-yuanhan.liu@linux.intel.com>
 <3786074.FTf50R74LC@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3786074.FTf50R74LC@xps13>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH] eal: remove single file segments related code
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Sep 2016 09:14:21 -0000

On Fri, Sep 23, 2016 at 10:50:06AM +0200, Thomas Monjalon wrote:
> 2016-09-23 15:10, Yuanhan Liu:
> > Commit c711ccb30987 ("ivshmem: remove library and its EAL integration")
> > removed ivshmem support, but seems David forgot to remove the another
> > piece of code: code for RTE_EAL_SINGLE_FILE_SEGMENTS, which is introduced
> > when ivshmem was firstly added.
> 
> It is not a mistake. We thought it is used by container use case.

I think no. It would help the container case a bit, but not too much I
would think, especially when the memory goes fragement.

Jianfeng, IIRC, you don't use that option for container case, right?

	--yliu