From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 23AFE2BB4 for ; Tue, 27 Sep 2016 06:15:33 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP; 26 Sep 2016 21:15:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,403,1470726000"; d="scan'208";a="13545581" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga006.fm.intel.com with ESMTP; 26 Sep 2016 21:15:28 -0700 Date: Tue, 27 Sep 2016 12:15:55 +0800 From: Yuanhan Liu To: Maxime Coquelin Cc: huawei.xie@intel.com, dev@dpdk.org, vkaplans@redhat.com, mst@redhat.com, stephen@networkplumber.org Message-ID: <20160927041555.GC25823@yliu-dev.sh.intel.com> References: <1474619303-16709-1-git-send-email-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1474619303-16709-1-git-send-email-maxime.coquelin@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v3] vhost: Add indirect descriptors support to the TX path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Sep 2016 04:15:34 -0000 On Fri, Sep 23, 2016 at 10:28:23AM +0200, Maxime Coquelin wrote: > + if (vq->desc[desc_indexes[i]].flags & VRING_DESC_F_INDIRECT) { > + desc = (struct vring_desc *)gpa_to_vva(dev, As mentioned before, this would break 32 bit OS build. It should be (struct vring_desc *)(uintptr_t)gpa_to_vva(...); I meant to fix this while apply, later I just realized you haven't updated the release note (sorry for the late notice). So would you mind send a new version, with the fix and release note update? FYI, the release note is at "doc/guides/rel_notes/" --yliu