From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: dev@dpdk.org, declan.doherty@intel.com
Subject: Re: [dpdk-dev] [PATCH] cryptodev: fix compilation error in SUSE 11 SP2
Date: Tue, 27 Sep 2016 09:45:21 +0200 [thread overview]
Message-ID: <20160927074521.GY17252@6wind.com> (raw)
In-Reply-To: <1474926635-13290-1-git-send-email-pablo.de.lara.guarch@intel.com>
On Mon, Sep 26, 2016 at 10:50:35PM +0100, Pablo de Lara wrote:
> This commit fixes following build error, which happens in SUSE 11 SP2,
> with gcc 4.5.1:
>
> In file included from lib/librte_cryptodev/rte_cryptodev.c:71:0:
> lib/librte_cryptodev/rte_cryptodev_pmd.h:76:7:
> error: flexible array member in otherwise empty struct
>
> Fixes: 347a1e037fd3 ("lib: use C99 syntax for zero-size arrays")
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Hmm, this error message does not seem related to your patch. Assuming a
similar error is caused by the original code, I think there is a more
important issue as the struct should not be empty. Can you check the
error?
> ---
> lib/librte_cryptodev/rte_cryptodev.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
> index 7fb5f6e..d19b378 100644
> --- a/lib/librte_cryptodev/rte_cryptodev.h
> +++ b/lib/librte_cryptodev/rte_cryptodev.h
> @@ -769,7 +769,7 @@ struct rte_cryptodev_sym_session {
> } __rte_aligned(8);
> /**< Public symmetric session details */
>
> - char _private[];
> + __extension__ char _private[0];
> /**< Private session material */
> };
>
> --
> 2.7.4
--
Adrien Mazarguil
6WIND
next prev parent reply other threads:[~2016-09-27 7:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 21:50 Pablo de Lara
2016-09-27 7:45 ` Adrien Mazarguil [this message]
2016-09-29 19:30 ` De Lara Guarch, Pablo
2016-09-30 8:33 ` Adrien Mazarguil
2016-10-05 2:31 ` De Lara Guarch, Pablo
2016-10-05 2:45 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
2016-10-05 8:51 ` Adrien Mazarguil
2016-10-06 21:00 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160927074521.GY17252@6wind.com \
--to=adrien.mazarguil@6wind.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).