From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sender163-mail.zoho.com (sender163-mail.zoho.com [74.201.84.163]) by dpdk.org (Postfix) with ESMTP id C7B4519F5 for ; Tue, 27 Sep 2016 20:32:42 +0200 (CEST) Received: from localhost (187.95.126.220 [187.95.126.220]) by mx.zohomail.com with SMTPS id 1475001160399702.2970045504283; Tue, 27 Sep 2016 11:32:40 -0700 (PDT) Date: Tue, 27 Sep 2016 15:32:37 -0300 From: Flavio Leitner To: Aaron Conole Cc: dpdk Message-ID: <20160927183237.GA27384@plex> References: <1474642051-9973-1-git-send-email-fbl@sysclose.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.0 (2016-08-17) Subject: Re: [dpdk-dev] [PATCH] eal: check cpu flags at init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Sep 2016 18:32:43 -0000 On Mon, Sep 26, 2016 at 11:43:37AM -0400, Aaron Conole wrote: > My only concern is whether this change would be considered ABI > breaking. I wouldn't think so, since it doesn't seem as though an > application would want to call this explicitly (and is spelled out as > such), but I can't be sure that it isn't already included in the > standard application API, and therefore needs to go through the change > process. I didn't want to change the original behavior more than needed. I think another patch would be necessary to change the whole EAL initialization because there's a bunch of rte_panic() there which aren't friendly with callers either. -- fbl