From: John Daley <johndale@cisco.com>
To: bruce.richardson@intel.com
Cc: dev@dpdk.org, John Daley <johndale@cisco.com>
Subject: [dpdk-dev] [PATCH 2/4] net/enic: fix segfault when restarting with fdir filters
Date: Thu, 29 Sep 2016 13:56:37 -0700 [thread overview]
Message-ID: <20160929205639.1175-2-johndale@cisco.com> (raw)
In-Reply-To: <20160929205639.1175-1-johndale@cisco.com>
When flow director filters where removed when an enic device is
stopped, the filters were freed but the pointer was not set to
NULL so the next stop would try to free them again.
Fixes: fefed3d1e62c ("enic: new driver")
Signed-off-by: John Daley <johndale@cisco.com>
---
drivers/net/enic/enic_clsf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/enic/enic_clsf.c b/drivers/net/enic/enic_clsf.c
index b251b7f..111b194 100644
--- a/drivers/net/enic/enic_clsf.c
+++ b/drivers/net/enic/enic_clsf.c
@@ -240,6 +240,7 @@ void enic_clsf_destroy(struct enic *enic)
vnic_dev_classifier(enic->vdev, CLSF_DEL,
&key->fltr_id, NULL);
rte_free(key);
+ enic->fdir.nodes[index] = NULL;
}
}
--
2.10.0
next prev parent reply other threads:[~2016-09-29 20:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 20:56 [dpdk-dev] [PATCH 1/4] net/enic: fix fdir usage with scattered Rx John Daley
2016-09-29 20:56 ` John Daley [this message]
2016-09-29 20:56 ` [dpdk-dev] [PATCH 3/4] net/enic: update VIC interface file John Daley
2016-09-29 20:56 ` [dpdk-dev] [PATCH 4/4] net/enic: extend fdir support for 1300 series adapters John Daley
2016-10-11 9:22 ` Ferruh Yigit
2016-10-11 9:25 ` John Daley (johndale)
2016-10-12 16:24 ` Bruce Richardson
2016-10-12 18:09 ` [dpdk-dev] [PATCH] net/enic: remove assert which causes compile error John Daley
2016-10-13 13:22 ` Bruce Richardson
2016-10-13 13:37 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160929205639.1175-2-johndale@cisco.com \
--to=johndale@cisco.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).