From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wes1-so1.wedos.net (wes1-so1-b.wedos.net [46.28.106.43]) by dpdk.org (Postfix) with ESMTP id 5E7D92A58 for ; Mon, 3 Oct 2016 15:15:01 +0200 (CEST) Received: from pcviktorin.fit.vutbr.cz (pcviktorin.fit.vutbr.cz [147.229.13.147]) by wes1-so1.wedos.net (Postfix) with ESMTPSA id 3snjFb0Ndcz8R9; Mon, 3 Oct 2016 15:14:58 +0200 (CEST) Date: Mon, 3 Oct 2016 15:12:11 +0200 From: Jan Viktorin To: David Marchand Cc: Shreyansh Jain , "dev@dpdk.org" , Thomas Monjalon Message-ID: <20161003151211.46824d64@pcviktorin.fit.vutbr.cz> In-Reply-To: <4e8b181f-8d46-f4b4-3821-a19f5c622ec1@nxp.com> References: <1472704915-13112-1-git-send-email-shreyansh.jain@nxp.com> <1474985551-14219-1-git-send-email-shreyansh.jain@nxp.com> <4e8b181f-8d46-f4b4-3821-a19f5c622ec1@nxp.com> Organization: RehiveTech MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1 0/4] Generalize PCI specific EAL function/structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Oct 2016 13:15:01 -0000 On Mon, 3 Oct 2016 11:07:43 +0530 Shreyansh Jain wrote: > Hi David, > > On Friday 30 September 2016 09:01 PM, David Marchand wrote: > > On Tue, Sep 27, 2016 at 4:12 PM, Shreyansh Jain wrote: > >> (I rebased these over HEAD 7b3c4f3) > >> > >> These patches were initially part of Jan's original series on SoC > >> Framework ([1],[2]). An update to that series, without these patches, > >> was posted here [3]. > >> > >> Main motivation for these is aim of introducing a non-PCI centric > >> subsystem in EAL. As of now the first usecase is SoC, but not limited to > >> it. > >> > >> 4 patches in this series are independent of each other, as well as SoC > >> framework. All these focus on generalizing some structure or functions > >> present with the PCI specific code to EAL Common area (or splitting a > >> function to be more userful). > > > > Those patches move linux specifics (binding pci devices using sysfs) > > to common infrastucture. > > We have no proper hotplug support on bsd, but if we had some common > > code we should at least try to make the apis generic. > > > > I am not sure if I understood your point well. Just to confirm - you are I don't clearly see the point, either. Jan > stating that the movement done in the patches might not suit BSD. > Probably you are talking about (Patch 3/4 and 4/4). > Is my understanding correct? > > So, movement to just Linux area is not enough? > I am not well versed with BSD way of doing something similar so if > someone can point it out, I can integrate that. (I will investigate it > at my end as well). > > This patchset makes the PCI->EAL movement *only* for Linux for sysfs > bind/unbind. (I should add this to cover letter, at the least). > > - > Shreyansh -- Jan Viktorin E-mail: Viktorin@RehiveTech.com System Architect Web: www.RehiveTech.com RehiveTech Brno, Czech Republic