From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 1AE4D374E for ; Fri, 7 Oct 2016 06:24:46 +0200 (CEST) Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 67E513F1E8; Fri, 7 Oct 2016 04:24:45 +0000 (UTC) Received: from redhat.com (vpn-58-198.rdu2.redhat.com [10.10.58.198]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with SMTP id u974OifS008691; Fri, 7 Oct 2016 00:24:44 -0400 Date: Fri, 7 Oct 2016 07:24:44 +0300 From: "Michael S. Tsirkin" To: Jason Wang Cc: dev@dpdk.org, huawei.xie@intel.com, yuanhan.liu@linux.intel.com, vkaplans@redhat.com Message-ID: <20161007042444.jbfoimmbuaxh2ped@redhat.com> References: <1475051112-5108-1-git-send-email-jasowang@redhat.com> <1475051112-5108-2-git-send-email-jasowang@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475051112-5108-2-git-send-email-jasowang@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 07 Oct 2016 04:24:45 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH V2 2/2] virtio: support IOMMU platform X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Oct 2016 04:24:46 -0000 On Wed, Sep 28, 2016 at 04:25:12PM +0800, Jason Wang wrote: > Negotiate VIRTIO_F_IOMMU_PLATFORM to have IOMMU support. > > Signed-off-by: Jason Wang > --- > Changes from v1: > - remove unnecessary NEED_MAPPING flag One thing we probably should do is enable this flag with VFIO but not with UIO or VFIO-noiommu. > --- > drivers/net/virtio/virtio_ethdev.h | 3 ++- > drivers/net/virtio/virtio_pci.h | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h > index 2ecec6e..04a06e2 100644 > --- a/drivers/net/virtio/virtio_ethdev.h > +++ b/drivers/net/virtio/virtio_ethdev.h > @@ -63,7 +63,8 @@ > 1u << VIRTIO_NET_F_CTRL_RX | \ > 1u << VIRTIO_NET_F_CTRL_VLAN | \ > 1u << VIRTIO_NET_F_MRG_RXBUF | \ > - 1ULL << VIRTIO_F_VERSION_1) > + 1ULL << VIRTIO_F_VERSION_1 | \ > + 1ULL << VIRTIO_F_IOMMU_PLATFORM ) Space before ) looks kind of ugly. > > /* > * CQ function prototype > diff --git a/drivers/net/virtio/virtio_pci.h b/drivers/net/virtio/virtio_pci.h > index 3430a39..0aa0015 100644 > --- a/drivers/net/virtio/virtio_pci.h > +++ b/drivers/net/virtio/virtio_pci.h > @@ -138,6 +138,7 @@ struct virtnet_ctl; > #define VIRTIO_RING_F_INDIRECT_DESC 28 > > #define VIRTIO_F_VERSION_1 32 > +#define VIRTIO_F_IOMMU_PLATFORM 33 > > /* > * Some VirtIO feature bits (currently bits 28 through 31) are > @@ -145,7 +146,7 @@ struct virtnet_ctl; > * rest are per-device feature bits. > */ > #define VIRTIO_TRANSPORT_F_START 28 > -#define VIRTIO_TRANSPORT_F_END 32 > +#define VIRTIO_TRANSPORT_F_END 34 > This seems unused. Drop it? > /* The Guest publishes the used index for which it expects an interrupt > * at the end of the avail ring. Host should ignore the avail->flags field. */ > -- > 2.7.4