From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 85F9056A8 for ; Fri, 7 Oct 2016 16:18:33 +0200 (CEST) Received: from cpe-2606-a000-111b-40ed-7aac-c0ff-fec2-933b.dyn6.twc.com ([2606:a000:111b:40ed:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1bsVyl-0006pr-EN; Fri, 07 Oct 2016 10:18:29 -0400 Date: Fri, 7 Oct 2016 10:18:18 -0400 From: Neil Horman To: Thomas Monjalon Cc: Shreyansh Jain , david.marchand@6wind.com, dev@dpdk.org Message-ID: <20161007141818.GA23455@hmsreliant.think-freely.org> References: <1475847187-28967-1-git-send-email-shreyansh.jain@nxp.com> <1776769.u7sKE3cfDQ@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1776769.u7sKE3cfDQ@xps13> User-Agent: Mutt/1.7.0 (2016-08-17) X-Spam-Score: -2.9 (--) X-Spam-Status: No Subject: Re: [dpdk-dev] [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Oct 2016 14:18:33 -0000 On Fri, Oct 07, 2016 at 03:51:44PM +0200, Thomas Monjalon wrote: > 2016-10-07 19:11, Shreyansh Jain: > > --- a/mk/internal/rte.compile-pre.mk > > +++ b/mk/internal/rte.compile-pre.mk > > @@ -87,7 +87,7 @@ endif > > PMDINFO_GEN = $(RTE_SDK_BIN)/app/dpdk-pmdinfogen $@ $@.pmd.c > > PMDINFO_CC = $(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@.pmd.o $@.pmd.c > > PMDINFO_LD = $(CROSS)ld $(LDFLAGS) -r -o $@.o $@.pmd.o $@ > > -PMDINFO_TO_O = if grep -q 'DRIVER_REGISTER_.*(.*)' $<; then \ > > +PMDINFO_TO_O = if grep 'EAL_REGISTER_.*(.*)' $<; then \ > > echo "$(if $V,$(PMDINFO_GEN), PMDINFO $@.pmd.c)" && \ > > $(PMDINFO_GEN) && \ > > echo "$(if $V,$(PMDINFO_CC), CC $@.pmd.o)" && \ > > > > --->8--- > > CC eal_pci_vfio.o > > PMDINFO eal_pci_vfio.o.pmd.c > > /bin/sh: 1: > > /home/shreyansh/build/DPDK/02_dpdk/x86_64-native-linuxapp-gcc/app/dpdk-pmdinfogen: > > not found > > /home/shreyansh/build/DPDK/02_dpdk/mk/internal/rte.compile-pre.mk:138: > > recipe for target 'eal_pci_vfio.o' failed > > --->8--- > > > > I don't think PMDINFO should be running on eal_pci_vfio file. Isn't it? > > Every files are scanned for the pattern. > > > Is it because EAL_REGISTER_* is matching EAL_REGISTER_TAILQ like macro > > as well? > > Probably. > That's another argument in favor of good prefixes. > I think you should use RTE_DRIVER_REGISTER_ or better, RTE_PMD_REGISTER_ Thats what we had, about 4 changes to this macro ago, and yes, that made alot more sense, to grep on a more complete version of the macro name to ensure a unique match. You might just look for the regex EAL_REGISTER_VDEV|EAL_REGISTER_PCI with grep -E Neil > > > > I am not very well versed with how PMDINFO is linking with the build > > system so any hints/insight into this would be really helpful. > > > > One I get more clarity on this, I will push a new version of this patch. > > Thanks >