From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 37E695599 for ; Sun, 9 Oct 2016 05:52:01 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP; 08 Oct 2016 20:52:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,316,1473145200"; d="scan'208";a="17656206" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga006.fm.intel.com with ESMTP; 08 Oct 2016 20:51:59 -0700 Date: Sun, 9 Oct 2016 11:52:51 +0800 From: Yuanhan Liu To: Dey Cc: mark.b.kavanagh@intel.com, stephen@networkplumber.org, dev@dpdk.org Message-ID: <20161009035251.GN1597@yliu-dev.sh.intel.com> References: <20160922135643.37636-1-sodey@sonusnet.com> <20160929203130.58712-1-sodey@sonusnet.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160929203130.58712-1-sodey@sonusnet.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v7] net/virtio: add set_mtu in virtio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Oct 2016 03:52:02 -0000 On Thu, Sep 29, 2016 at 04:31:30PM -0400, Dey wrote: > /* > * dev_ops for virtio, bare necessities for basic operation > */ > @@ -677,7 +685,6 @@ static const struct eth_dev_ops virtio_eth_dev_ops = { > .allmulticast_enable = virtio_dev_allmulticast_enable, > .allmulticast_disable = virtio_dev_allmulticast_disable, > + .mtu_set = virtio_mtu_set, > .dev_infos_get = virtio_dev_info_get, > .stats_get = virtio_dev_stats_get, > .xstats_get = virtio_dev_xstats_get, > -- > 2.9.3.windows.1 Your patch is malformed: I got an error while trying to apply it. patch: **** malformed patch at line 167: * dev_ops for virtio, bare necessities for basic operation Seems like the way you were generating the patch is wrong. Anyway, I applied it manually, with the "- frame_size" fix as well as few more minor coding style fixes. So applied to dpdk-next-virtio. --yliu