From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 4958F12A8 for ; Mon, 10 Oct 2016 14:56:41 +0200 (CEST) Received: from cpe-2606-a000-111b-40ed-7aac-c0ff-fec2-933b.dyn6.twc.com ([2606:a000:111b:40ed:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1bta89-0005UJ-3i; Mon, 10 Oct 2016 08:56:38 -0400 Date: Mon, 10 Oct 2016 08:56:24 -0400 From: Neil Horman To: Shreyansh Jain Cc: Thomas Monjalon , "david.marchand@6wind.com" , "dev@dpdk.org" Message-ID: <20161010125624.GA19423@hmsreliant.think-freely.org> References: <1475847187-28967-1-git-send-email-shreyansh.jain@nxp.com> <1776769.u7sKE3cfDQ@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.0 (2016-08-17) X-Spam-Score: -2.9 (--) X-Spam-Status: No Subject: Re: [dpdk-dev] [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Oct 2016 12:56:41 -0000 On Sat, Oct 08, 2016 at 01:00:59PM +0000, Shreyansh Jain wrote: > Hi Thomas, > > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Friday, October 07, 2016 7:22 PM > > To: Shreyansh Jain > > Cc: david.marchand@6wind.com; dev@dpdk.org > > Subject: Re: [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL > > > > 2016-10-07 19:11, Shreyansh Jain: > > > --- a/mk/internal/rte.compile-pre.mk > > > +++ b/mk/internal/rte.compile-pre.mk > > > @@ -87,7 +87,7 @@ endif > > > PMDINFO_GEN = $(RTE_SDK_BIN)/app/dpdk-pmdinfogen $@ $@.pmd.c > > > PMDINFO_CC = $(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@.pmd.o $@.pmd.c > > > PMDINFO_LD = $(CROSS)ld $(LDFLAGS) -r -o $@.o $@.pmd.o $@ > > > -PMDINFO_TO_O = if grep -q 'DRIVER_REGISTER_.*(.*)' $<; then \ > > > +PMDINFO_TO_O = if grep 'EAL_REGISTER_.*(.*)' $<; then \ > > > echo "$(if $V,$(PMDINFO_GEN), PMDINFO $@.pmd.c)" && \ > > > $(PMDINFO_GEN) && \ > > > echo "$(if $V,$(PMDINFO_CC), CC $@.pmd.o)" && \ > > > > > > --->8--- > > > CC eal_pci_vfio.o > > > PMDINFO eal_pci_vfio.o.pmd.c > > > /bin/sh: 1: > > > /home/shreyansh/build/DPDK/02_dpdk/x86_64-native-linuxapp-gcc/app/dpdk- > > pmdinfogen: > > > not found > > > /home/shreyansh/build/DPDK/02_dpdk/mk/internal/rte.compile-pre.mk:138: > > > recipe for target 'eal_pci_vfio.o' failed > > > --->8--- > > > > > > I don't think PMDINFO should be running on eal_pci_vfio file. Isn't it? > > > > Every files are scanned for the pattern. > > Sorry, I should have been clearer in my statement. > I meant, I didn't think eal_pci_vfio.o had anything of interest for the PMD tool and hence the mk files would have skipped over it in absence of a match. > I understand that PMDINFO would run on all files. > Thats incorrect, the Makefile does a REGEX search for appropriate registration macros that imply the need for pmdinfo to run. If its running on an inappropriate file its because your new macros inadvertently match the current regex, hence my suggestion that the regex should be tuned to be more specific Neil > > > > > Is it because EAL_REGISTER_* is matching EAL_REGISTER_TAILQ like macro > > > as well? > > > > Probably. > > That's another argument in favor of good prefixes. > > I think you should use RTE_DRIVER_REGISTER_ or better, RTE_PMD_REGISTER_ > > I thought of EAL_PMD_REGISTER_* but dropped it because for PCI_TABLE like macros, the name got really long (EAL_PMD_REGISTER_PCI_TABLE()). > Anyways, I will use RTE_PMD_REGISTER_* now and send another version. > > > > > > > I am not very well versed with how PMDINFO is linking with the build > > > system so any hints/insight into this would be really helpful. > > > > > > One I get more clarity on this, I will push a new version of this patch. > > > > Thanks > > - > Shreyansh >