From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <adrien.mazarguil@6wind.com>
Received: from mail-lf0-f47.google.com (mail-lf0-f47.google.com
 [209.85.215.47]) by dpdk.org (Postfix) with ESMTP id E211F2E41
 for <dev@dpdk.org>; Mon, 10 Oct 2016 15:19:35 +0200 (CEST)
Received: by mail-lf0-f47.google.com with SMTP id x79so126819990lff.0
 for <dev@dpdk.org>; Mon, 10 Oct 2016 06:19:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-disposition:in-reply-to;
 bh=2Jfb8iYgJR6AZwMQxit7TjKfU35wL8lDXIjUNRYUY18=;
 b=A4j48a1aX2rj/UrrwzbFjJc2RLnu/b/fh8KxpR7UqroxtMLfMuP8L73AqyWlPP3VLG
 ljkVPdHRsIzaEz/Vc4ortfXa4a3VWcdy0xRtCn2x+bFdsIoDnz46Huy1+pwLUvqPeUO1
 TxQNByyT6+TEKGlqs8THljvWY1lk8pja2PMQzNPm1lcmj8NCgBARR70nY7sEXvuS3OpW
 7TArELWLgUqEde6UoEJBzNL0qYbKL2LL0w+1HFj1bGd5ChFlSokH571EJODdGhkeVzGg
 w5zuK97XAWqkpxkOOWo9tarSW4vqz/r2Hool81dBv0iPPv8oq9niIIVHmNStmjwDWd50
 9nyg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:references
 :mime-version:content-disposition:in-reply-to;
 bh=2Jfb8iYgJR6AZwMQxit7TjKfU35wL8lDXIjUNRYUY18=;
 b=J7WwXnG46WU6ocRqmD+A2MP8Ltgm0WsfkkC2uiP3cgWzvQvi+r/CjwyPsFkKGhKGQE
 lT6cplHgiNV87/ti/+db4z2+/SoRiX9rDvBgtI6XwlGxJwsGtvvX5k1o5C0o29ow8OG7
 g9kBwXpoX5jWBHfYAu7minTYJZGSOgwEQbUjIFNDLG4hHpHwUxH4pzO5AXnA7/INmQks
 HfiTG48qLf9aL79TqIFBnzlbwCbWhb9G6pNg3pGMSKXTDqQTDYBnOGLVQg5bLv/LGgDs
 1zHdfN6vLuafWHSTTtekZaSljQZeNOGUAjudnlYQTuVM+D4rpGjBCcf51AwZdGR42psj
 ASEQ==
X-Gm-Message-State: AA6/9RnnDCWo061KjvrT3CzU73R2itx4HhQU/8LEmznuU99YToOl41joi0Cpipfud4ttDmzm
X-Received: by 10.194.39.101 with SMTP id o5mr29802663wjk.192.1476105575481;
 Mon, 10 Oct 2016 06:19:35 -0700 (PDT)
Received: from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.
 [82.239.227.177])
 by smtp.gmail.com with ESMTPSA id rk14sm40027153wjb.6.2016.10.10.06.19.33
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 10 Oct 2016 06:19:34 -0700 (PDT)
Date: Mon, 10 Oct 2016 15:19:27 +0200
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Message-ID: <20161010131927.GK17252@6wind.com>
References: <A2573D2ACFCADC41BB3BE09C6DE313CA01FDBBB5@PGSMSX103.gar.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <A2573D2ACFCADC41BB3BE09C6DE313CA01FDBBB5@PGSMSX103.gar.corp.intel.com>
Subject: Re: [dpdk-dev] [RFC v2] Generic flow
 director/filtering/classification API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Oct 2016 13:19:36 -0000

Hi Wei,

On Mon, Oct 10, 2016 at 09:42:53AM +0000, Zhao1, Wei wrote:
> Hi Adrien Mazarguil,
> 
> In your v2 version of rte_flow.txt , there is an action type RTE_FLOW_ACTION_TYPE_MARK,  but there is no definition of struct rte_flow_action_mark.
> And there is  an definition of struct rte_flow_action_id. Is it a typo or other usage?
> 
> Thank you.
> 
> struct rte_flow_action_id {
> 	uint32_t id; /**< 32 bit value to return with packets. */
> };

That is indeed a mistake, this struct should be named
"rte_flow_action_mark". I'll fix it for the next update, thanks.

-- 
Adrien Mazarguil
6WIND