From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 5F7636CBD for ; Tue, 11 Oct 2016 06:13:55 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP; 10 Oct 2016 21:13:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,476,1473145200"; d="scan'208";a="18260293" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga006.fm.intel.com with ESMTP; 10 Oct 2016 21:13:53 -0700 Date: Tue, 11 Oct 2016 12:14:45 +0800 From: Yuanhan Liu To: "Michael S. Tsirkin" Cc: Jason Wang , dev@dpdk.org, huawei.xie@intel.com, vkaplans@redhat.com Message-ID: <20161011041445.GK1597@yliu-dev.sh.intel.com> References: <1475051112-5108-1-git-send-email-jasowang@redhat.com> <1475051112-5108-2-git-send-email-jasowang@redhat.com> <20161007042444.jbfoimmbuaxh2ped@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161007042444.jbfoimmbuaxh2ped@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH V2 2/2] virtio: support IOMMU platform X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2016 04:13:55 -0000 On Fri, Oct 07, 2016 at 07:24:44AM +0300, Michael S. Tsirkin wrote: > On Wed, Sep 28, 2016 at 04:25:12PM +0800, Jason Wang wrote: > > Negotiate VIRTIO_F_IOMMU_PLATFORM to have IOMMU support. > > > > Signed-off-by: Jason Wang > > --- > > Changes from v1: > > - remove unnecessary NEED_MAPPING flag > > One thing we probably should do is enable this flag > with VFIO but not with UIO or VFIO-noiommu. Good suggestion. I think we could do that in another patch. > > --- > > drivers/net/virtio/virtio_ethdev.h | 3 ++- > > drivers/net/virtio/virtio_pci.h | 3 ++- > > 2 files changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h > > index 2ecec6e..04a06e2 100644 > > --- a/drivers/net/virtio/virtio_ethdev.h > > +++ b/drivers/net/virtio/virtio_ethdev.h > > @@ -63,7 +63,8 @@ > > 1u << VIRTIO_NET_F_CTRL_RX | \ > > 1u << VIRTIO_NET_F_CTRL_VLAN | \ > > 1u << VIRTIO_NET_F_MRG_RXBUF | \ > > - 1ULL << VIRTIO_F_VERSION_1) > > + 1ULL << VIRTIO_F_VERSION_1 | \ > > + 1ULL << VIRTIO_F_IOMMU_PLATFORM ) > > Space before ) looks kind of ugly. Yes, a bit. I will remove it while apply. > > #define VIRTIO_TRANSPORT_F_START 28 > > -#define VIRTIO_TRANSPORT_F_END 32 > > +#define VIRTIO_TRANSPORT_F_END 34 > > > > This seems unused. Drop it? Indeed. I will submit a patch to remove both (_START and _END). --yliu