From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f48.google.com (mail-lf0-f48.google.com [209.85.215.48]) by dpdk.org (Postfix) with ESMTP id C344F72FB for ; Tue, 11 Oct 2016 11:45:45 +0200 (CEST) Received: by mail-lf0-f48.google.com with SMTP id b75so32247578lfg.3 for ; Tue, 11 Oct 2016 02:45:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=CMB9/RA8Y7lfElx1VW0PsrXrgHmIsoqIDtsAzvMXnHM=; b=jT37nAy1AIUw1Hfa8EajY59J8c5FSkg3qo+KsZ6Mee/gzFxR3s93DSddOf1rDsQ6Ya JsU7N+GCBTe+C0jO5AjWYy82jR7J2u0aWfRrgLtenZkvrhGLoJQSpNlGypf9ZZFvqejI bzoZJFgsszsUX42iB4RHYOeMj6HE4ANAFftM05ONciItHplkCbG0UOPZM/BKDPMEUgR9 b+OV7rSU0Aey7u5dytfrHoojTw3J4yPMj3uwXwSrpURdA4UMdo8usppxmkJR0dBmbKgu 4mqjj1HIOhdjDvdW8TfEVc0RSbPxvp0nq+Dq7IOU+4lLCRV3r6O9iaTS9/RMQTB9YUAo 0YHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CMB9/RA8Y7lfElx1VW0PsrXrgHmIsoqIDtsAzvMXnHM=; b=RdKIYVhlKuGsqBdsfdbPUju7XDMswmgnAZ6IODk0NpyEX2ksQ3rUDKBhlR0NfHZU8C SyPoh6HpvZTvO+YV+mbKvukcJbmfS3GaSebpRCERsgW32JOMorPk8YpzzoO1nlJ88ac/ ko0d12z/15apqBA24zki1ulpFET0Ji8zByuNHZjgPw7G61+3O9WZQ0lOS8a9sLdU24MX SVTyO/UMAvKhM80khkc9W/tio4aeHVugXnEhlNljk8tFCoZfIW5ECfZmm6PDJYXUDh74 zdMvMko12wfKpoy/OSV/cVHJsJjMievqMKLrXxIZyq3PYsJxyI89GgKwFmXCkU4LGc0U dF4w== X-Gm-Message-State: AA6/9RlCMcI0ssQ8GtV/FedM6JYT780NCpdEfrlQLRsjRv6HiJoOLh5FtiKegctz6Ztm4q/I X-Received: by 10.25.149.203 with SMTP id x194mr1800882lfd.76.1476179145253; Tue, 11 Oct 2016 02:45:45 -0700 (PDT) Received: from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id v62sm616633lfa.44.2016.10.11.02.45.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Oct 2016 02:45:44 -0700 (PDT) Date: Tue, 11 Oct 2016 11:45:38 +0200 From: Adrien Mazarguil To: Olivier Gournet Cc: dev@dpdk.org Message-ID: <20161011094538.GO17252@6wind.com> References: <1475072658-29534-1-git-send-email-ogournet@corp.free.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475072658-29534-1-git-send-email-ogournet@corp.free.fr> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix init on secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2016 09:45:46 -0000 Hi Olivier, Secondary process support's got overlooked during this refactoring, thanks for the patch. However can you describe the issue you're addressing as part of the commit log? I think problems started when txq got mistakenly converted to primary_txq_ctrl in 21c8bb4928c9 ("net/mlx5: split Tx queue structure"), you may add a Fixes line for that one as well. Otherwise, this patch looks fine to me. On Wed, Sep 28, 2016 at 04:24:18PM +0200, Olivier Gournet wrote: > Fixes: 1d88ba171942 ("net/mlx5: refactor Tx data path") > > Signed-off-by: Olivier Gournet > --- > drivers/net/mlx5/mlx5_ethdev.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c > index 130e15d..6f39965 100644 > --- a/drivers/net/mlx5/mlx5_ethdev.c > +++ b/drivers/net/mlx5/mlx5_ethdev.c > @@ -1308,11 +1308,13 @@ mlx5_secondary_data_setup(struct priv *priv) > continue; > primary_txq_ctrl = container_of(primary_txq, > struct txq_ctrl, txq); > - txq_ctrl = rte_calloc_socket("TXQ", 1, sizeof(*txq_ctrl), 0, > + txq_ctrl = rte_calloc_socket("TXQ", 1, sizeof(*txq_ctrl) + > + primary_txq->elts_n * > + sizeof(struct rte_mbuf *), 0, > primary_txq_ctrl->socket); > if (txq_ctrl != NULL) { > if (txq_ctrl_setup(priv->dev, > - primary_txq_ctrl, > + txq_ctrl, > primary_txq->elts_n, > primary_txq_ctrl->socket, > NULL) == 0) { > -- > 2.1.4 -- Adrien Mazarguil 6WIND