From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 992806936 for ; Tue, 11 Oct 2016 16:57:37 +0200 (CEST) Received: from cpe-2606-a000-111b-40ed-7aac-c0ff-fec2-933b.dyn6.twc.com ([2606:a000:111b:40ed:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1btyUg-00071x-9j; Tue, 11 Oct 2016 10:57:31 -0400 Date: Tue, 11 Oct 2016 10:57:18 -0400 From: Neil Horman To: Thomas Monjalon Cc: Shreyansh Jain , "david.marchand@6wind.com" , dev@dpdk.org Message-ID: <20161011145718.GB31866@hmsreliant.think-freely.org> References: <1475847187-28967-1-git-send-email-shreyansh.jain@nxp.com> <20161011133824.GA31866@hmsreliant.think-freely.org> <2554688.6PDizipyct@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2554688.6PDizipyct@xps13> User-Agent: Mutt/1.7.0 (2016-08-17) X-Spam-Score: -2.9 (--) X-Spam-Status: No Subject: Re: [dpdk-dev] [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2016 14:57:37 -0000 On Tue, Oct 11, 2016 at 03:57:29PM +0200, Thomas Monjalon wrote: > 2016-10-11 09:38, Neil Horman: > > This also begs the question in my mind, is it really worth changing the macro? > > I really don't think it is. The registration macros are pretty descriptive as > > they stand, and have already changed 3 or 4 times in the last 6 months, which > > suggests to me that any change here is really just churn more than meaningful > > change. You can make the argument that the name might be more in line with the > > library its implemented in or what not, but in truth, its easy to understand > > what the macros do (in their previous or current incantations), and any change > > that just makes them the same as other macros in their naming is really more > > trouble than its worth. > > Neil, the long term goal is to stop having some identifiers which do not > start with RTE_ in our exported .h files. > I think it is a reasonable policy, for a library, to live in a well defined > namespace. > I don't disagree that a consistent namespace is a nice thing, only that we've had 3 changes to these macros in the last few months, none of which have really moved us toward that goal. At least we can agree that the EAL_ macro being proposed isn't the right thing to do regardless of motivation :) Neil