From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id F080C1C52 for ; Thu, 13 Oct 2016 15:22:19 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP; 13 Oct 2016 06:22:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,339,1473145200"; d="scan'208";a="1044187425" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.210.139]) by orsmga001.jf.intel.com with SMTP; 13 Oct 2016 06:22:17 -0700 Received: by (sSMTP sendmail emulation); Thu, 13 Oct 2016 14:22:16 +0025 Date: Thu, 13 Oct 2016 14:22:16 +0100 From: Bruce Richardson To: John Daley Cc: dev@dpdk.org Message-ID: <20161013132215.GA138296@bricha3-MOBL3> References: <20161012162442.GI104428@bricha3-MOBL3> <20161012180935.8366-1-johndale@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161012180935.8366-1-johndale@cisco.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] net/enic: remove assert which causes compile error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Oct 2016 13:22:20 -0000 On Wed, Oct 12, 2016 at 11:09:35AM -0700, John Daley wrote: > Remove an RTE_ASSERT which will not compile if enabled and is not needed. > > Fixes: a1f7c7b3b5b2 ("net/enic: extend fdir support for 1300 series adapters") > > Signed-off-by: John Daley > --- > Would have been nice if I caught this yesterday before you applied a1f7c7b3 :( > Since commit a1f7c7b3 has not been pulled into the dpdk.org mainline, I can still merge this commit into the origin one that has the bug. Unless you object, I shall do so now. /Bruce