From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 037A46CD1
 for <dev@dpdk.org>; Wed, 19 Oct 2016 11:24:04 +0200 (CEST)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by fmsmga105.fm.intel.com with ESMTP; 19 Oct 2016 02:24:04 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,513,1473145200"; d="scan'208";a="21151903"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.210.138])
 by fmsmga006.fm.intel.com with SMTP; 19 Oct 2016 02:24:01 -0700
Received: by  (sSMTP sendmail emulation); Wed, 19 Oct 2016 10:24:01 +0100
Date: Wed, 19 Oct 2016 10:24:01 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: "Mody, Rasesh" <Rasesh.Mody@cavium.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
 Sony Chacko <sony.chacko@qlogic.com>,
 Harish Patil <harish.patil@qlogic.com>,
 Rasesh Mody <rasesh.mody@qlogic.com>
Message-ID: <20161019092400.GB27816@bricha3-MOBL3.ger.corp.intel.com>
References: <20160930144515.1770-1-ferruh.yigit@intel.com>
 <12674be5-bed0-6e61-7506-b6bb19460c97@intel.com>
 <BLUPR0701MB1572EACD26B20F755DF81D009FD00@BLUPR0701MB1572.namprd07.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BLUPR0701MB1572EACD26B20F755DF81D009FD00@BLUPR0701MB1572.namprd07.prod.outlook.com>
Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?=
 =?iso-8859-1?Q?opment?= Ireland Ltd.
User-Agent: Mutt/1.7.1 (2016-10-04)
Subject: Re: [dpdk-dev] [PATCH] net/bnx2x: fix icc build error
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Oct 2016 09:24:05 -0000

On Mon, Oct 17, 2016 at 06:04:32PM +0000, Mody, Rasesh wrote:
> > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> > Sent: Monday, October 17, 2016 5:12 AM
> > 
> > On 9/30/2016 3:45 PM, Ferruh Yigit wrote:
> > > When bnx2x debug config enabled, icc (ICC) 17.0.0 20160721 gives the
> > > following compilation error:
> > >
> > > .../drivers/net/bnx2x/elink.c(6682):
> > > error #3656: variable "fw_ver1" may be used before its value is set
> > > 	PMD_DRV_LOG(DEBUG,
> > > 	^
> > >
> > > According logic in the code, this error is a false positive, but since
> > > this is not in the fast path, fixing compiler error by assigning
> > > initial value to variable.
> > >
> > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
<snip>
> 
> > Since this is an compilation fix, I believe it is good to have this in the release,
> > can you please review the patch?
> 
> Thanks!
> 
> Acked-by: Rasesh Mody <rasesh.mody@qlogic.com>
>  
Applied to dpdk-next-net/rel_16_11

/Bruce