* [dpdk-dev] [PATCH] net/enic: fix fdir UDP v4 source port mask
@ 2016-10-18 5:17 John Daley
2016-10-19 9:40 ` Bruce Richardson
0 siblings, 1 reply; 2+ messages in thread
From: John Daley @ 2016-10-18 5:17 UTC (permalink / raw)
To: bruce.richardson; +Cc: dev, John Daley
This fixes issue found by Coverity where a typo caused the flow director
UDP IPv4 source port mask to be assigned the destination port mask
supplied by the caller.
Coverity issue: 137860
Fixes: dfbd6a9cb504 ("net/enic: extend flow director support for 1300 series")
Signed-off-by: John Daley <johndale@cisco.com>
---
drivers/net/enic/enic_clsf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/enic/enic_clsf.c b/drivers/net/enic/enic_clsf.c
index d2413d7..53a7977 100644
--- a/drivers/net/enic/enic_clsf.c
+++ b/drivers/net/enic/enic_clsf.c
@@ -155,7 +155,7 @@ copy_fltr_v2(struct filter_v2 *fltr, struct rte_eth_fdir_input *input,
udp_val.src_port = input->flow.udp4_flow.src_port;
}
if (input->flow.udp4_flow.dst_port) {
- udp_mask.src_port = masks->dst_port_mask;
+ udp_mask.dst_port = masks->dst_port_mask;
udp_val.dst_port = input->flow.udp4_flow.dst_port;
}
--
2.10.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/enic: fix fdir UDP v4 source port mask
2016-10-18 5:17 [dpdk-dev] [PATCH] net/enic: fix fdir UDP v4 source port mask John Daley
@ 2016-10-19 9:40 ` Bruce Richardson
0 siblings, 0 replies; 2+ messages in thread
From: Bruce Richardson @ 2016-10-19 9:40 UTC (permalink / raw)
To: John Daley; +Cc: dev
On Mon, Oct 17, 2016 at 10:17:08PM -0700, John Daley wrote:
> This fixes issue found by Coverity where a typo caused the flow director
> UDP IPv4 source port mask to be assigned the destination port mask
> supplied by the caller.
>
> Coverity issue: 137860
>
> Fixes: dfbd6a9cb504 ("net/enic: extend flow director support for 1300 series")
>
> Signed-off-by: John Daley <johndale@cisco.com>
Applied to dpdk-next-net/rel_16_11
/Bruce
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-19 9:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-18 5:17 [dpdk-dev] [PATCH] net/enic: fix fdir UDP v4 source port mask John Daley
2016-10-19 9:40 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).