From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 1487F7E7F for ; Wed, 19 Oct 2016 11:42:47 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP; 19 Oct 2016 02:42:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,514,1473145200"; d="scan'208";a="181383940" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.210.138]) by fmsmga004.fm.intel.com with SMTP; 19 Oct 2016 02:42:26 -0700 Received: by (sSMTP sendmail emulation); Wed, 19 Oct 2016 10:42:25 +0100 Date: Wed, 19 Oct 2016 10:42:25 +0100 From: Bruce Richardson To: John Daley Cc: dev@dpdk.org Message-ID: <20161019094224.GH27816@bricha3-MOBL3.ger.corp.intel.com> References: <20161012211203.23250-1-johndale@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161012211203.23250-1-johndale@cisco.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.7.1 (2016-10-04) Subject: Re: [dpdk-dev] [PATCH 1/2] net/enic: fix crash on MTU update or rxq reconfigure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2016 09:42:48 -0000 On Wed, Oct 12, 2016 at 02:12:02PM -0700, John Daley wrote: > The incorrect completion queue corresponding to an RQ would be > freed if multiple Rx queues are in use and the MTU is changed, > or an Rx queue is released. This could lead to a segmentation fault > when the device is disabled or even in the Rx or Tx paths. > > The index of the completion queue corresponding to a RQ needed > to be adjusted after Rx scatter was introduced. > > Fixes: 856d7ba7ed22 ("net/enic: support scattered Rx") > > Signed-off-by: John Daley > Reviewed-by: Nelson Escobar > --- Patchset applied to dpdk-next-net/rel_16_11 /Bruce