From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 1A7D16936 for ; Wed, 19 Oct 2016 12:05:56 +0200 (CEST) Received: by mail-wm0-f43.google.com with SMTP id f193so49975552wmg.1 for ; Wed, 19 Oct 2016 03:05:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JNSyfzU+Ox/xvtsIpS1SRF8GkqPqsf64tAxEOhuYV6g=; b=CxBklZGUb92opzkAM7HKHZnjDpiPQtmIQxmMtSudco6DN2SwmX+zmYpKhkbtXzSu4R R8VOEvRzSYxQFHZ5sJ/LGMGLwkCJaBTVNkUTouFI/h9V3w23qpr8Y+EkJ+Q3G0/4b5/Y kZXFirVaugMRa0sdTCXODCw59B2C1ujOFHGUpaXCz5JPBqZW9smps6LP3OS1wlCzrMkW JDzl/hZ68/NTxGFdLu43Y47BgkgWdmzIEWIw+VYaBTZgHmRA+b00UksSU7mQcNfwMQEj o9E39ADUIwnccSk01hF5rcb3tAdSxuDRHar1I9T1d89wwWndPI3X7kg0U9kFjWx++QMv 7rqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JNSyfzU+Ox/xvtsIpS1SRF8GkqPqsf64tAxEOhuYV6g=; b=nOB0V9ebJuyBB/ZJywbJuGDdim3XoccB6NPXuevwEoJyF7qruD6acuYIxdgJ96bSfF hrNc+9Ew+W6H1fpltyuTveEGsOwxzAQf7eqnL8QcC0roaKAfBV7UkHsXJ73jZDa8Mlw7 yRMyhDBiQIrCJk1tLRSamLNUpzxalbR1LSS/nd3jM8XorFpUj/dnvKzPDv/LWbasDlma 1lSEAPYgl7hA+kbpaTz3HC1dLz1ZE8MZUWI2ef4bM/7EIhl5lQQRn0r5cIP/4V2XVonQ Gd+D0/CNROES6I7GBErdbwOc0V7h/pqZpRykf1jqh+C2+YVdNaNinZY0yWT0vM48IpHh vEWg== X-Gm-Message-State: AA6/9RmjdiBh16EQKYYpVzgYqltV6cBSXeu36oGpUUahlShPjao19nb/b7AAPa/15raE2mZd X-Received: by 10.194.28.166 with SMTP id c6mr4650460wjh.40.1476871555832; Wed, 19 Oct 2016 03:05:55 -0700 (PDT) Received: from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id z79sm4175868wmz.0.2016.10.19.03.05.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Oct 2016 03:05:55 -0700 (PDT) Date: Wed, 19 Oct 2016 12:05:48 +0200 From: Adrien Mazarguil To: Bruce Richardson Cc: Ferruh Yigit , Olivier Gournet , dev@dpdk.org, Nelio Laranjeiro Message-ID: <20161019100548.GD5733@6wind.com> References: <1475072658-29534-1-git-send-email-ogournet@corp.free.fr> <1476708993-62820-1-git-send-email-ogournet@corp.free.fr> <20161017141859.GB5733@6wind.com> <20161019093147.GD27816@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161019093147.GD27816@bricha3-MOBL3.ger.corp.intel.com> Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix init on secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2016 10:05:56 -0000 On Wed, Oct 19, 2016 at 10:31:48AM +0100, Bruce Richardson wrote: > On Mon, Oct 17, 2016 at 04:18:59PM +0200, Adrien Mazarguil wrote: > > On Mon, Oct 17, 2016 at 02:52:39PM +0100, Ferruh Yigit wrote: > > > Hi Adrien, > > > > > > On 10/17/2016 1:56 PM, Olivier Gournet wrote: > > > > Fixes: 1d88ba171942 ("net/mlx5: refactor Tx data path") > > > > Fixes: 21c8bb4928c9 ("net/mlx5: split Tx queue structure") > > > > > > > > Signed-off-by: Olivier Gournet > > > > > > According your comment on previous version of it, I think you have your > > > Ack on this patch, but can you please confirm? > > > > Yes it's fine, thanks. > > > > Acked-by: Adrien Mazarguil > > > > -- > While this patch is acked, I'd still like a bit of detail in the commit > message describing what the problem is and how the patch fixes it. The > Chuck Norris approach of trying to stare down the code until it tells > me just isn't working for me today! :-) > > Adrien or Olivier, if you can supply a brief description of what this > patch is doing and why I'll add it to the commit log on apply. *cough* this patch restores the original behavior of not causing a secondary process to segfault during init. Seriously, one needs to look at mlx5_secondary_data_setup() in both commits to really understand what happened, my suggestion for a commit log: The changes introduced by these commits made secondaries attempt to reinitialize the TX queue structures of the primary instead of their own, for which they also do not allocate enough memory, leading to crashes. -- Adrien Mazarguil 6WIND