From: Neil Horman <nhorman@tuxdriver.com>
To: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] Red Hat 6.5 compilation failure
Date: Mon, 31 Oct 2016 10:16:30 -0400 [thread overview]
Message-ID: <20161031141630.GB15205@hmsreliant.think-freely.org> (raw)
In-Reply-To: <20161031104318.GC4823@autoinstall.dev.6wind.com>
On Mon, Oct 31, 2016 at 11:43:18AM +0100, Nélio Laranjeiro wrote:
> Hi all,
>
> Am facing an issue with compilation on redhat 6.5 of DPDK v16.11-rc2,
> compilation fails with:
>
> cc1: warnings being treated as errors
> /root/dpdk/drivers/net/i40e/i40e_ethdev_vf.c: In function ‘i40evf_dev_interrupt_handler’:
> /root/dpdk/drivers/net/i40e/i40e_ethdev_vf.c:1391: error: dereferencing pointer ‘v_msg’ does break strict-aliasing rules
> /root/dpdk/drivers/net/i40e/i40e_ethdev_vf.c:1397: error: dereferencing pointer ‘v_msg’ does break strict-aliasing rules
> /root/dpdk/drivers/net/i40e/i40e_ethdev_vf.c:1398: error: dereferencing pointer ‘v_msg’ does break strict-aliasing rules
> /root/dpdk/drivers/net/i40e/i40e_ethdev_vf.c:1376: note: initialized from here
>
>
> cc1: warnings being treated as errors
> /root/dpdk/drivers/net/bnxt/bnxt_hwrm.c: In function ‘bnxt_hwrm_func_driver_unregister’:
> /root/dpdk/drivers/net/bnxt/bnxt_hwrm.c:105: error: dereferencing pointer ‘req’ does break strict-aliasing rules
> /root/dpdk/drivers/net/bnxt/bnxt_hwrm.c:66: note: initialized from here
>
>
> cc1: warnings being treated as errors
> /root/dpdk/drivers/net/qede/base/ecore_mcp.c: In function ‘ecore_mcp_nvm_rd_cmd’:
> /root/dpdk/build/include/rte_memcpy.h:740: error: array subscript is above array bounds
> /root/dpdk/drivers/net/qede/base/ecore_mcp.c: In function ‘ecore_mcp_nvm_wr_cmd’:
> /root/dpdk/build/include/rte_memcpy.h:740: error: array subscript is above array bounds
> At top level:
> cc1: error: unrecognized command line option "-Wno-maybe-uninitialized"
> cc1: error: unrecognized command line option "-Wno-maybe-uninitialized"
> cc1: error: unrecognized command line option "-Wno-maybe-uninitialized"
> cc1: error: unrecognized command line option "-Wno-maybe-uninitialized"
> cc1: error: unrecognized command line option "-Wno-maybe-uninitialized"
> cc1: error: unrecognized command line option "-Wno-maybe-uninitialized"
> cc1: error: unrecognized command line option "-Wno-maybe-uninitialized"
> cc1: error: unrecognized command line option "-Wno-maybe-uninitialized"
> cc1: error: unrecognized command line option "-Wno-maybe-uninitialized"
> cc1: error: unrecognized command line option "-Wno-maybe-uninitialized"
> cc1: error: unrecognized command line option "-Wno-maybe-uninitialized"
> cc1: error: unrecognized command line option "-Wno-maybe-uninitialized"
> cc1: error: unrecognized command line option "-Wno-maybe-uninitialized"
> cc1: error: unrecognized command line option "-Wno-maybe-uninitialized"
>
> In doc/guides/rel_notes/supported_os.rst we still support
> "Red Hat Enterprise Linux 6.5".
>
Most of these errors stems from the fact that in i40e there is alot of casting
from structs which lay out data in typed members to structs which have flat
memory buffers, which can cause problems if the alignment of the former isn't
what you expect. You can disable strict aliasing if you want, but its a much
better idea to fix it properly.
The subscript above array options is pretty straightforward. rte_memcpy has
a case statement that blocks memory copies to be more efficient. I would
presume that there is a call site for a ecore read operation where the buffer
array is smaller than the number of bytes copied, and the compiler noticed.
> Do we still want to support it, or should we update the documentation to
> remove it?
>
I think support probably doesn't matter, but regardless of that decision, you
should likely look a bit more closely at these errors.
Neil
> Regards,
>
> --
> Nélio Laranjeiro
> 6WIND
>
prev parent reply other threads:[~2016-10-31 14:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-31 10:43 Nélio Laranjeiro
2016-10-31 11:27 ` Thomas Monjalon
2016-10-31 14:16 ` Neil Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161031141630.GB15205@hmsreliant.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).