From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id DF7342A5F for ; Wed, 2 Nov 2016 16:56:10 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id n67so46330557wme.1 for ; Wed, 02 Nov 2016 08:56:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=d1BtAIKLmcWEIn1opat59SDsSwKlGH/H+nvK2qlqWD0=; b=NQdoLYg+PYSRTJrcmh+iVfS3AJUce2y/77ZKICNb3iv1FlMLNHBCR/STidxPRX/MLg dGgU3EEYY7wgFFu5HkXEQ0Vwc5fmHya5t52RnmYNL9IWEIDX/l20jHKs+7w38jwLAFLU VUJBZO0NFUSTKSz/KzeV0K0VlxvYCnTZFh3Txf38CeB0aCDEOrRg1l+nCRHuiaTN3VLM CyvD/MTBiwiIadUMEB4lkFwdhSpglcEy0X4o16D/oWVcnGH0YiVE4dDT8IBRTm6sE3LP Pm6oc3Yu+343KLpDoCRqjZqQ1nOvO6Bb2+L+pJDBMOSk/vbg3t4l2srpAUUHs4eqEbC3 pbAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=d1BtAIKLmcWEIn1opat59SDsSwKlGH/H+nvK2qlqWD0=; b=U6Ib9RsWjaEUqMPtNGaE/+LMPMY1brhAEJEm3sc/jhFJIjn4tLM3huukAol/ql1Zvd 75YoG4sZzTty/UlIvpn3TUPuuwO1s4CU73xHpajciAEtk3CWOgk/W7vP4S0K5+TTtFfA zqVPYUkAbjwJESL82XQP74Hh4yRyLyPz544W38gSfxssmOPQi1pdai78GGaAAeBs6UH7 VDHb1VpHVP2CT9qDjNjk5YWDCTnEVte0Y8Hh+F15Q6o8G1qI8qTuPbPoYFDjWdRD07Ok VTiWcLgHRCqRN5ZRjJ0mW++lUDyX+X8ES4wfamtEIWsmoZsXIX24bGg/katTQrPau57D ggGQ== X-Gm-Message-State: ABUngvffMRWytA7jj+SiJcYAnukMOyDsZEknQ9kmpGlWVD6oRASW1oz38zhoTm9FrPDTJZ+w X-Received: by 10.28.214.84 with SMTP id n81mr3504262wmg.120.1478102170363; Wed, 02 Nov 2016 08:56:10 -0700 (PDT) Received: from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id h10sm3461309wje.48.2016.11.02.08.56.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Nov 2016 08:56:09 -0700 (PDT) Date: Wed, 2 Nov 2016 16:56:03 +0100 From: Adrien Mazarguil To: Elad Persiko Message-ID: <20161102155602.GF5733@6wind.com> References: <1477988007-26141-1-git-send-email-eladpe@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477988007-26141-1-git-send-email-eladpe@mellanox.com> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix wrong use of vector instruction X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Nov 2016 15:56:11 -0000 On Tue, Nov 01, 2016 at 08:13:27AM +0000, Elad Persiko wrote: > Constraint alignment was not respected in Tx. > > Fixes: 1d88ba171942 ("net/mlx5: refactor Tx data path") > > Signed-off-by: Elad Persiko > --- > drivers/net/mlx5/mlx5_rxtx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c > index 21164ba..ba8e202 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.c > +++ b/drivers/net/mlx5/mlx5_rxtx.c > @@ -309,7 +309,7 @@ mlx5_tx_dbrec(struct txq *txq) > *txq->qp_db = htonl(txq->wqe_ci); > /* Ensure ordering between DB record and BF copy. */ > rte_wmb(); > - rte_mov16(dst, (uint8_t *)data); > + memcpy(dst, (uint8_t *)data, 16); > txq->bf_offset ^= (1 << txq->bf_buf_size); > } > > @@ -449,7 +449,7 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n) > wqe->eseg.mss = 0; > wqe->eseg.rsvd2 = 0; > /* Start by copying the Ethernet Header. */ > - rte_mov16((uint8_t *)raw, (uint8_t *)addr); > + memcpy((uint8_t *)raw, ((uint8_t *)addr), 16); > length -= MLX5_WQE_DWORD_SIZE; > addr += MLX5_WQE_DWORD_SIZE; > /* Replace the Ethernet type by the VLAN if necessary. */ > -- > 1.8.3.1 Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND