From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 63F722BA5 for ; Fri, 4 Nov 2016 02:50:19 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP; 03 Nov 2016 18:50:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,589,1473145200"; d="scan'208";a="27347496" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by orsmga005.jf.intel.com with ESMTP; 03 Nov 2016 18:50:17 -0700 Date: Fri, 4 Nov 2016 09:51:16 +0800 From: Yuanhan Liu To: Maxime Coquelin Cc: dev@dpdk.org, Ilya Maximets Message-ID: <20161104015116.GT16751@yliu-dev.sh.intel.com> References: <1478189400-14606-1-git-send-email-yuanhan.liu@linux.intel.com> <1478189400-14606-4-git-send-email-yuanhan.liu@linux.intel.com> <3dcee423-4cad-3de2-2593-51415d8e8d7d@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3dcee423-4cad-3de2-2593-51415d8e8d7d@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 3/8] net/virtio: simplify queue allocation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Nov 2016 01:50:22 -0000 On Thu, Nov 03, 2016 at 09:48:03PM +0100, Maxime Coquelin wrote: > > > On 11/03/2016 05:09 PM, Yuanhan Liu wrote: > >Let rxq/txq/cq be the union field of the virtqueue struct. This would > >simplifies the vq allocation a bit: we don't need calculate the vq_size > >any more based on the queue time. > s/time/type/ ? Oops... will fix it. Thanks. --yliu > > > >Signed-off-by: Yuanhan Liu > >--- > > drivers/net/virtio/virtio_ethdev.c | 18 +++++++----------- > > drivers/net/virtio/virtqueue.h | 7 +++++++ > > 2 files changed, 14 insertions(+), 11 deletions(-) > > Other than that: > Reviewed-by: Maxime Coquelin > > Thanks, > Maxime