From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id D24345680 for ; Thu, 17 Nov 2016 11:37:52 +0100 (CET) Received: by mail-wm0-f54.google.com with SMTP id t79so135791076wmt.0 for ; Thu, 17 Nov 2016 02:37:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eHW5jZO4Lb4FI9jtHUoR4thF4uuuhQNrgql+Sat2mps=; b=2OGm41VnK2cfHC8ijxG5NfAquqKvpX2zO46GgzKa/YkoYuKXWVoV1ysVrtpSNDvY7X MucOEzqVNPEIUs6fgu7CMudTHSImroTF9hgoE3h9NgPM9AGDk/tqinI2Ud8PAr3Nf7rZ DsluzK1GwytDoYm+90cwg/bstGuPUb0gMQxb0WEVMXcxLs1hzwYe3jYkvYC0Y6dA3Hd9 L9YIdTm5etGcDksmdQJkCnISlx1e6AD5KrUk9y5ToNDyg81MUxfl2j+cx5m275cpn6xL 8ffHK+YCzd3mt0bfXKiyTSmwTQfHI5xVOWmFOtZhvU7wL5ggZltWyA8dX2tqcLjDaFOE m3Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eHW5jZO4Lb4FI9jtHUoR4thF4uuuhQNrgql+Sat2mps=; b=Z1CrsSSNACQYRZXnHdpM92rZwY3pKjjIcoWKZWtWcQWNZaGAk1ZxZpb1bcmujDkbX0 8jcDfaaI88FVrbjht41BwmSShkFQGWtgtoFxElqei5TTEFikOD/rGVEZB3vm2p8VeNCS qumRUZ6dF5yBcUj+W1kXzCw1asvFqPjkWNU6TDSVdQHJd4EpKO7oyC1IJTOgi6Uatm/Y 15uLKKsS8B2/jQfoZ2AXhaYz+kKTwwZYu5hiPW5kBpJzacMC6LlUznF92FddH42kR/J6 otGzhWk9fShRbmBYS9vLA3rQlfowyoEdSBVvUzucNrAYmVY7hGLoCQQmBY/HKD7jfjt9 phAA== X-Gm-Message-State: ABUngvdYtFoz4IcEA+FT3zobAf3HqwBxwx3qXCwWlfnyedBs9A8ORI6t+a4wvnBS+I5NKJeC X-Received: by 10.28.138.135 with SMTP id m129mr3121707wmd.36.1479379072571; Thu, 17 Nov 2016 02:37:52 -0800 (PST) Received: from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id i10sm2532763wjd.15.2016.11.17.02.37.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Nov 2016 02:37:51 -0800 (PST) Date: Thu, 17 Nov 2016 11:37:40 +0100 From: Adrien Mazarguil To: Nelio Laranjeiro Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <20161117103740.GA4729@6wind.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH 1/3] net/mlx5: fix leak when starvation occurs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Nov 2016 10:37:53 -0000 On Thu, Nov 17, 2016 at 10:49:54AM +0100, Nelio Laranjeiro wrote: > The list of segments to free was wrongly manipulated ending by only freeing > the first segment instead of freeing all of them. The last one still > belongs to the NIC and thus should not be freed. > > Fixes: a1bdb71a32da ("net/mlx5: fix crash in Rx") > > CC: stable@dpdk.org > Reported-by: Liming Sun > Signed-off-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5_rxtx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c > index beff580..9bd4d80 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.c > +++ b/drivers/net/mlx5/mlx5_rxtx.c > @@ -1312,10 +1312,10 @@ mlx5_rx_burst(void *dpdk_rxq, struct rte_mbuf **pkts, uint16_t pkts_n) > } > while (pkt != seg) { > assert(pkt != (*rxq->elts)[idx]); > - seg = NEXT(pkt); > + rep = NEXT(pkt); > rte_mbuf_refcnt_set(pkt, 0); > __rte_mbuf_raw_free(pkt); > - pkt = seg; > + pkt = rep; > } > break; > } > -- > 2.1.4 Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND