From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 7AEC95687 for ; Thu, 17 Nov 2016 11:38:19 +0100 (CET) Received: by mail-wm0-f51.google.com with SMTP id g23so301745926wme.1 for ; Thu, 17 Nov 2016 02:38:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YgVcX2k3oBCWeAS+HdwdvKhQKUtK8mXNEtI66WH67O4=; b=cuAmS7i0F4MCz+MYzkX1a8Z6bNFUvuhaTIzhQnzQ39mH598Cj4jiEn9xyrLPQJ7Vzp n7pypXRc0CNI+9Tz25JyvWMGS8mgruYKCeakj+K6bJ638QLfqCykbNSNXjWCajSbFpsX f0bKvAuZoIE0/9UoFcAA0fplIkCZ+UCIZtm0BARE5Pcf3uz9fu1FWcdzr3NyVlef/oui YnXj0nNlq4S7E23iWOAYDlYmuZ/AVkg0CcA5J7kHajFIGDT5oC0Msp3FkCf46NUfmduZ CAjTwY+vyui1G91u+BNessnkpnRUUecPkM24ooReHO2JgWJ8pgI9XF3q0UIyHcxfyFSO nmTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YgVcX2k3oBCWeAS+HdwdvKhQKUtK8mXNEtI66WH67O4=; b=RQGGZtdQYgkK3ewZcdlTN9ZlGqh7uEbfyYJvQeIxuhJVOJLgvgquFwalbKgiQPUcfE CMn+TP60XiTq1ws79Hw2DwmiDRMFzZW9pU1P1idcyAUi6bdxHMh8itQlC8VQsk12/8qY FFcvQt5pVYqTseafmO1sXC4NPt5jZ6SefEWwU2vYSz9Fvzllr5v9Bqt2Fuj9UGoMrxj7 ocOqRwjMFWOb634mBbFQbiEzIWxLVL35ZhG7+ayyEvx4OymagBrMEis+99rq17VSecIj haW3aKpozCb/59oVRDRPxcF6CxJM7+M+57SWw6Fuyy1eCmo6LwlLErqFSXxDMzZ76U+D JK5g== X-Gm-Message-State: ABUngvfgxe/immIu7wD0agBSPfK9aKSUKCziN/P0fl2LMIMbTWEOX7Isg00Ye+9+12AVt5HY X-Received: by 10.28.213.133 with SMTP id m127mr3612671wmg.90.1479379098761; Thu, 17 Nov 2016 02:38:18 -0800 (PST) Received: from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id l67sm14840208wmf.20.2016.11.17.02.38.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Nov 2016 02:38:17 -0800 (PST) Date: Thu, 17 Nov 2016 11:38:11 +0100 From: Adrien Mazarguil To: Nelio Laranjeiro Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <20161117103811.GB4729@6wind.com> References: <92fae1c8490a9dfa782bbd62bac21076832d4cee.1479376117.git.nelio.laranjeiro@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <92fae1c8490a9dfa782bbd62bac21076832d4cee.1479376117.git.nelio.laranjeiro@6wind.com> Subject: Re: [dpdk-dev] [PATCH 2/3] net/mlx5: fix wrong htons X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Nov 2016 10:38:19 -0000 On Thu, Nov 17, 2016 at 10:49:55AM +0100, Nelio Laranjeiro wrote: > Completion queue entry data uses network endian, to access them we should use > ntoh*(). > > Fixes: c305090bbaf8 ("net/mlx5: replace countdown with threshold for Tx completions") > > CC: stable@dpdk.org > Reported-by: Liming Sun > Signed-off-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5_rxtx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c > index 9bd4d80..04860bb 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.c > +++ b/drivers/net/mlx5/mlx5_rxtx.c > @@ -201,7 +201,7 @@ txq_complete(struct txq *txq) > } while (1); > if (unlikely(cqe == NULL)) > return; > - wqe = &(*txq->wqes)[htons(cqe->wqe_counter) & > + wqe = &(*txq->wqes)[ntohs(cqe->wqe_counter) & > ((1 << txq->wqe_n) - 1)].hdr; > elts_tail = wqe->ctrl[3]; > assert(elts_tail < (1 << txq->wqe_n)); > -- > 2.1.4 Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND