From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0076.outbound.protection.outlook.com [104.47.40.76]) by dpdk.org (Postfix) with ESMTP id 8F7662C4B for ; Fri, 25 Nov 2016 05:18:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=+eyP2TCHLDo7021T6W5pb0gJRT/zkI6mb/0n4Ax7LV8=; b=g+JEBlG+Lef12VIZ2yhMpTG4bdYGSm2Ga4gXMj/WL+VpK5JUcyka+G7fFGXkSSwjZ1OMqpKIsK6mMu0RD/4uNHxM+n8IWtQcUiBhAhYYVJafHv7TBkOp/pnxxCMU8SjoGPEuYm0W2ONlfzBao+3/li76ykmoI5gBtB00hOJD4/c= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.localdomain (50.254.132.37) by BLUPR0701MB1715.namprd07.prod.outlook.com (10.163.85.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.707.6; Fri, 25 Nov 2016 04:17:56 +0000 Date: Fri, 25 Nov 2016 09:47:51 +0530 From: Jerin Jacob To: Thomas Monjalon CC: , , , , Message-ID: <20161125041750.GA18469@localhost.localdomain> References: <1479447902-3700-1-git-send-email-jerin.jacob@caviumnetworks.com> <1479447902-3700-3-git-send-email-jerin.jacob@caviumnetworks.com> <4871697.UraAQdum7A@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <4871697.UraAQdum7A@xps13> User-Agent: Mutt/1.7.1 (2016-10-04) X-Originating-IP: [50.254.132.37] X-ClientProxiedBy: BY2PR02CA0061.namprd02.prod.outlook.com (10.141.216.51) To BLUPR0701MB1715.namprd07.prod.outlook.com (10.163.85.141) X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 2:wHTBTIip2UozjvdxnKa9GusysppaVS/i5DbNnwxltufFKB4gulWeY3kXjLcqjnbIlfxtNHi5GCykMrJObKEpa8W061fEl1PV+y5aH0kfFa4f03ZPvXd0fAggd/QO4Y4A97SNCjh+caPBrRQ+v2H6HgalLYmVZz6poWWLwWLmm4k=; 3:bAAKX0Pzs+HZodBbV1HIhATwLZ6oeNoN1sHGHFCSxhpu5gIeZA1VuqPx7EkwKqKDR8KwzuwRmRvhjI4YtPYOoDkjNeNuzQnz0gvz6SjssQgVeclEG/fAbEMmvNOvWZU0YsvBIMGm0fs6mJR9B4usKtpy6X+j3DebTRLPC1KQ2tc= X-MS-Office365-Filtering-Correlation-Id: 903da4a4-bac8-4d2c-c1b4-08d414ea08f2 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BLUPR0701MB1715; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 25:87SZLgC7J2pYuu5jwTCgzf0ROqjZh4ykKwl8LR+qQaXex4OLl1x7P4B8kvxdALqlxlN4eddzE02ELjpjeix6n06e/2StHMs1l9JAvRpISlmeDQPsA/arRUnalzvKmtwKjGmaukYZ6CB+h9WkNXYQgBZImFAyofB/hXEfBPgQN8LCuXXq324AhkAyefviZzgUnhl1fD87rU73QRqV/RMwkcnYREJctJQzWAW+2TjCDv+wzUGxOXT0xv4jfOK9j9PHNa0bbdki3mUddsJSMZu8gZQsYdLfzJBrpRLAz9bNK589JVpiJ6odnAY5vdlw+5dcZa8ym5lmG+EDg7+aH8JveueNGUfDFsdqMuBHRZXZkCzKeggXS4tfG9TmX30nSLySDlW8TW/dXKw/Pbz/ZgWoWuwZZYK7odYM5o6C/8uIsVGoFNjt5CwVMxFZTJCqL8PYxVfE0aS/nzI3hc8prkOQIfnC88DSAUG+ydToo4H4Sq3Ys7DnM5H8Jg4EpKzAg1xFQeImcOmzt7bdY9x9LnbY/bw6RzPOj3myJTQszyUattx0N5BZdtjrb3JZi6WvPJDsmWeT2sDWSPA6AWVdx3bCG9vj6whH+AYnzwKpZaMT1Gt9At1EAfBK0HDp+dLCQ1XQqqvJeCtNDgGxtTii04UncluWmdyXxoi/a8lO2xxHeG1PoItONQyOmEXm47AMwAK6aPHIHXYkYSnCs+iElJW0JtMr9CQrpUc3yNuEQATDTAyM99YJG4pph0UMLqXbzh+urQDZLs1FTsAF1to5ZYmQe7wxjHAWyRJ9YBCFMN9ETpA= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 31:lbVC0LPCiWynZw+z5h5fNNXqSw8/KjC0wVgX7AgtNnElSMEPqI7dc/9hly6UYQsA66R0qbXsJXG1D0Qg5gv8Pe2xJryoXDJ3RYsy1PPO+O76Vc64saFrgHnoWy/JExaMZqJuLoFz8hH9Rj+7O1wLTDAGw/yUwO9kEx4WE9byJpsHYqqszjRVEgiURByDKwgszOlMm+OZXEO+32FUqaSDyeBCdzctLlScsrEaNNYy5NSbU1dlpDyINCiUbDVPIrJtDzkMm3xZC0jp4JKQNhhT4w==; 20:r74gu6XKxM0bjvSp9si8G8x+GMfILEofnzyRavofz+7AprKQPMruVwSBnWGmpBWPCxQ6EwVpDpCxoF55p+t3jzLJ5Z0KrwRxFkID4G4EF5DPsAoVMXntl7gykWuc7DxVyp+vR+atqU5bNxlzBxGjjA3CTKYZZ1s7j/hDVc7HhnZnMCw7/mslogwmAO6EMRikOvCDUWmqPBvLLJ1frjRkoZ7e4stnwLXCY0KVhDmuO0S0epkr15yQT6Ym+mX7tO/A8S/LRddF8L8fcqmJ0MUn8NzjH0YCuNiyCQPb7P+lgCuhD1HvqqgKaHnb9QNVzyEisns5M8Iechbn5gDgfd44h75tPNd8ygxPfFrtAUXpzqeq+PIr43zeNUELvhpk4/B+nK2f2IOZMGJ8+g7dNW0qFWw6dWjEEtnQcdDWrvYJtG7HIX4VT6ahxittBvISb7lG1+QnlPQLtGJmU6g6+ipJKojU+udCE448BFxYji9VBuqIMOM8Hgc0R+0AE1KmNBOTIDPAhBd9idrCTDpX+moZnNoa0/0hyaSSIJbGvPGr2fcRpXSe42buLs5dVCCtOOmxra9lv9Z4Gg0v6paTYIx0peXzcu5aInj8JzJMM6bvOiw= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6045199)(6060326)(6040361)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6061324)(6041248)(20161123555025)(20161123564025)(20161123560025)(20161123562025); SRVR:BLUPR0701MB1715; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1715; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 4:pF9rAvNbSHVLt1WhH0IYiAJV1WZ3YAXpef+aJi0mM/cATlVAOiRJfL/hrqaY0VhyEc1cEP6lIcorg5EpgrVTQGzVr2GhGThtamHYF/leVV2FK5CylYD301rRwbEHInINcOeiKvlZUe4q0pSNmwFvZpmsl1XvrkTeDiFqwy+vtkLMOkfcIQog9/L+fl+2A2cY3ciOvACsIUbHbAdSsbXDuL0UrqFaZWH2xre0J3t/h1wT/GoPmzVkd3BmqvA3E0UEgdG2SWd4DBaXvgFtAw0j5wMuVJk5MLnVheqOVvH2mRR7LHmSDQlKszIOed4GVMKSF8o+XLTrmY1qGGU77dIfhfgLui9OLe0t0GrvH5Cd3/6F5MEDKreU9xnPk2NraWzuNua4frwL5jnf3hJFxXFyIkHC9HHhO/wO4fEnmzm03lUeXFnf0u7aw3CIGZ9XhgWfw1v4U0pBuGOcHXDkrTQLfOd2C0MOCyKHWbQAw9Mgqh+syIzku0OQNQkmW5DwvwEvA39Kn1fvexqwyiu3Y+4+7qOtNo6nyyaoaZqhBq8BwJMRUbibfAjtoXSoDNNuz3jixOVhGUvC4UCXzW4eut4BDSrAMlUbut5l4ZQN4oFbJwA= X-Forefront-PRVS: 01371B902F X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6069001)(6009001)(7916002)(377424004)(24454002)(189002)(199003)(6116002)(39380400001)(39410400001)(8666005)(46406003)(61506002)(68736007)(6666003)(77096005)(33656002)(7736002)(23726003)(9686002)(76176999)(106356001)(4326007)(92566002)(66066001)(189998001)(50986999)(2906002)(7846002)(305945005)(229853002)(3846002)(83506001)(47776003)(5660300001)(39450400002)(42882006)(101416001)(97756001)(105586002)(2950100002)(4001150100001)(1076002)(81166006)(81156014)(6916009)(42186005)(97736004)(38730400001)(8676002)(50466002)(4001350100001)(54356999)(110136003)(39400400001)(18370500001)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1715; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1715; 23:cD/AXMXrlrVXeNzd983WdKZKKUfVfJawfRdVyWF?= =?us-ascii?Q?JIW9M6C4ZJsjsQGhO5bxM2QTqYkEOGY5Ve4Py4dkSs3gUmdaq8t+RuQgtNHX?= =?us-ascii?Q?n0xqOj2myWWZyH0NOXQz87F9XZi/PuKCFAf9TjKXSBTsHP5DhSCI3kAgGH9p?= =?us-ascii?Q?lqdzaDWxFiLLI8RKUX1StwP7Xb/8unzHWt7zGRVHG5vRauehdyAsfjHsxa7q?= =?us-ascii?Q?BwGT8Yu3miNpYDzDPHmaCK2IcN52F/Xt2Lb9xPn8n8W294sPMtae17i/gHlG?= =?us-ascii?Q?8SdMrGv0Or2N8GUybrQWAXWA8c9vX+zA4oiYmNNhlpsOukP//aGr/7oTocJN?= =?us-ascii?Q?eOazkmYMTxnDqHWubQW+sf+LcCUy96Ysar67zfxTtwR7NdLEGqNZKSivgUzi?= =?us-ascii?Q?lBlv17SgagbJIp6FMCb0NzFZH2yZYS3YV3WKbhu8udqRkQIkgN84Le7Bvkag?= =?us-ascii?Q?DzD/5/i9x+t9L0L0UY5gQ/3z3z5iLzDJ/J1JPJ1p4j6zwV94ShhZyr9DuCxs?= =?us-ascii?Q?V4HwDEKRfH/5NrHeMN44Kb6ZTIyGiw8kWCUXjqTQrGl0yMoImTtxmBz04Xn3?= =?us-ascii?Q?36gyCTh/cV9Xqu+OiaPlJyeMXIlrrplVnwghSvqeYw+EcKcM9UhwhrokvicW?= =?us-ascii?Q?PGXZ1IODU7a7CkP8Mgs9YdmG7fecivbbV/t5h1gKivWYn6b4DDWYGhLdZhl8?= =?us-ascii?Q?75bVQchV9R7ECHpF1I1asSWE5D/fb8aubGr56OjoVek4PXqfUtGR+0W3ohdf?= =?us-ascii?Q?b1OoLkQj8LPpTWwEhZJ7/mIe6WQNiSGfTSoo+E2F9UcIutxcFKuoOzv9sbSw?= =?us-ascii?Q?4XDwlCd8Z0JT6kG/KuK+KSHzzsjQvLNcjce+0SKpKn2OrJca6xTp8/D8tk/H?= =?us-ascii?Q?J+rWOd/ssq07bKLDQPV7I242QOISfPBbxY08USZbfdTrr62bzaQvG2IOXC6N?= =?us-ascii?Q?LCql2e7gpQDoJU+NjmkB3Y/P+XYAOWXrWCn8ZEQ7xbiD9fkVrt8BMzaf7SZ9?= =?us-ascii?Q?RWDibT6oNtaDIJM5JLXRuA7NQp67c2wWtMNLmDRY+Hrh9bq+/r8n8QQzbgLr?= =?us-ascii?Q?jwhM/cjcH3KEAMsyUxzVi2w5aIFbN+O1vLUf7Gp7/t31saOVF0HCUGVMattR?= =?us-ascii?Q?C4EnFF2OwzGKkeVPEne2rNqUucQpbGazWK0Yq1X6QXWEMR0/x/EaLOL8iyNE?= =?us-ascii?Q?LyCRBOkSMBwamizYo132G8RCtP5JjNImpageBEn2glWlkHddaiV2zmv6FAPW?= =?us-ascii?Q?RVEi3myksC/s9yWte3rQtTKXQUJy9fMDbrEZDWy2CTPzdDnqE4IwNeUuKWZt?= =?us-ascii?Q?UsEfdV5P1dEtbCQW/ySGzbyJ73/TO7htArCyKov/ygzHXlfuvu4ag2Y+qjr0?= =?us-ascii?Q?bUFN/BN6KQvT+zQ1FbuJS23xQyjDSHI69We4Kc5ckZe5BN3j7w1S91PZQk2J?= =?us-ascii?Q?KChAcVjsJjFeSR37BGzi2H1Nkldg4JfU=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 6:r9tGB0qr1suZp8cVbHF6VBdGLZnggwc8zsSKA9rmbM5XXsZdSQcX5rmbFGHFIDVAiuzsMRhxzhBR64DFswZCCpq4xFUxKGdc/yA288EJViTwGfpqHHCU39GhKSmMBiLZHZyevwgT8bgc2C1TEYjuOt5geiNaY+yIOAu9sNFoBauzZj6NS5n8YQUNJ1PosRUVEFWiLiCWaV5atZFqEFIFMPVG1tuFi8fgcpKNLkY5gv+Wx+2mGg6t48zopt9tfOOBYnQXs5amHazGoU+IGxD6z2/GkufaDEbxaqZ4o92+nq8KrOszj8ENt/kQZU1dFv5QM1mn8w00EjsTTeZEXZeFdvs5sIN7zoFSB4hMOOw+RFA=; 5:ghjzFrrsa3/a2Ojy0vMVvlXOk1MylD7xQv1T0eK6uOX9DvYw/BY0Qj0DfNBrUCTA6wBpsCeJNSbFeh2b22iniy70BA25PQ9HSu6ARlBi78E7lyAnHb2qTKXSVWE9oNY0YlCgqk138d2vF8F1wrUXmjWekmr236MuAzGVNPN+jR0=; 24:9zZolQLDl34RuHo9epg8lKAdYKup4Ntpxe9S9r3r1sbiPc1SADJR4EPmPjB2r5uuUoAN2FTsDu7vSDmcsApZaj7pIE/XIRj/sBZlk3D5bek= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 7:EHGKqmW08838kXwXUmguy3dPgRhgkMfnN1WREf1Nnk7jA0r7DL4ZDq2SaFkRX6Z+PIs/L2qIeI493MoLgq0YVmHUlRBH3f/bpzo7+k0CUt3pR/v89CA+l9eimqpGajck3BEWDZHLdcrpwAsPujtpC9yn2tMEpYA3kHbc5l6ctCClFGGtwxGYhtJ5JERc4afiB5p7O3tEz1JNnwwe7K6L3KGvJn30TtDsJD7gujRIOCcXqxf0NHg8CC/joFqNcDjMXk1bwrlbwhvL37iwsRoZU6Xy+reCWg08vtHmPwai0TBcf3bcSBGBQEv2zqwoy0e+hq3d9U1Q6eDA3R342Adbg3BeY1x9wy78njnRHjSCzRw= X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2016 04:17:56.2764 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1715 Subject: Re: [dpdk-dev] [PATCH 2/4] eventdev: implement the northbound APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Nov 2016 04:18:02 -0000 On Wed, Nov 23, 2016 at 08:18:09PM +0100, Thomas Monjalon wrote: > 2016-11-18 11:15, Jerin Jacob: > > This patch set defines the southbound driver interface > > and implements the common code required for northbound > > eventdev API interface. > > Please make two separate patches. OK > > > +#ifdef RTE_LIBRTE_EVENTDEV_DEBUG > > +#define RTE_PMD_DEBUG_TRACE(...) \ > > + rte_pmd_debug_trace(__func__, __VA_ARGS__) > > +#else > > +#define RTE_PMD_DEBUG_TRACE(...) > > +#endif > > I would like to discuss the need for a debug option as there is > already a log level. IMO, we don't need this. However, RTE_FUNC_PTR_OR_ERR_RET needs the definition of RTE_PMD_DEBUG_TRACE inorder to compile. I think we can remove it when it get fixed in EAL layer. > > > +/* Logging Macros */ > > +#define EDEV_LOG_ERR(fmt, args...) \ > > Every symbols and macros in an exported header must be prefixed by RTE_. > OK. I will fix it > > +/* Macros to check for valid device */ > > +#define RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, retval) do { \ > > Sometimes you use RTE_EVENT_DEV_ and sometimes RTE_EVENTDEV. > (I prefer the latter). I choose the naming conversion based on the interface. API side it is rte_event_ and driver side it is rte_eventdev_* rte_event_dev_count; rte_event_dev_get_dev_id rte_event_dev_socket_id; rte_event_dev_info_get; rte_event_dev_configure; rte_event_dev_start; rte_event_dev_stop; rte_event_dev_close; rte_event_dev_dump; rte_event_port_default_conf_get; rte_event_port_setup; rte_event_port_dequeue_depth; rte_event_port_enqueue_depth; rte_event_port_count; rte_event_port_link; rte_event_port_unlink; rte_event_port_links_get; rte_event_queue_default_conf_get rte_event_queue_setup; rte_event_queue_count; rte_event_queue_priority; rte_event_dequeue_wait_time; rte_eventdev_pmd_allocate; rte_eventdev_pmd_release; rte_eventdev_pmd_vdev_init; rte_eventdev_pmd_pci_probe; rte_eventdev_pmd_pci_remove;