From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f171.google.com (mail-wj0-f171.google.com [209.85.210.171]) by dpdk.org (Postfix) with ESMTP id 1BB83201 for ; Mon, 28 Nov 2016 16:21:13 +0100 (CET) Received: by mail-wj0-f171.google.com with SMTP id mp19so119172308wjc.1 for ; Mon, 28 Nov 2016 07:21:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7dABNWwKuU7xDuhN6yeXiiatIQkaCoylZYc8ByiW9GQ=; b=qP5Jbwoqecm/GJ5kD5COvAlmIMSTL0hzownwdCR3Xa1TnID0gQUEo3X+F3UD6NC3Ue FWanNoszy8OWeCSXme3ILbmgJa8aTsWZNG89RK9B7oCSeYTXMBA9cmsDcGOHtKk/4pbF vu4seHmZD43KH0+JJaDKSQpaA1J+YOrKlhruA3Iadt1fDUDJ05psxiLtd0dr9DIbBCl3 Ui6GgHrJ/wEnErbvLik+Tfoa5rI6P/AfS/6SOlzkXWprJxeh1lojPzYdCp8w8uIwrCww gtyhO2fB3hwWTndCsYfZxasJCpWrGZ3m0wWKMWGIwGvtJg7gjtV0Cj53qjfCvfPuSjov a59w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7dABNWwKuU7xDuhN6yeXiiatIQkaCoylZYc8ByiW9GQ=; b=j9UUJa4TqR2JLRNNK/XiiIrQeOnB01pI+utf+6dr0LLNGamlEyqZPWT3cipnEeNfVG 9imD7lp9fHtD9f9FX1Kuajmha5P+Uo13bkP5SGOpA3Ln0n0ZZeT49qm1+SkuszJiPTJJ 2YSIBhNxZac/JcgoGmETDpTDPlHfXv9f5xWUe4zvauESWb2JORj1omVLc0OORbEjjEnU i/3NFj+pKmrD1jO4HPPI4BEHsZ6j826SeBwQdG611Fmydo41G4IyrXAOSyaFyDXbZbke cODx3XIvUUx1MLQEZFm0e/Ijbvg/zXaocMgwE8YkAdZXP4uU69UQv+Cp9eEvey95Xqwu 4uxQ== X-Gm-Message-State: AKaTC00P4j3YIEOth/z0bIUGMBlMbZQl9lnjhDZypbEfxnbNPpqzKgow3Y2kTAQBieZqiyxq X-Received: by 10.194.145.70 with SMTP id ss6mr1079648wjb.158.1480346472813; Mon, 28 Nov 2016 07:21:12 -0800 (PST) Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:3c6:5100:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id u18sm29473997wmd.1.2016.11.28.07.21.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 Nov 2016 07:21:12 -0800 (PST) Date: Mon, 28 Nov 2016 16:21:10 +0100 From: Olivier Matz To: Thomas Monjalon Cc: dev@dpdk.org Message-ID: <20161128162110.23127b42@platinum> In-Reply-To: <1479768161-6123-1-git-send-email-thomas.monjalon@6wind.com> References: <1479768161-6123-1-git-send-email-thomas.monjalon@6wind.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] scripts: fix checkpatch from standard input X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Nov 2016 15:21:13 -0000 On Mon, 21 Nov 2016 23:42:41 +0100, Thomas Monjalon wrote: > When checking a valid patch from standard input, > the footer lines of the report are not filtered out. > > The function check is called outside of any loop, > so the statement continue has no effect and the footer is printed. > > Fixes: 8005feef421d ("scripts: add standard input to checkpatch") > > Signed-off-by: Thomas Monjalon The 'continue' statement is not always without effect. On my machine (but it looks it's not the same everywhere): - with dash, the 'continue' acts like a return in that case - with bash, it displays an error: "continue: only meaningful in a `for', `while', or `until' loop" - with bash --posix, the 'continue' is ignored... In my case, checkpatches.sh was displaying "0/1 valid" although there was no error. This patch solves the issue, thanks. Acked-by: Olivier Matz