From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mirq@rere.qmqm.pl>
Received: from rere.qmqm.pl (rere.qmqm.pl [84.10.57.10])
 by dpdk.org (Postfix) with ESMTP id 266D236E
 for <dev@dpdk.org>; Wed, 14 Dec 2016 18:19:12 +0100 (CET)
Received: by rere.qmqm.pl (Postfix, from userid 1000)
 id 7FF866082; Wed, 14 Dec 2016 18:19:11 +0100 (CET)
Date: Wed, 14 Dec 2016 18:19:11 +0100
From: =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= <mirq-linux@rere.qmqm.pl>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
Message-ID: <20161214171911.nupex5gi5jxbbbhm@rere.qmqm.pl>
References: <cover.1481590851.git.mirq-linux@rere.qmqm.pl>
 <ad817bb663ce3b8641b8884f1e994b145d141246.1481590851.git.mirq-linux@rere.qmqm.pl>
 <817f957e-80c3-bfc0-e02b-55f397581708@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <817f957e-80c3-bfc0-e02b-55f397581708@intel.com>
User-Agent: Mutt/1.6.2-neo (2016-07-23)
Subject: Re: [dpdk-dev] [PATCH 10/13] KNI: provided netif name's source is
 user-space
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Dec 2016 17:19:12 -0000

On Wed, Dec 14, 2016 at 05:06:23PM +0000, Ferruh Yigit wrote:
> Hi Michal,
> 
> On 12/13/2016 1:08 AM, Michał Mirosław wrote:
> > Signed-off-by: Michał Mirosław <michal.miroslaw@atendesoftware.pl>
> > ---
> >  lib/librte_eal/linuxapp/kni/kni_misc.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c b/lib/librte_eal/linuxapp/kni/kni_misc.c
> > index 497db9b..f0247aa 100644
> > --- a/lib/librte_eal/linuxapp/kni/kni_misc.c
> > +++ b/lib/librte_eal/linuxapp/kni/kni_misc.c
> > @@ -363,8 +363,8 @@ kni_ioctl_create(struct net *net, uint32_t ioctl_num,
> >  	up_read(&knet->kni_list_lock);
> >  
> >  	net_dev = alloc_netdev(sizeof(struct kni_dev), dev_info.name,
> > -#ifdef NET_NAME_UNKNOWN
> > -							NET_NAME_UNKNOWN,
> > +#ifdef NET_NAME_USER
> > +							NET_NAME_USER,
> 
> Probably NET_NAME_USER fits better to definition.
> But functionally, I wonder if you have a use case to use
> "name_assign_type" ?

I just read what NET_NAME_UNKNOWN/NET_NAME_USER is supposed to do.
UNKNOWN is for "old" drivers that don't know the source of the name.
USER is for a name, that comes from a user and as such is not to be
renamed by udev.

Best Regards,
Michał Mirosław