From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0083.outbound.protection.outlook.com [104.47.42.83]) by dpdk.org (Postfix) with ESMTP id 68F452934 for ; Thu, 15 Dec 2016 06:48:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=dSxmpzXPf5MZFBS7JInubgdT0rdMCDkfZI2TZqP5xsc=; b=Pbgh3W2j7n5KrdJmZ5I5TpA9/YFDBn7zu3WHnD9V6X1H2ftE3wRPKii4r+KeOvxax+SrV6djmsA+IXR7XyezVepF50bzFGJhjHKMKujDF9Vc5LcpJOTYFh+vnBqofs6ylGLNFWXsm4AeJ01RHT59YME3lNu0mD+7P0bk1kONqOw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Santosh.Shukla@cavium.com; Received: from santosh-Latitude-E5530-non-vPro (12.0.243.26) by CY1PR0701MB1728.namprd07.prod.outlook.com (10.163.21.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.693.12; Thu, 15 Dec 2016 05:48:53 +0000 Date: Wed, 14 Dec 2016 21:48:40 -0800 From: Santosh Shukla To: Yuanhan Liu CC: Jerin Jacob , , , , , , , Yong Wang Message-ID: <20161215054839.GB10211@santosh-Latitude-E5530-non-vPro> References: <1481680558-4003-1-git-send-email-jerin.jacob@caviumnetworks.com> <1481680558-4003-28-git-send-email-jerin.jacob@caviumnetworks.com> <20161214025534.GG18991@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20161214025534.GG18991@yliu-dev.sh.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [12.0.243.26] X-ClientProxiedBy: BN6PR08CA0055.namprd08.prod.outlook.com (10.172.144.17) To CY1PR0701MB1728.namprd07.prod.outlook.com (10.163.21.142) X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1728; 2:2TShfZu/VnLWz66h8xJPuXbMxD6NgaCjm0Zo6ti8CIv8wLNY9HoS96dLV8FYeDJCoc0O18hDdg+3W1jcYg1ImdDtnRrkMqnp8yMMSw9Pf6DsK8W8lnA3+Q5bsDth9WJadRtQUZ5gWRnYr5FTgli4mgZhHNZcaOnXK39dIIZXcaA=; 3:eIqHlEahtbIX7F597whfhE3UvzJHuy72xtLK7Hewa8m5ut6JEW1ncT47SO6vC6ILmahX1I5tV2x7oBGhXvSiXS5wnhJf/T4oMWWEQY/jGU+WoG1TDSZ78p1FIuAaw1nbIsHyv4xDWmbFpNZcJTy5X0aPHHczxjy1gEa1/cNgMc0= X-MS-Office365-Filtering-Correlation-Id: f4ac2593-9dda-46b0-20fc-08d424ae0e45 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:CY1PR0701MB1728; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1728; 25:LyyVlQ4SchtZvkAmmuLHmOkYN/ynM0tkFuy9//VLPdIMsoioCoPlBrOnR9ZvlTUhctgfwSU/O8WcrBWBA/MZR2fgRhQlTwrezEBVqEnm2wlhgTqWN09som7meH605Pl84+pIzuOna0jTqIlZSsaWWiyDBJ3c5h3TqxiVgigel17WFBNvpGrh9qVfRj2lwzl13XwG5rOQiLfpEjgLzEphkRc+wypRbKKp5oQicWZMAjNMPJQoSh6PjqifvdnLGFz1XgTk5PmjUu+okXqz+mqNbf18FjTjcW/SPEnQdebVmKvLoO9M9ukIqGXsoWC+YDE7GpPhW5nWKCIO2BSUDq3xDWZB09c/oujfIBiR2cxJFDTjBtT6aq9isUUZ5/XOSnkYG0/T6HGi6h3AL6lzZzF3owb+T8aJuMi06Nj2xi+m9hA4+qFRu6cJ1i8MgObFdeeuLYevBpqPEfPGIxVNJPVF8WdNJwxOMJLw9lRq2WCrSGlx56Awojw6NG37g1BtY2AKOC91p/JlDLdPelzo5qYJeJsLqd45P5B/mw0JIYzUwfbgIzeUfS+HtnDFX3KE1BSc1k0Tzf3cXmG6bc8fUdksdo400tHrsYyolNk8LqLZNpZwxyhOO9ZChplvpofo1SLwPObFT9Fiwp/Ws70++vnelz5wUPsMNxth3epDwJG63LiScb/AQf0K1Whp1Ui+Ksfw6Lt+Yyv7WZf7NoqNExx+lby705VGzxy8Y/czfGHzmHmOyz3H+h62Bnii3yLpUb9VQwCepbSQvMNMAet5rw8VsG2DB+o3pDb+/Gm1adNriD4= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1728; 31:A4tkG+H1OIPgS7KgxQxQw259JG+8L0Jw1jTymlERwkz9dX0u4V1ecE2nycWkRrjoFjiZmuCDmJLMgWMSmc5pzXIWIKnPdkMBFIrG5+/0Pg8EnvxvVRDQsEMHMqnUMTgyr8UqEWngR67YbpCNHAU+OT6B4kmmRUIAfxaYWNqJVjUnkUO6pFQHPfiWWHQJamPgQ2lm0ak9R71xpW7PFQpzQH24ZLCr+xLTmQYCBKp0NHWelowxp1SGZnHqwdS7F21xPmiZB4XKNdF2KANUQeBlzg==; 20:eyYih7FZGM2KhCl2UXw8rLzhrpcm2lw3DBMzv98i/kGNN27F3X1af8HdVHYP20t4MNk5cZMxtAEnXGyGUiuBO5APfB5EambPn9WWPh4IrdR3MaBGQAxxz0+zR71J05cOQ/Gkiv1w2nkwHCOHM0QB3hlLnEm/TC54sYIFPc93n6dfif78Ro9DDbVn3xsloD42DlwVh/xNLlkHB8btthGDrkVR2IgMD3Kw+AaI4bBnKgzxhonRHcuk63lFSTd0/nkd0drMqXdtJxZrLy/qr5H7+xHOY3rYk18AFo8fsJsVHIpfxTvTtTPFj/WRRxmAAolgkotgN3yxndP8rR5i9g93tb52er+VP2SDG63czuV99En0EFIlvHaZVEQXyRfyQpz+6uTFFlar2dPXgUDjWLerg5Hbv5BO45cyYGuSKmTp735Df3lZ02k1G2xCXE4RdcN8Rh7wmkJ1Dt7ksxYFOLuPGeJV8qNz+78SYlbSTvZ6NYm74fs9g7TFs3dg1sCMYNA5vuHHXX/38sYb8IOfIQGuUSdF8MDxXJkmgSnFIWIUcDxgK3i7Wjq93uMisRsLdefwzhZNTgo9OAhiYyhqyGIhI8ArYYPKZ4u3mj4qr6U2Z6U= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(61668805478150)(788757137089); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123562025)(20161123560025)(20161123555025)(20161123564025)(6072148); SRVR:CY1PR0701MB1728; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0701MB1728; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1728; 4:BZndGMooP1FyKUY1atsjfXd/RoeaD0WnHuS75TfLh6xFvCfdtyq1YZ+ZWRKj83GvgO1gxGb3wShsYZ03nBhsoG4f43I97wv29rysmRfIXyKVMbaYTGSwKoxoLYUmsTz1IS41yPaWmknGs5cdu/SaBNlmTfne6rSg2Hxvm/N4nVid6tPleZA3Ra4atsMwzTIo0DIo0wOeAp7FBWXWJ/3D0LRg0WP/Mkx9Fn6OocZiPNXRllavOsVHmu13OJjLzxw9GdCdLlq9GFAvquVJW2G9UXqB1XBjyum71PTRz4Q8z+ZBYdSQO+7PZ97v+sUHrEhkCB3+0hHRYzdshfcUlb3u5GGcmGEbw01UfZTfKNeFRzE/CC33ePYy5qjawzc1Dx4ExKkDyHWRWG0i+u/WjCQxZQp3NuObsN1p9bEHWoCGoZGPdPU+gPWMfVdMt6zX/MbFwkBi26jT+8Scq9vio3BZu89jUhEuyqE8Pl2G1JbrMlKGbbsZ3uYhkePahHQ9WNqG/8oLWQAB9ZalTBQ1bOP+iP7MYWeH4fVwWli22JAldbJc1dVOPmB1NvKHQtc7uZrp6tJS0wDUXOqGkgN6b338v3Eu3L0x16QvArman1IjhSjePsUiokC3fHC6jSRoalbO88wyCKfO05Jw1k3nb7jG9g== X-Forefront-PRVS: 0157DEB61B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(7916002)(39450400003)(39410400002)(39840400002)(189002)(24454002)(43544003)(199003)(97756001)(106356001)(6496003)(33716001)(47776003)(4001350100001)(101416001)(229853002)(42186005)(5660300001)(8676002)(66066001)(9686002)(105586002)(7736002)(97736004)(4326007)(23726003)(189998001)(305945005)(38730400001)(1076002)(6116002)(33656002)(2906002)(6666003)(83506001)(3846002)(46406003)(2950100002)(50466002)(110136003)(81166006)(81156014)(42882006)(6916009)(68736007)(76176999)(54356999)(92566002)(50986999)(25786008)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0701MB1728; H:santosh-Latitude-E5530-non-vPro; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0701MB1728; 23:0yCu/ALBO1VvZH2KDvC2RBVUV2idJBhs8EuJ4Sa?= =?us-ascii?Q?sNRLMMk6Rs9+cmYLrew8//SuG3VvSkLe4I+H9HlHoR5MU1iP9yZrPFHEV/Ld?= =?us-ascii?Q?6nZwlQbg0ixUN8XE8/TMJ9zb+IFYaittv3xO1QmSHmEmci11YdIu8GpOY5R1?= =?us-ascii?Q?GejvIuo6ELKE/GmkQooGR/AqoN4tsdySBVauAbZRO1J9daZjQwVi0sQTFLdl?= =?us-ascii?Q?Eml9a5VCLTWa9ISRDimfQtWiv1KaYwkShWxIB+Azo8JFcVURvBcYQ/iDk/gH?= =?us-ascii?Q?tDczB/R81LlE1BQuDU4PNY9/C/+vF1PKasQO2gXznD5d858Gc7PzRBl2kY0m?= =?us-ascii?Q?2OSzpNI0Ln6EslKQzLvdXEpp2o8Bd4podHHmG4kxSZze6HXdBZg7y2qRXHtP?= =?us-ascii?Q?o8GByVFzeELs+Ry+SjnWz62qIJb/MS0SYdc/vCKV1pzYF+9rM3D+0+BbZW2X?= =?us-ascii?Q?peWu9EmQSX000JVWHylp1+cB/uRhilV2aIflrZZSKvYmy6SLiz6Z0cYMAaTh?= =?us-ascii?Q?o4e9a7YbADy5t1ySIzO/IxcadDuWSsxlTR4uQBgyc9NmIxilZqkjwdEY9tiV?= =?us-ascii?Q?xM/67JZBaOa5GL+YsOUWnZcjodWePyZ0mivBx0UtmlZyCI8llSCKWkcrYAok?= =?us-ascii?Q?6ZwWYpkvouepi/ulxZzOI46FYdAFg40+VYlZiaZ75/XmViHHD6FkKiWK1XRR?= =?us-ascii?Q?JFDgw2Vp0987ZHcQqgGYvpa0CSNz5cnI6vWXoJd3QSrDLxibOU/Xhm6q8vlA?= =?us-ascii?Q?4aisbJD9Uwl4FjijmnRQqDWpERnQJo+1MYD1wVeHYHbweT/mGmJgdfRVoZHS?= =?us-ascii?Q?CEPx+e+ulJ48tz91Dkug7wxrVYerwo8TbL07OIhPP/fUjwiMOcKQIxdUAjMs?= =?us-ascii?Q?3BTgN3Iz1Uq4CcbX4m4JKDaBM8MmET3stJ191Fu/Ms+hbYoNZFKk44+cmQHG?= =?us-ascii?Q?87cXk2o42bKla330XBGxeU+Ob8rUyhN/STwtW444RphI9iAZ+GUS+Ou2gFfy?= =?us-ascii?Q?e9SeSFybo+1vlnvTF2P9HHOtkuCY+XEhAHi3UyBjmyQfgOm4yDveCXkkbFoL?= =?us-ascii?Q?h31H82yYpkJ+TlZnn9pB4bE50nPFq8mE1aq6j+qTr3+tb97NvRSOwiMAo18f?= =?us-ascii?Q?DnL8P3FQ/CJfMFn9Ke95X3ViFcrkyS/DZZuT0rPMKOZiKFlW6GBLTBNmTLvL?= =?us-ascii?Q?4Bz9vl1tz96TDemv50ftftGjGqKDxdkeoFIDbhHHxTKvkwIcLSYCOCD3yORG?= =?us-ascii?Q?gB/TUE+sCkGvgtzU+hB1GG223Bd9nTQoAu5uRlPuU79RBshxVdfNw7qQpMMy?= =?us-ascii?Q?XPjkt8HzS7DtLA5FpwEek3yM=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1728; 6:EU7GpXCltPPTkCeklFLg8TvTr8fN+dAnvTpuRhWcn0pRGrLR+nWWb124i6xUBAWmpMQ7/bJY/neAtOCdup7LJEkOxFl5mqmfXhdhgQbJOMa+njBNEQE3GX7et/bqIgKEq5sddrmAtpCTvHpLo5iNGkWnP/g9L6Wjua/P6sj9IepYQQR9rH9Y2I/ksG7HEzpbZRbHH1l+OYjZL894K8XlLC6jpoKRz63/ZQzDQmSSo+Z94gPXKUJpmdeVffyle4ZUfWVkY4ft6FOocWKy86+L3aoug81YWaAtg40al0bav5ndXoF8JPp5oKafbgmoRGEi; 5:xu4hpmZzpzBbSPAVI97IxgweQRm+MRYg/DE9eyb1KXXb6Rwf9T7gig+bdMVq7fM1cgL1K6xQuKZ2Zh+GWWakjm2BR8k9xaacUE0cmTS7C4A07Lnx6w+FbGFFym1Q7wHBRkZ7dmakwUhV/la97PHweQ==; 24:Ow9GN47BzbuXk3qfASpyVM70zmTjh53Nt86KmshaPQYAU/pKa9FNzAZKqMtiHItsOeCOkTN+n4agwJhyaC2hC4MokOjwIB0GnVCIN1jJaLU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1728; 7:C5LcFApUjG0axi1uK7+cmw2j/V5q4CSEPwrMO+qujLG4DSGyrzSqC7qNlmF96EVkFZVwXvw1AeFjnOKlia+Pf5DOthu6V3nM9qJkuoRogSgu0eFfA/5d9hwiWS/jocNdWm5PhXQf4kz64gnwsm58d7XdEmBl/y6EnVl9fjBh+RkZaZ9mtU9z5be7SvsCr8pYko/CDPm1v/B1l/oD+eTvcF41Dp1xXeDc4CsBRrHhvenDlbqb75Oab+uou9oPGkkgbD0qVcw/ftnCVerMtQRgb8I58m1VQOOzLxeDCvinVozBbXjp9PwymDjb5BLxFu1my+qnNldPAuml6wAuuZFOr/gk/C2tS6g7The2gqibuRA= X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2016 05:48:53.2309 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0701MB1728 Subject: Re: [dpdk-dev] [PATCH 27/28] net/vmxnet3: use eal I/O device memory read/write API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Dec 2016 05:48:58 -0000 On Wed, Dec 14, 2016 at 10:55:34AM +0800, Yuanhan Liu wrote: > On Wed, Dec 14, 2016 at 07:25:57AM +0530, Jerin Jacob wrote: > > From: Santosh Shukla > > > > Replace the raw I/O device memory read/write access with eal > > abstraction for I/O device memory read/write access to fix > > portability issues across different architectures. > > > > Signed-off-by: Santosh Shukla > > Signed-off-by: Jerin Jacob > > CC: Yong Wang > > --- > > drivers/net/vmxnet3/vmxnet3_ethdev.h | 14 ++++++++++---- > > 1 file changed, 10 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.h b/drivers/net/vmxnet3/vmxnet3_ethdev.h > > index 7d3b11e..5b6501b 100644 > > --- a/drivers/net/vmxnet3/vmxnet3_ethdev.h > > +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.h > > @@ -34,6 +34,8 @@ > > #ifndef _VMXNET3_ETHDEV_H_ > > #define _VMXNET3_ETHDEV_H_ > > > > +#include > > + > > #define VMXNET3_MAX_MAC_ADDRS 1 > > > > /* UPT feature to negotiate */ > > @@ -120,7 +122,11 @@ struct vmxnet3_hw { > > > > /* Config space read/writes */ > > > > -#define VMXNET3_PCI_REG(reg) (*((volatile uint32_t *)(reg))) > > +#define VMXNET3_PCI_REG(reg) ({ \ > > + uint32_t __val; \ > > + __val = rte_readl(reg); \ > > + __val; \ > > +}) > > Why not simply using rte_readl directly? > > #define VMXNET3_PCI_REG(reg) rte_readl(reg) > Ok. > > > > static inline uint32_t > > vmxnet3_read_addr(volatile void *addr) > > @@ -128,9 +134,9 @@ vmxnet3_read_addr(volatile void *addr) > > return VMXNET3_PCI_REG(addr); > > } > > > > -#define VMXNET3_PCI_REG_WRITE(reg, value) do { \ > > - VMXNET3_PCI_REG((reg)) = (value); \ > > -} while(0) > > +#define VMXNET3_PCI_REG_WRITE(reg, value) ({ \ > > + rte_writel(value, reg); \ > > +}) > > I think this could be done in one line. > Ok. will take care in V2. > --yliu